From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F5CFA034C; Fri, 25 Feb 2022 11:21:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19B4A4115C; Fri, 25 Feb 2022 11:21:20 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A73694068B for ; Fri, 25 Feb 2022 11:21:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645784477; x=1677320477; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=40F8hRr3rg+yyFivQzH7NNXKVxZk+i0FhF85xp35y3k=; b=Zd6N1XOOT6q3Mn0JDd43zR6yy4sC3r2c/m22UQYECkvuik5Xdqwpl2dd uE1dgIN+vvUK6jKlNw64s8o/9w3glW0DeniZqFjWOnEn8nrSyIZyVy6YZ tg8yJbj9TNCuDv/xzX8ngxnx7kEzYpbX+RIGldPL87Taim1tnFXO9DAWO c81pmSb9zSzVeIPJ+NL/YrO8pRn4M+EYmIcd3DASAWxGpqw3AlM7m07RI pSi11nNGmXkpFb9tMbi1nAkvbVSQdIL9/eA5UNtaU+gNzSloj50I+CSKW plbHx81YWrUSxV4rsKqkoE550pp4QuMUfuzGayeElsNAvuWN6680o8IIk Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="338907811" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="338907811" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 02:21:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="506654044" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 25 Feb 2022 02:21:16 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 02:21:15 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 02:21:15 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 25 Feb 2022 02:21:15 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 25 Feb 2022 02:21:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9a77pnMRROWWKQG/gS4SMWKTpcV2+I82vbPPDgk3ueuDz9aVL7QiFOnyJac6zU575CDFu9/xKqh+nLyabJ4SiXEcRRChTKa3n0KdtEcIvWOJm5tmi1en0qbjGWVCiY0NsbkYK7/9nu5UmfhAMfSe7ibpUwXg0exJ1IIjzteKnieD6lyi3j4BAGlcvOO7TfdrmfJiB/a9LxUcS8Q40CCR+0mqjk036oFy7OMmHEpRgnRe64wZcbdUe2u3pwdHgoTS7MFuB1N6BdrbCZguuaAxnTvZj+NY94n4a7YYE3ouwKCTTefW6bjJ+0Ctp3MH60sSFG+uFOHwqcbwy4G5LHrCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JHiiYKhw8Y8VqOPEweXjIyiz1wVsVjV+JgPxGRywdZA=; b=gm0FZ8J3aiE3DNjn9qSQX2CoLG6GLDe565KgQIFii/eOYmfNod8xUyj1AZ+BOh5K+4S5MuAH/P4WS6UQT5S4wXsqQu1GGRFMrMTVkFxrqotw6HO8Bn3KYICtAdRjy96aVuQkR1xLuskbGp+Y7bsXhGvCCNjAUITOoAEj0Th7mCgrnZlFfu5gepTRa765q7nBC55drA4Q/Hwv26Hk0wt8e5So0PKfRO4mkarS1UwKHPY+AI1RK1Wu/z8o74KRwOY1i9AN1eqWkgPgkK9vs6B9c1VKIHDO6TRSndQqRQFv9Lay1z9axCbhEmv4JQvU5Sw32+XMa++s9DxjzvSso39EsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1979.namprd11.prod.outlook.com (2603:10b6:3:10b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb 2022 10:21:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022 10:21:12 +0000 Message-ID: <63900290-55a4-3e99-26be-dbb69f5520f5@intel.com> Date: Fri, 25 Feb 2022 10:21:07 +0000 Subject: Re: [PATCH v2 5/5] doc: update doorbell mapping parameter name in mlx5 guide Content-Language: en-US To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Slava Ovsiienko References: <20220222124815.2587851-1-michaelba@nvidia.com> <20220223134834.2840916-1-michaelba@nvidia.com> <20220223134834.2840916-6-michaelba@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ad93dda-2e36-4ae3-620b-08d9f8488c33 X-MS-TrafficTypeDiagnostic: DM5PR11MB1979:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tl4ENTrIYnvnZMKcgfkcGQfMJsLJXlKGY6pMsysXehIQi2TugnsvFEsUbRhtRBQQr9d0y/k6q5lwhKkReXTFOodTl+g1f5TpRsSQ5WgsqwlzIqIJ3a2q3KmQk28Ao/RtmSgPAWeMZkSW2rPoFQ8DuPAUsZ8ZdlCFbB2yXhkHUPiSlQ2JUswyC4POeah5rCRQ3s4yXkRdGYeKuLjQhPwZoqKevNpjDo9FE/ylhWo55vPAK3UU8Okdv7lSqW4f/NCRClY08SMGSh6eaoi7MYkkLpmlwWL76BztRnxyK6BnSMFbOx1CupjfU1alEHBIL3iig1u6k0ejPOIuAupjRRg6iOLRa2UqL6NC6cX8+BmqfkrGKsH/YqKNR5w4DaBEgD/GnMuvug0Defym6NwQl2WqYQ8RBKKmma0fObWvxe4jt89uGhuCUQOQj1NdhRfNSFsISvP8RJeBPLlXAIC+vLQjW8Nk6yKZOsDyj9z/PVwXqCIpwS/P8wTYl6urLCtJVXYT8SO9NVpgBra/XY/eI9v9oV0haLbfvz4vyL4AgpgE6sDsF1gEUfTWU0wLxHRffRK1WErtHsnmZ++qr8X1S3pRg6kvFugqXaFlglOEjUSJc6/nNBKZ6n3D5/grBvL00Xv5QE8e9ZuF+z5PSZHUh8dn5YWvJITgnvBQIc6xVG+Na53TLrC72RxIHiPOhe4YUaScFwjf69Bjev9jjl+MzxNHIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(5660300002)(8936002)(2616005)(66556008)(38100700002)(15650500001)(31696002)(26005)(4326008)(8676002)(66476007)(186003)(66946007)(36756003)(110136005)(316002)(31686004)(6506007)(6666004)(44832011)(54906003)(53546011)(6512007)(86362001)(508600001)(83380400001)(82960400001)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEtIQW5JQUNxalFpUi94VlJGWGh2TXVWUXFZekhpT2dLUlBuZDV4SzRKbGZY?= =?utf-8?B?WlVBVkJwT0ljNUVnbUZldU5ZalZ2WUpva2Y3YTR5Y1RzeExGU3ZPVUl2Yksw?= =?utf-8?B?U0RiZXJsMXhjNm93TENpWWcxZTJnTkc2N3pEdEZma0xkcHJwbWZvWXQ1bDIx?= =?utf-8?B?UXAwSEFGUk8zYjFFa3dtOU1BU3R6UzZjV00xMWRvcjJZV1ZpaFFibTJ0YUQ0?= =?utf-8?B?eHFXdEREZzZPMUUwS290WDFMd05kdElSZnFqQ25HYTRSRlZpN1B0bWFiN0pI?= =?utf-8?B?aUUxYURXL1lVWmZ3ellsckJPejhPaFF2SmtHL1Z4YUx4OFl3VWNVWjJqSHdx?= =?utf-8?B?RVNTbDhPNXlSMXdNc0h4REhWZnFXVjdvLzhSclB4MUxaMEdMN1V1c1R2V0VV?= =?utf-8?B?Sk0zbjlxaXhqa21QTXQ1TVp1cFpwUUpBbkp4SHVvcWFUYk5uMlZGMUhKbXBV?= =?utf-8?B?RWNHbmp3eW5maFVGZlNwdkt5WExNRlZBYWpTTlVJR2xmWGcrUm9PYU5VaWhR?= =?utf-8?B?T0RzZk9JbExYMGdiV252MUl1Ulo1cEVxaTVST0xiMWszU3IvamN5MUM5L0tj?= =?utf-8?B?WUJnRlZQc3BjVG5zUk1FbThUQW5OcUkzbWk4djNqVmZNSkFYNm5kVWdiMWFD?= =?utf-8?B?NjU5RzRJOStjQ0RYZHZ3dXdSQlFLVjZFVWgxdUtTUWxTd0U0N3pvZ1p5a0wz?= =?utf-8?B?QTBWRVdBc1F2bXdzelhtUU1xRldCVmJvY1ZNKzFacmFLdThNL3ZONWtrRGQ2?= =?utf-8?B?S3F0VzZ5T3dFVkJnNDFseGQvVjVmTlVvY3NBeHFJNFgwaVBXSHhHbE5UWnBa?= =?utf-8?B?N0ZOMWUwcXd1emdlV1NXS2c3dTFsaG9pS3dOV0RSV295dnh1d0FXWVdHeFZT?= =?utf-8?B?c0U3OXp2UU9tQzBWOGYyaTdhalkvYjRPN0I1Qm1xVXJQZVZ0TWc3RWgvSER2?= =?utf-8?B?Zm9HclJGRjd5cWd6NUhWNU05MVczeWYrQVVYOXdVWXAxR1ZwV0xaRjdGQlFk?= =?utf-8?B?S20xcGp3N1FkVG8rN0ptNEEwL3krazZYallLbElvZnBUTnFSekN6b0QrOVBD?= =?utf-8?B?cmovWmU4VHRueXJDcnBZUTF2ejIzdHlwWk8wSkd6MnMwRDFWSnFjdkRjTzY4?= =?utf-8?B?QkovaFRDSU1SSnJyMERMZ0ZMMUN2dGUxUlFiWmRlU1NJVVdtRXZZN053dExO?= =?utf-8?B?UWlXVlBJVTY2QnpGWDh0TUU4SjMwQi9xUDhZeG16TWN2U3lobi9FbHlzZ3Vu?= =?utf-8?B?NXlGOS9pNnk5Q00rejQ3M2JPd2k4Zi9lT2dHQXROTzQ0emlkNWhvM25kdzV5?= =?utf-8?B?aG9rLzAwZzVOL1JYWTQxdHl0YkxVb0RhbGxnS0JkejVRcWtYcWJsaVI2OGtZ?= =?utf-8?B?SUdoaS9BeFpscTI1TGRXZlh6VWhiVVlGU3VIampBWStzR3gzQnhvTlJDMkxI?= =?utf-8?B?MEdvMG1aaXpIUmlVVEtQZ2hzSTJacTZYTnQ2Z3Z6eWFDVUwxWTlmczYzRWhR?= =?utf-8?B?TUJIZXR3NG02YzBreGthSUNVczNmQXR1STExY0llTkxLbDJBRFM2K3FQNHBL?= =?utf-8?B?MGNtVVhWOUovVENNY3VlSEV6eFNTSWI1VHdkUGdwY2VCWmdMdVU0N25WeUxO?= =?utf-8?B?NVBkVHdnd3ZnYUFzcXZGUG45eXNXWktUbWlCNlp3WXJPK1NSYVNXaFAyMTJt?= =?utf-8?B?aGFJTVNvSUxEdnVwa2h1N1lmeGtvOVUwWk1DTysyMDVQRlZhK2hUK1Y4SW40?= =?utf-8?B?N21TajN2Yi9tR2VSVDdNSDVHNGdIQ2FDQXkzMFdZN2hpaENLZS8vZlJmZXBN?= =?utf-8?B?VVpuR2dvSkNDcGVMQjdLbmoyTFk2K3c2UlQ4YnJ6b2QweGV0VEJxay9xNmJm?= =?utf-8?B?d3lYNHUxQjlXNjRhRUhLZ1lqNkRpN3MvY1FBcjgycEhJSHZHWVJpTy8wa0kx?= =?utf-8?B?bzlsSUhlM0FHdldzV2UyR2FKeUQvV1ZKNmRHSU5uMm1keDFHdXplYkhIV2t3?= =?utf-8?B?blVWc0xseVRPTWVwQktnK1JhVkQyUFd5aUlPdmNyKzJRcmk0MVlLOE1mNXpB?= =?utf-8?B?TkxZWlp6Wi9CaE9FeEttdFZkOHE4M04rR0UxSHpYK1dhUS9kTTYyYk50cHdi?= =?utf-8?B?Z20rQ3RKTzN6RGlhUWp2cldScHBZbllIRWtkL0NNSyszYVJHZFRGZ3JEMHQw?= =?utf-8?Q?//BByQQ5Kkg+1zWMlNXEae0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad93dda-2e36-4ae3-620b-08d9f8488c33 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 10:21:12.5646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uwT8B1DVuakJueTM7QKNsiRzFQf0VEjVeQzY89gzlBiC1t3mmMKORGdwJq5/PsPTRpOwYXuUwDYTH1wCb4au9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1979 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/25/2022 12:01 AM, Michael Baum wrote: > > On 2/23/2022 11:48 PM, Ferruh Yigit wrote: >> On 2/23/2022 1:48 PM, Michael Baum wrote: >>> The "tx_db_nc" devarg forces doorbell register mapping to non-cached >>> region eliminating the extra write memory barrier. This argument was >>> used in creating the UAR for Tx and thus affected its performance. >>> >>> Recently [1] its use has been extended to all UAR creation in all mlx5 >>> drivers, and now its name is no longer so accurate. >>> >>> This patch changes its name to "sq_db_nc" to suit any send queue that >>> uses it. The old name will still work for backward compatibility. >>> >>> [1] commit 5dfa003db53f ("common/mlx5: fix post doorbell barrier") >>> >>> Signed-off-by: Michael Baum >>> Reviewed-by: Raslan Darawsheh >>> Acked-by: Viacheslav Ovsiienko >>> --- >>> doc/guides/nics/mlx5.rst | 34 ++----------------- >>> doc/guides/platform/mlx5.rst | 39 ++++++++++++++++++++++ >>> drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- >>> drivers/common/mlx5/mlx5_common.c | 31 ++++++++++++----- >>> drivers/common/mlx5/mlx5_common_defs.h | 8 ++--- >>> drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- >>> drivers/net/mlx5/mlx5_devx.c | 2 +- >>> 7 files changed, 72 insertions(+), 46 deletions(-) >> >> Hi Michael, >> >> This is not a document patch to update the parameter name, patch actually >> changes the parameter name in the code and documents it, updating it as: >> net/mlx5: update doorbell mapping parameter name > > Hi Ferruh, > > Your argument makes sense to me, but most of updates was in MLX5 common library so I think it is better to write: > common/mlx5: update doorbell mapping parameter name ack, updated accordingly.