From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0060.outbound.protection.outlook.com [104.47.41.60]) by dpdk.org (Postfix) with ESMTP id 3AC831B71D for ; Wed, 25 Oct 2017 13:06:52 +0200 (CEST) Received: from CY4PR03CA0090.namprd03.prod.outlook.com (10.171.242.159) by CY1PR03MB2361.namprd03.prod.outlook.com (10.166.207.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Wed, 25 Oct 2017 11:06:50 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::148) by CY4PR03CA0090.outlook.office365.com (2603:10b6:910:4d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 11:06:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 11:06:49 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9PB6hEM019002; Wed, 25 Oct 2017 04:06:44 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "borisp@mellanox.com" , "aviadye@mellanox.com" , "thomas@monjalon.net" , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "Mcnamara, John" , "Ananyev, Konstantin" , "shahafs@mellanox.com" , "olivier.matz@6wind.com" References: <20171014221734.15511-1-akhil.goyal@nxp.com> <20171024141545.30837-1-akhil.goyal@nxp.com> <20171024141545.30837-2-akhil.goyal@nxp.com> From: Akhil Goyal Message-ID: <6390bdb7-698a-3b04-cc27-99eb2a1adea5@nxp.com> Date: Wed, 25 Oct 2017 16:36:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131534032101118282; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(376002)(346002)(39860400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(189002)(199003)(13464003)(24454002)(189998001)(316002)(498600001)(47776003)(31686004)(50986999)(81166006)(76176999)(54356999)(229853002)(65806001)(65956001)(230700001)(8936002)(50466002)(8676002)(305945005)(4326008)(8656006)(2906002)(15650500001)(83506002)(68736007)(104016004)(36756003)(23676002)(77096006)(81156014)(356003)(53936002)(64126003)(86362001)(31696002)(93886005)(110136005)(2501003)(33646002)(7416002)(85426001)(54906003)(53546010)(6246003)(58126008)(105606002)(2950100002)(97736004)(106466001)(5660300001)(65826007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2361; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:bwCoaNdNSq89r6KkHnv0epMZ7XOYuTAb6uI2+sSXoVEjcOsZBQRk5stNMpvacctjir7QQLFz98itH3PDH9EXWR2zHvDBlQevRcLTq61gqKX4XjOD17505E+E/JezVGTM X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8589df19-3020-4d71-afeb-08d51b987db7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4628075)(201703131517081)(2017052603238); SRVR:CY1PR03MB2361; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 3:NZ6cEfFy1dMVjxhZZqT+oxI6L6SGNf5xnKEFHQHIy7ckBObf0juQGQihSOP4+076dqp6aJLRQNQPNw0WgJ4Ip2CGdtD0oV1SHHyZZlwUZ+3MQxCVXk2WS953/fKkA4ezJ6TixD3mJXDc4PV4skNNxhQY/mvb3Ge7T8yVOhWPgfT7Xzy/j2Gw5ATBTNwEzW74f9GeLW0Nc8N940CdVAoiP8gCqlCZo99uIkWcz13jtna9Ju+jVKpyltbNxqg9A615YHNNxNvGcC45ik/LX3/BldaEH7VZRfpaV30g8M/bbqMr4hoNGPzThir51HBThDsUv3hDLoXUvbvymgqxBlk/MJO47/cR4BSNho97omwW71E=; 25:9hp61ARHaLLjvvT9WpEgRhguyym3kVZpulSt2GHJvNarhA6fP/HJ3czAnslVKBtxnFKIuPGdTd0pMuPcZuCUhb3D6lVExmxdqX9T31y42ZSA95fhw6WeDfzKE/TzYytFWWE18JYprWd/RueTHzJRES+AP67mQXYWgL2C6YdNtlVn30YVNllpckg09vK0Qmgeh2pE786mwxzRiMtHnmVlRjHinYPGWAt/yccip1nlBBl8CsjfYAK8YAiYMjdF5o+/4BciUnUCEE8zbXhyiez6Lbvi63Nr/BfyLLGXJ4Gk7vHnEiWc3g/vKCk2sTPBxbsXxlPoUHLhM/oGA/3ANLnUDA== X-MS-TrafficTypeDiagnostic: CY1PR03MB2361: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 31:Q+mTKNQlvD2mEVSe7mMau5qUtWxNZNBOXXWXn3a6f2KVVM7wP6L4qi6FfmVUNxeEETqBFyIMTHa4ydixUHG9Oo2VhftzUu1WqkEkKI3bUAVOjmLsEIlpmwQR1MyqmSPx01dvG9Dr6/2ehiYJMIaxTTPC5XlWMcmahTI0rW1h2aCTgyjNAgxZMu4vg0LgsPGozL+TCjci4h0Ld84Lr11YKM88c74sdBSyfWf2OH51cws=; 4:9WCUvk8K79DWhXDIX5GRU8fq8y+owszUXegINxzErjUOkyjTXZ4nHKUe86y7SUeqjUCh16AT5ru2DdF7KlEwFgHXXbEOVaA3/PH4V3Ox8V0Dq3RXSsTU8f4D7CR+uE4xBZckPesc1ve25OTZSN6iugVdGkyFniRXiBVuz8GbEaExbxm8jieT5CfLNmB6J9/js0ASc2ssgY6Rr1KS4z/UpxgQe5hEHqncx/KGrulJ4YyXyw5IzUnxBeKMOiB5M4xTssX7HbhjIyXU5xtVzoMRDsx6NYwu2fywRa1rWCixD+bM/C08H+RFxCjbQx6gTqkHsWXRWRnF2cPN9Wc87sVUJqWgusIGJnCaBbq5e0u8gHOmVph9yr5AZCpOf+5VTULb X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231020)(100000703101)(100105400095)(6055026)(6096035)(20161123565025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(20161123563025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2361; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2361; X-Forefront-PRVS: 0471B73328 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYxOzIzOklUOGorWFRESTloSVNtVmJHRWw2Rml4c2lq?= =?utf-8?B?b3AvejdWeXR0c1Z0WlRsb3FvTWY0UjNJUUk3YmVJZTYyaFg1TW5IcFYwT0hi?= =?utf-8?B?ZzRrSCtnd3U3TzZkOVQvWFlBb0lDK0xVVXhrTmtXWlVtVURmNDB2SFUvanlD?= =?utf-8?B?R0N4NkFXOGtxSHFRUDljRk9makRvbUIyQVZnS0pBK1c2SnEvSUJOT2hWN2JC?= =?utf-8?B?M1dKRERBNXQzeUVWdFltYWR4V2VkTWlMbzlRaG1YMnc1QUFJMXBMdW1YRWFr?= =?utf-8?B?MmpZUVp6MUJ0bTN1K1dQVitEK0g5a0RSRUJhNVBSVGdxSkZaWDRYM2M4OUNP?= =?utf-8?B?NnF0elp5MFZLeFlNamRPVENOMmJ1SjVQZ2Q0aUpOek8zNnArYmtVMjljSXRJ?= =?utf-8?B?amxoNEtlZkx2cUNzTE1CZ1hVdWhhUGI3bUJOVDZGbitpVVR2VE56UlM5d1ZC?= =?utf-8?B?VTUrM2JkWVZsbTRFZHhpc2lEcVhTSEJta3ZLd3grTjkxTVUxeXBiR1FtNmlC?= =?utf-8?B?d3Z5RDgzZ0VnZzQzcVR1NE1iZEM2eE1ZVm9rdnBJNm5jWU53THpmRFg2R1FU?= =?utf-8?B?a2hrMXNrRjhlZ3U3WE02QVlTVmFKMzdlYkNlOS9qNlVXS1hKTkNNM3BOd1RQ?= =?utf-8?B?a3ViWEJ3MmpPdEFmS3pUd2dnTlBTU1BvdUg2V1NWdE9sbkdFTWJjSEJicFp4?= =?utf-8?B?K2RZWnhueGt0NytUS1MzakhDZk9iRjdjY2tIMWc1K1VxVVlvZ2RJWGxKMnAw?= =?utf-8?B?cm9qdy9Nd1lmUFJkN3dpSk5CUjRma3BQODFpNlNURzFqczlZMktwVUtFWkxa?= =?utf-8?B?bllYcXFxY3lUVEpsLzdRSVNyMnBqOWthZjJrVGNJYWRqbHFTZGZiRjRkNjNj?= =?utf-8?B?ZDNOYjdTakZqTkh1YnUrcGFlSVBweG5SdUsyL0VDb0t3cHh4UkRrMysxVHlR?= =?utf-8?B?cmNiemZRQVEzQUJxcHFZd3lVZ1NpV0k3TVNKTmVUeEovNkVzVCtWRkpWVVdt?= =?utf-8?B?SzdWcEJuZUZydm1JbjRWa0pDWG9YWDBZdlp1aWxlZkpmd2ZMMmd0bGJSSGdu?= =?utf-8?B?N1BWL1RSeVpqcVNiVzRGUmFyS0NJM1R5NU8za3FiVVpydUNRMkxrS1FTY3hZ?= =?utf-8?B?cFhBRFhwWVdFaE1xVnU5Y1UzNWpjT3JRVG5DNnpCQUFDS2hQVVFNV3g2NHFU?= =?utf-8?B?UHRhZnJSb2FmQ1N0RTM3MS9YRzNYODR0dFFKRVVHdjlOQmJ2dTYvd1R6L3dV?= =?utf-8?B?YkdKVHYxTnpHMUxlaEcybno1OXNVS2VpeGlrZnRpMUJINTNyOGMzb0RYMXNk?= =?utf-8?B?RkowUjhpNWU5WjA1TmNxNGQ5SXJ4WTZOUmx1cEVkV1d3ZXE4azlEeEZpZ1R2?= =?utf-8?B?UzQ3TXZseHd6T29LUEdBUlQ4Mnp6S3NDSStES25VRDRiZm02QlpReUF6RWJQ?= =?utf-8?B?QzVBSWpvOHdGNy80Y0F0c0MzRUM0Zk1aM1BoakhzQVZ4ODlScDg4WXpYS3lk?= =?utf-8?B?R0g3cUFSS0REdTZSb2ZHUXNlcFdZZU1vQWphZk45UTcvbWlpSGN3d213QUlF?= =?utf-8?B?VVhmeHdmd3FmQ2J2UWRoL1BUNFlubnMzZWwyWXNUcmZCSmRpdk5LM2pscVA3?= =?utf-8?B?ZDVvazhGSGhqUGdGcmJJeVJCWTJGVFpBcEVZS25zTmg3ZjZZUFBKd3pFV1Js?= =?utf-8?B?VWNpcXRSNmg4dGJYR3c5dno1dnVNUmpsOFM1OTdTZGovUmpOM0UrT0RIamJh?= =?utf-8?B?bEl5eXVMZTNIOXp1RUNiVjRhSEQwc1duMUtmWmJNTjlHNzVHR3Z0MjJHaTVC?= =?utf-8?B?bWFLK2lYb2RqK2JMUVp5MkpzR3g4Y0d2aHVVb2FnQlNpVWVzOHhNRS9uZ2pD?= =?utf-8?B?Y2kzNjV6Slh1S29abVFBK2pRaWZzaWJOV1VXSDBoSEI4ZjlnWklzODNoNWJz?= =?utf-8?B?MFVHUk1sUzNHK3ZYemxNMXdTUERpcktDQVdtcjZjQXAzZVNzYktKS3BQcit6?= =?utf-8?B?cEpOQ2dWdldmYTJDM01qYmt1NlN2c0c0THZ2UT09?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 6:qVyuVl0/x6YaaYwvo4Jd5rI0OLeJRGBm7L+/z+aOXHi4XcH1AYPdG875k/cuakVWj865dvDb4SElu2STD9enw6OFNcKddInl5K3jnqLOfGFBTLcV1jJqlShCXb0Nzib48jB2UGz72G/RVUhJBcVMUY1bh2AcBjolgT8wtZwH50S2TNA24vHi3LnsokBUsBIS39hUKDLlE5Lj9k8AndzO2fadF7bY1KgTe0Ec8DBioBvwUzHtZtktRYCXvy9CKxomiTde2KKzVFSZ77a+B5piGjKULaohHIGjHxER/MAUF6a+0KRQu6doSUTH3d6tFxLgxG2ro4ktq3ZJpl/sgVIRkfthDBOH4GjlNhIMxHIIlWQ=; 5:zQO30XM5Kd4gMTrAWc9sLW0ncNvgDFj4F+iNWQ/PHQtRd2d9dJIcBht4Lpe/o2NDYTg3+zAu56GZ+uUtyE0ryClnfE+rdJ3p2VWk2bQn9CBXzQlhkle22UqTcIJrc7b0bDEgwMov0miwowX0jroKhkeEcB5avfn8tAEFRqdAPbM=; 24:IDv3A8vUviBl7KpyMH9mZdUQxPc7AFYt4GlwA2dUarmTKaw9WsW2ajo6gHzH1Zc6mr24N+9I//tTsVT1BYj50L4OBOholgEF6asiZVSwcPw=; 7:54WkUmAgYXo0YzVccWvUWcqs0cQbroc2SytXzY+DsI6do+3+zAFfhyuPYrG3ktB241zNNpkt2l5Jtz9sJXZBPrvCmgo7LIWow3Y6qa53oBD65EwpHzrNQj5jTD2sjnWtl6q66meIP/cnPtBGApy37T7j6yTq9dTt9NcJwu+H1n3eqicvAbc1BdMiO2FnIo01NJTQGS9uQe1ztnxXBNLx6azkr0iDW3d3UQPWFg7kXaR+VZodlyN6t2Vw2CXODh7d SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 11:06:49.8778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8589df19-3020-4d71-afeb-08d51b987db7 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2361 Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 11:06:52 -0000 Hi Pablo, On 10/24/2017 8:45 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Tuesday, October 24, 2017 3:16 PM >> To: dev@dpdk.org >> Cc: Doherty, Declan ; De Lara Guarch, Pablo >> ; hemant.agrawal@nxp.com; Nicolau, >> Radu ; borisp@mellanox.com; >> aviadye@mellanox.com; thomas@monjalon.net; sandeep.malik@nxp.com; >> jerin.jacob@caviumnetworks.com; Mcnamara, John >> ; Ananyev, Konstantin >> ; shahafs@mellanox.com; >> olivier.matz@6wind.com >> Subject: [PATCH v5 01/11] lib/rte_security: add security library >> > > If you are making a v6, I would change the title to "security: ...". > Also, there is an issue described below. > > Regards, > Pablo Ok will change the title "security: introduce security API and framework" > > ... > >> diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile new >> file mode 100644 index 0000000..af87bb2 >> --- /dev/null >> +++ b/lib/librte_security/Makefile > > ... > >> + >> +# library name >> +LIB = librte_security.a >> + >> +# library version >> +LIBABIVER := 1 >> + >> +# build flags >> +CFLAGS += -O3 >> +CFLAGS += $(WERROR_FLAGS) > > There is a compilation issue when the building as shared library, because LDLIBS have not been set. > > You need to add the following: > > +LDLIBS += -lrte_eal -lrte_mempool > > > Thanks for pointing this out. I think it got broken due to some latest patches merged. Will correct this in v6. Thanks, Akhil