From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Dharmik Thakkar <dharmik.thakkar@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>, Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 3/4] test/lpm: remove error checking in rcu qsbr perf
Date: Wed, 4 Nov 2020 19:35:18 +0000 [thread overview]
Message-ID: <639396e2-7682-5bb4-a6ef-469673fb5e35@intel.com> (raw)
In-Reply-To: <20201104185858.18397-4-dharmik.thakkar@arm.com>
On 04/11/2020 18:58, Dharmik Thakkar wrote:
> Remove redundant error checking for reader threads
> since they never return error.
>
> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
> Cc: honnappa.nagarahalli@arm.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> app/test/test_lpm_perf.c | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
> index 873ecf511c97..c8e70ec89ff5 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -556,11 +556,10 @@ test_lpm_rcu_perf_multi_writer(void)
> __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED)
> / TOTAL_WRITES);
>
> - /* Wait and check return value from reader threads */
> writer_done = 1;
> + /* Wait until all readers have exited */
> for (i = 2; i < num_cores; i++)
> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> - goto error;
> + rte_eal_wait_lcore(enabled_core_ids[i]);
>
> rte_lpm_free(lpm);
> rte_free(rv);
> @@ -605,10 +604,9 @@ test_lpm_rcu_perf_multi_writer(void)
> / TOTAL_WRITES);
>
> writer_done = 1;
> - /* Wait and check return value from reader threads */
> + /* Wait until all readers have exited */
> for (i = 2; i < num_cores; i++)
> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> - goto error;
> + rte_eal_wait_lcore(enabled_core_ids[i]);
>
> rte_lpm_free(lpm);
>
> @@ -712,10 +710,9 @@ test_lpm_rcu_perf(void)
> (double)total_cycles / TOTAL_WRITES);
>
> writer_done = 1;
> - /* Wait and check return value from reader threads */
> + /* Wait until all readers have exited */
> for (i = 0; i < num_cores; i++)
> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> - goto error;
> + rte_eal_wait_lcore(enabled_core_ids[i]);
>
> rte_lpm_free(lpm);
> rte_free(rv);
> @@ -771,11 +768,9 @@ test_lpm_rcu_perf(void)
> (double)total_cycles / TOTAL_WRITES);
>
> writer_done = 1;
> - /* Wait and check return value from reader threads */
> + /* Wait until all readers have exited */
> for (i = 0; i < num_cores; i++)
> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> - printf("Warning: lcore %u not finished.\n",
> - enabled_core_ids[i]);
> + rte_eal_wait_lcore(enabled_core_ids[i]);
>
> rte_lpm_free(lpm);
>
>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
--
Regards,
Vladimir
next prev parent reply other threads:[~2020-11-04 19:35 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 15:36 [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation " Dharmik Thakkar
2020-10-29 15:36 ` [dpdk-dev] [PATCH 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-10-29 15:36 ` [dpdk-dev] [PATCH 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-10-29 15:36 ` [dpdk-dev] [PATCH 4/4] test/lpm: avoid code duplication " Dharmik Thakkar
2020-11-02 17:17 ` Medvedkin, Vladimir
2020-11-02 22:11 ` Dharmik Thakkar
2020-11-02 10:08 ` [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation " David Marchand
2020-11-02 15:11 ` Bruce Richardson
2020-11-02 16:58 ` Dharmik Thakkar
2020-11-02 17:21 ` Medvedkin, Vladimir
2020-11-02 17:33 ` Bruce Richardson
2020-11-02 23:51 ` [dpdk-dev] [PATCH v2 0/4] test/lpm: fix rcu qsbr perf test Dharmik Thakkar
2020-11-02 23:52 ` [dpdk-dev] [PATCH v2 1/4] test/lpm: fix cycle calculation in rcu qsbr perf Dharmik Thakkar
2020-11-03 1:30 ` Honnappa Nagarahalli
2020-11-02 23:52 ` [dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 1:28 ` Honnappa Nagarahalli
2020-11-03 4:42 ` Dharmik Thakkar
2020-11-02 23:52 ` [dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-03 1:21 ` Honnappa Nagarahalli
2020-11-03 4:56 ` Dharmik Thakkar
2020-11-02 23:52 ` [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication " Dharmik Thakkar
2020-11-03 4:21 ` Honnappa Nagarahalli
2020-11-03 4:33 ` Dharmik Thakkar
2020-11-03 5:32 ` Honnappa Nagarahalli
2020-11-03 14:03 ` Dharmik Thakkar
2020-11-03 14:51 ` Honnappa Nagarahalli
2020-11-03 18:01 ` Medvedkin, Vladimir
2020-11-03 5:12 ` [dpdk-dev] [PATCH v3 0/4] test/lpm: fix rcu qsbr perf test Dharmik Thakkar
2020-11-03 5:12 ` [dpdk-dev] [PATCH v3 1/4] test/lpm: fix cycle calculation in rcu qsbr perf Dharmik Thakkar
2020-11-03 5:12 ` [dpdk-dev] [PATCH v3 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 5:21 ` Honnappa Nagarahalli
2020-11-03 5:12 ` [dpdk-dev] [PATCH v3 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-03 5:22 ` Honnappa Nagarahalli
2020-11-03 5:12 ` [dpdk-dev] [PATCH v3 4/4] test/lpm: avoid code duplication " Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-dev] [PATCH v4 0/4] test/lpm: fix rcu qsbr perf test Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-dev] [PATCH v4 1/4] test/lpm: fix cycle calculation in rcu qsbr perf Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-dev] [PATCH v4 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-dev] [PATCH v4 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-dev] [PATCH v4 4/4] test/lpm: avoid code duplication " Dharmik Thakkar
2020-11-03 22:35 ` Honnappa Nagarahalli
2020-11-04 15:46 ` Medvedkin, Vladimir
2020-11-04 16:49 ` Dharmik Thakkar
2020-11-04 18:58 ` [dpdk-dev] [PATCH v5 0/4] test/lpm: fix rcu qsbr perf test Dharmik Thakkar
2020-11-04 18:58 ` [dpdk-dev] [PATCH v5 1/4] test/lpm: fix cycle calculation in rcu qsbr perf Dharmik Thakkar
2020-11-04 19:34 ` Medvedkin, Vladimir
2020-11-04 18:58 ` [dpdk-dev] [PATCH v5 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-04 19:35 ` Medvedkin, Vladimir
2020-11-04 18:58 ` [dpdk-dev] [PATCH v5 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-04 19:35 ` Medvedkin, Vladimir [this message]
2020-11-04 18:58 ` [dpdk-dev] [PATCH v5 4/4] test/lpm: avoid code duplication " Dharmik Thakkar
2020-11-04 19:35 ` Medvedkin, Vladimir
2020-11-05 15:58 ` [dpdk-dev] [PATCH v5 0/4] test/lpm: fix rcu qsbr perf test David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639396e2-7682-5bb4-a6ef-469673fb5e35@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).