From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 783575A35 for ; Wed, 1 Apr 2015 08:10:46 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 31 Mar 2015 23:10:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="707143101" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga002.jf.intel.com with ESMTP; 31 Mar 2015 23:10:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 1 Apr 2015 14:10:43 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.24]) with mapi id 14.03.0224.002; Wed, 1 Apr 2015 14:10:42 +0800 From: "Zhang, XiaonanX" To: "Zhang, Helin" , "Liang, Cunming" , "Cao, Waterman" , "dev@dpdk.org" Thread-Topic: [PATCH] i40e: fix no effect wait_to_complete on link_get Thread-Index: AQHQbCRHpZCXAQXCgUWiXZ0rREFBnp03dKsAgAA0a0A= Date: Wed, 1 Apr 2015 06:10:42 +0000 Message-ID: <63FB47D6C0357E428AA804B2C89068BA012D58D6@SHSMSX104.ccr.corp.intel.com> References: <1427855614-8654-1-git-send-email-cunming.liang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-hashedpuzzle: APfD AySc BfXT Dl+O EZgP E3WY HJh1 HLfu IIJu JARJ JI6a JKiL Jbz9 JpXc K3Tz K5wf; 1; ZABlAHYAQABkAHAAZABrAC4AbwByAGcA; Sosha1_v1; 7; {FF53664E-BF2A-435A-9D4E-E755F9926834}; eABpAGEAbwBuAGEAbgB4AC4AegBoAGEAbgBnAEAAaQBuAHQAZQBsAC4AYwBvAG0A; Wed, 01 Apr 2015 06:17:32 GMT; UgBFADoAIABbAFAAQQBUAEMASABdACAAaQA0ADAAZQA6ACAAZgBpAHgAIABuAG8AIABlAGYAZgBlAGMAdAAgAHcAYQBpAHQAXwB0AG8AXwBjAG8AbQBwAGwAZQB0AGUAIABvAG4AIABsAGkAbgBrAF8AZwBlAHQA x-cr-puzzleid: {FF53664E-BF2A-435A-9D4E-E755F9926834} x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 06:10:47 -0000 =20 Tested-by: Xiaonan zhang - OS: Fedora21 3.19.1-201.fc21.x86_64 - GCC: gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Controller X7= 10 for 10GbE SFP+ [8086:1572] (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Total 1 cases, 1 passed, 0 failed - Test case: Used Qos example to verified=20 ------------------------------------- =20 Traffic shaping for subport. Check that the subport rate is enforced. =20 Set the subport output rate to x% of line rate (x =3D 10 .. 100). Set the s= ubport TC limits high (100% line rate each), so they do not constitute limi= tations. Input traffic is 100% line rate. =20 Different tb period and tb credits, therefore different output rate, are tr= ied: 25%, 50%, 75%, 90% and 100% the lineal rate. (The output for subport i= s Tb credits per period / Tb period.) The traffic is injected change subport value random. =20 Other parameters are same before tests and they don't change here. Cmdline: ./examples/qos_sched/build/qos_sched -c 0xe -n 4 -- --pfc "0,1,= 2,3,3" --cfg "/root/profile_sched_pipe_1.cfg" =20 The result is this table: =20 =20 +-----------------------+----------------------+ | Subport output rate | Subport output rate | | (% line rate) | (Mpps) | +-----------+-----------+----------+-----------+ | Expected | Actual | Expected | Actual | +-----------+-----------+----------+-----------+ =20 Signed-off-by: Xiaonan Zhang -----Original Message----- From: Zhang, Helin=20 Sent: Wednesday, April 01, 2015 10:50 AM To: Liang, Cunming; dev@dpdk.org Cc: Zhang, XiaonanX; Dumitrescu, Cristian Subject: RE: [PATCH] i40e: fix no effect wait_to_complete on link_get > -----Original Message----- > From: Liang, Cunming > Sent: Wednesday, April 1, 2015 10:34 AM > To: dev@dpdk.org > Cc: Zhang, Helin; Zhang, XiaonanX; Dumitrescu, Cristian; Liang, Cunming > Subject: [PATCH] i40e: fix no effect wait_to_complete on link_get >=20 > API *rte_eth_link_get* expect to call a wait to complete link_update. > That's the difference between *rte_eth_link_get_nowait*. > The patch fixes the issue that i40e link_update ignores the wait_to_compl= ete > flag. > The issue impacts those applications calling rte_eth_link_get to get wron= g > intermediate link status. >=20 > Signed-off-by: Cunming Liang Acked-by: Helin Zhang > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-)