From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 342B67DF8 for ; Thu, 2 Apr 2015 03:52:11 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 01 Apr 2015 18:52:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,507,1422950400"; d="scan'208";a="674094810" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2015 18:52:09 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 2 Apr 2015 09:52:04 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.111]) with mapi id 14.03.0224.002; Thu, 2 Apr 2015 09:52:02 +0800 From: "Zhang, XiaonanX" To: Thomas Monjalon , "Cao, Waterman" Thread-Topic: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get Thread-Index: AQHQbCRHpZCXAQXCgUWiXZ0rREFBnp03dKsAgAA0a0CAAGMhgIAA52Ag Date: Thu, 2 Apr 2015 01:52:03 +0000 Message-ID: <63FB47D6C0357E428AA804B2C89068BA012D5C8F@SHSMSX104.ccr.corp.intel.com> References: <1427855614-8654-1-git-send-email-cunming.liang@intel.com> <63FB47D6C0357E428AA804B2C89068BA012D58D6@SHSMSX104.ccr.corp.intel.com> <32480824.oD8BQeRvMH@xps13> In-Reply-To: <32480824.oD8BQeRvMH@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 01:52:11 -0000 Hi Thomas, First and foremost, We found this problem with using Qos example on Fedor= a21 platform, there are our reproduce test steps as follows. We used this example found FVL 4*10G NIC link status caused to our Qos ex= ample could not boot normally in our dpdk2.0 Release Cycle; In addition, it is performance case about our FVL 4 * 10G NIC, as you kno= w, our performance result currently should not be public; And also that's why our expectation performance data are empty. In a nutshell, We have verified this patch and confirmed the Qos example = could run and get performance data after we applied this patch to our code. Thanks. Best Regards, Xiaonan =20 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Thursday, April 02, 2015 3:52 AM To: Zhang, XiaonanX; Cao, Waterman Cc: dev@dpdk.org; Zhang, Helin; Liang, Cunming Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on lin= k_get Hi, 2015-04-01 06:10, Zhang, XiaonanX: >=20 > Tested-by: Xiaonan zhang >=20 > - OS: Fedora21 3.19.1-201.fc21.x86_64 > - GCC: gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) > - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz > - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Controller = X710 for 10GbE SFP+ [8086:1572] (rev 01) > - Default x86_64-native-linuxapp-gcc configuration > - Total 1 cases, 1 passed, 0 failed >=20 > - Test case: Used Qos example to verified=20 > ------------------------------------- What is the relation between link status timeout and qos_sched? > Traffic shaping for subport. Check that the subport rate is enforced. > =20 > Set the subport output rate to x% of line rate (x =3D 10 .. 100). Set the= subport TC limits high (100% line rate each), so they do not constitute li= mitations. Input traffic is 100% line rate. > =20 > Different tb period and tb credits, therefore different output rate, are = tried: 25%, 50%, 75%, 90% and 100% the lineal rate. (The output for subport= is Tb credits per period / Tb period.) > The traffic is injected change subport value random. > =20 > Other parameters are same before tests and they don't change here. >=20 > Cmdline: ./examples/qos_sched/build/qos_sched -c 0xe -n 4 -- --pfc "0,= 1,2,3,3" --cfg "/root/profile_sched_pipe_1.cfg" > =20 > The result is this table: > =20 > =20 > +-----------------------+----------------------+ > | Subport output rate | Subport output rate | > | (% line rate) | (Mpps) | > +-----------+-----------+----------+-----------+ > | Expected | Actual | Expected | Actual | > +-----------+-----------+----------+-----------+ This table is empty. >=20 > Signed-off-by: Xiaonan Zhang It seems that this test report is not relevant. It will be ignored in the commit message. Sorry