From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 60A2DA0548;
	Sun, 21 Feb 2021 16:58:44 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F38F322A297;
	Sun, 21 Feb 2021 16:58:43 +0100 (CET)
Received: from out0-135.mail.aliyun.com (out0-135.mail.aliyun.com
 [140.205.0.135])
 by mails.dpdk.org (Postfix) with ESMTP id D60DF22A293
 for <dev@dpdk.org>; Sun, 21 Feb 2021 16:58:41 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=alibaba-inc.com; s=default;
 t=1613923119; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type;
 bh=tHJRd9uy0Qf3DTBMICw1ahxQe2ntWWtc3a1I66KUPtU=;
 b=M8GXGrr6YLNjsi3UtUM0bI1KGRi07pvuZxgBDICgfn/wo0N/fYFghgZ5MoHBR6f+xLO/ZS9eK96ZSR2yVTvMpyo9Q1NEMYNfeI+yXgNoTvcRm1xNcxoUpjcYUHznIvu1bLjvt4ySk9LG1QHlDVh4bPpiKaufMl8c6eCWH9s5j80=
X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R601e4; CH=green; DM=||false|;
 DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018047199;
 MF=huawei.xhw@alibaba-inc.com; NM=1; PH=DS; RN=8; SR=0;
 TI=SMTPD_---.JbG0akL_1613923115; 
Received: from 30.15.222.210(mailfrom:huawei.xhw@alibaba-inc.com
 fp:SMTPD_---.JbG0akL_1613923115) by smtp.aliyun-inc.com(127.0.0.1);
 Sun, 21 Feb 2021 23:58:36 +0800
To: David Marchand <david.marchand@redhat.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, dev <dev@dpdk.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>, xuemingl@nvidia.com,
 Gaetan Rivet <grive@u256.net>, "Xia, Chenbo" <chenbo.xia@intel.com>
References: <1611890309-99135-1-git-send-email-huawei.xhw@alibaba-inc.com>
 <1611890309-99135-2-git-send-email-huawei.xhw@alibaba-inc.com>
 <CAJFAV8x6guxYMioFDCTaQWYPF0ovcUFTbKwbJryKiQ-Tpm8L7w@mail.gmail.com>
From: "=?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?="
 <huawei.xhw@alibaba-inc.com>
Message-ID: <63a70249-df55-806b-7ee8-6f3910881dd6@alibaba-inc.com>
Date: Sun, 21 Feb 2021 23:58:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8x6guxYMioFDCTaQWYPF0ovcUFTbKwbJryKiQ-Tpm8L7w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry
 to get PIO address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 2021/2/18 17:33, David Marchand wrote:
> On Fri, Jan 29, 2021 at 4:19 AM 谢华伟(此时此刻） <huawei.xhw@alibaba-inc.com> wrote:
>> From: "huawei.xhw" <huawei.xhw@alibaba-inc.com>
>>
>> Currently virtio PMD asssumes legacy device uses PIO bar.
>> There are three ways to get PIO(PortIO) address for virtio legacy device.
>>      under igb_uio, get pio address from uio/uio# sysfs attribute
>>      under uio_pci_generic:
>>          for X86, get PIO address from /proc/ioport
>>          for other ARCH, get PIO address from standard PCI sysfs attribute
>>
>> Actually, igb_uio sysfs attribute exports exactly the same thing as standard PCI sysfs, i.e,
>>      pci_dev->resource[]
>>
>> This patch fixes these messy things, and uses standard PCI sysfs attribute.
> I can not find what is being fixed.
> Could you elaborate?

Maybe i wrongly use the word fix?  With this patch, different drivers 
use the same way to get IO address for virtio device.

Previously different driver get IO address with different method.

>