From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3D7CA09FF; Tue, 5 Jan 2021 17:27:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C99DB1608AF; Tue, 5 Jan 2021 17:27:09 +0100 (CET) Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by mails.dpdk.org (Postfix) with ESMTP id 1197E1608AE for ; Tue, 5 Jan 2021 17:27:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1609864029; x=1641400029; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=vPqaTRt+HItujMfGxnQXZq3skrRxYulA+BInBfgV2tQ=; b=srafHzkEA5vn4lxQMJuoCj2RRdXfu1/vIRxiSrLFUTUMnJMi/DRSw7nV v3Ed4b0xv7KUts3569Bp5vzJo1TrNtBn9jV1q0iISHj6nzZVbVMvmPZdb VZn8pTulTDJDU/JtA55q9ipXe9qnn5/NL03jBHDImOPxJDdGL/m3azWcz o=; X-IronPort-AV: E=Sophos;i="5.78,477,1599523200"; d="scan'208";a="109671580" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 05 Jan 2021 16:27:07 +0000 Received: from EX13MTAUWC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (Postfix) with ESMTPS id C503DA215B; Tue, 5 Jan 2021 16:27:05 +0000 (UTC) Received: from EX13D12UWC002.ant.amazon.com (10.43.162.253) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 Jan 2021 16:27:01 +0000 Received: from [10.95.184.140] (10.43.160.66) by EX13D12UWC002.ant.amazon.com (10.43.162.253) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 Jan 2021 16:27:00 +0000 To: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Stephen Hemminger , Ferruh Yigit CC: References: <20201203135954.1127-1-prekageo@amazon.com> <20201205054238.12469-1-prekageo@amazon.com> From: George Prekas Message-ID: <63bd9338-e51e-3b42-cca4-0671ce68488f@amazon.com> Date: Tue, 5 Jan 2021 10:26:59 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201205054238.12469-1-prekageo@amazon.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.43.160.66] X-ClientProxiedBy: EX13D08UWC004.ant.amazon.com (10.43.162.90) To EX13D12UWC002.ant.amazon.com (10.43.162.253) Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/4/2020 11:42 PM, George Prekas wrote: > Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c > and the calculated IP checksum is wrong on GCC 9 and GCC 10. > > Signed-off-by: George Prekas > --- > v2: > * Instead of a compiler barrier, use a compiler flag. > --- > app/test-pmd/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build > index 7e9c7bdd6..5d24e807f 100644 > --- a/app/test-pmd/meson.build > +++ b/app/test-pmd/meson.build > @@ -4,6 +4,7 @@ > # override default name to drop the hyphen > name = 'testpmd' > cflags += '-Wno-deprecated-declarations' > +cflags += '-fno-strict-aliasing' > sources = files('5tswap.c', > 'cmdline.c', > 'cmdline_flow.c', Happy New Year! Any updates on this? Thanks, George