DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Roy Shterman <roy.shterman@vastdata.com>
Cc: dev@dpdk.org, yuval@vastdata.com, aviv.bendavid@vastdata.com
Subject: Re: [dpdk-dev] [PATCH] mem: fix free segment when using huge-unlink option
Date: Thu, 1 Apr 2021 12:07:23 +0100
Message-ID: <63d59764-3a86-6b7d-97c3-28a8d1a6eebb@intel.com> (raw)
In-Reply-To: <20210222104131.11979-1-roy.shterman@vastdata.com>

On 22-Feb-21 10:41 AM, Roy Shterman wrote:
> When using huge_unlink we unlink the segment right
> after allocation. Although we unlink the file we keep
> the fd in fd_list so file still exist just the path deleted.
> When freeing the hugepage we need to close the fd and assign
> it with (-1) in fd_list for the page to be released.
> 
> The current flow fails rte_malloc in the following flow when working
> with --huge-unlink option:
> 1. alloc_seg() for segment A -
>      We allocate segment, unlink the path to the segment
>      and keep the file descriptor in fd_list.
> 2. free_seg() for segment A -
>      We clear the segment metadata and return - without closing fd
>      or assigning (-1) in fd list.
> 3. alloc_seg() for segment A again -
>      We find segment A as available, try to allocate it,
>      find the old fd in fd_list try to unlink it
>      as part of alloc_seg() but failed because path doesn't exist.
> 
> The impact of such error is falsly failing rte_malloc()
> although we have hugepages available.
> 
> Fixes: d435aad37da7 ("mem: support --huge-unlink mode")
> 
> Signed-off-by: Roy Shterman <roy.shterman@vastdata.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2021-04-01 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 10:41 Roy Shterman
2021-02-22 15:53 ` Burakov, Anatoly
2021-02-28 13:21   ` Roy Shterman
2021-03-01 10:44     ` Burakov, Anatoly
2021-03-25 13:34       ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-04-01 11:07 ` Burakov, Anatoly [this message]
2021-04-07  9:09   ` [dpdk-dev] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d59764-3a86-6b7d-97c3-28a8d1a6eebb@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=aviv.bendavid@vastdata.com \
    --cc=dev@dpdk.org \
    --cc=roy.shterman@vastdata.com \
    --cc=yuval@vastdata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git