DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>,
	"yang_y_yi@163.com" <yang_y_yi@163.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	"yangyi01@inspur.com" <yangyi01@inspur.com>
Subject: Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso
Date: Thu, 17 Sep 2020 16:01:50 +0100
Message-ID: <63d597d6-da22-334a-04c6-22a6908df51b@intel.com> (raw)
In-Reply-To: <b04cd31f50bc4e23a8fc4880130515ca@intel.com>

On 9/17/2020 3:16 AM, Hu, Jiayu wrote:

>> -----Original Message-----
>> From: yang_y_yi@163.com <yang_y_yi@163.com>
>> Sent: Thursday, September 17, 2020 10:13 AM
>> To: dev@dpdk.org
>> Cc: Hu, Jiayu <jiayu.hu@intel.com>; thomas@monjalon.net;
>> yangyi01@inspur.com; yang_y_yi@163.com
>> Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso
>> From: Yi Yang <yangyi01@inspur.com>
>> Fragment offset of IPv4 header is measured in units of
>> 8 bytes. Fragment offset of UDP fragments will be wrong
>> after GSO if pyld_unit_size isn't multiple of 8. Say
>> pyld_unit_size is 1500, fragment offset of the second
>> UDP fragment will be 187 (i.e. 1500 / 8), which means 1496,
>> and it will result in 4-byte data loss (1500 - 1496 = 4).
>> So UDP GRO will reassemble out a wrong packet.
>> Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation")
>> Signed-off-by: Yi Yang <yangyi01@inspur.com>
 > Acked-by: Jiayu Hu <jiayu.hu@intel.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2020-09-17 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  2:12 yang_y_yi
2020-09-17  2:16 ` Hu, Jiayu
2020-09-17 15:01   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d597d6-da22-334a-04c6-22a6908df51b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yang_y_yi@163.com \
    --cc=yangyi01@inspur.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git