From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0DFBA04C0; Thu, 17 Sep 2020 17:02:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 982FD1D675; Thu, 17 Sep 2020 17:02:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2430E1D673 for ; Thu, 17 Sep 2020 17:02:00 +0200 (CEST) IronPort-SDR: fxiVEF+HKmk8ym4CWfSSFm/XsJyHXJYVZ0oxa7Tb8yiRwHqgvx9D0nbj4bPq1zlsbWL4lJHYKl h4/jG+44lCKg== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="157101828" X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="157101828" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 08:01:57 -0700 IronPort-SDR: ISd3dUSJfqwT8wVrohOOpzqf8SCOMXwaivL42+1hzzuzQtATneQEc/1XRrMlmNciEvAvaVg3XV 0Sdz23HOk+jQ== X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="483780230" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.228.143]) ([10.213.228.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 08:01:54 -0700 To: "Hu, Jiayu" , "yang_y_yi@163.com" , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "yangyi01@inspur.com" References: <20200917021249.191088-1-yang_y_yi@163.com> From: Ferruh Yigit Message-ID: <63d597d6-da22-334a-04c6-22a6908df51b@intel.com> Date: Thu, 17 Sep 2020 16:01:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2020 3:16 AM, Hu, Jiayu wrote: >> -----Original Message----- >> From: yang_y_yi@163.com >> Sent: Thursday, September 17, 2020 10:13 AM >> To: dev@dpdk.org >> Cc: Hu, Jiayu ; thomas@monjalon.net; >> yangyi01@inspur.com; yang_y_yi@163.com >> Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso >> >> From: Yi Yang >> >> Fragment offset of IPv4 header is measured in units of >> 8 bytes. Fragment offset of UDP fragments will be wrong >> after GSO if pyld_unit_size isn't multiple of 8. Say >> pyld_unit_size is 1500, fragment offset of the second >> UDP fragment will be 187 (i.e. 1500 / 8), which means 1496, >> and it will result in 4-byte data loss (1500 - 1496 = 4). >> So UDP GRO will reassemble out a wrong packet. >> >> Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation") >> >> Signed-off-by: Yi Yang > > Acked-by: Jiayu Hu > Applied to dpdk-next-net/main, thanks.