From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1616D28F3 for ; Tue, 1 May 2018 16:12:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AB21120B60; Tue, 1 May 2018 10:12:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 01 May 2018 10:12:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=p8X4noej9P88l6Gztc9wUH543+ BJmRtFRYvoWq/sNy8=; b=QETLilPicC7kMfEvfdKCG0GsmodrYS2uKOJwhVBwrG 9Tf1x+pi16oVwY81IFESK1Z1cu7AOSTl9LzdznGCXsqov5cODFUQGmfnAYvHRB0X 3B69DOiqCpXvNdyg0OP8XWOfwvaTSTbBOZUMGEzGKMTC+JdvK/1RFwdnThSuRs1q 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=p8X4no ej9P88l6Gztc9wUH543+BJmRtFRYvoWq/sNy8=; b=XXqkZBJxInm3Ts9q0IopfJ 7zK8g4FzfEyoat0JkOYQRQr4RkUbp2m1IUkHheWfNuukmWi8vR+aN4mBUeEeRGue FPUcny07gdc6f24ihNw4+7mvFpferHjbyefhTpnNYFtiy0MUgI6MAdHI/WHCvP6D 2PZrX65sRwHtCC3d0GwVscH90BS9KhvhQhR1/05pwOuknmswOiANhDxclBlWhRb/ YtfIObNjA/z0LCVwr3uAmVvrhEXVGIRdSbjf5BRPUtmUh/wkuld5Ep/UIDPeEjPi J7GPlNLiVJGXsYJjFFF3MpAkkWuOHLoTCT2wZAoVW26/2WBV9DAobVr2fQL7ImCQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 154F0E444A; Tue, 1 May 2018 10:12:15 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: xuemingl@mellanox.com, dev@dpdk.org Date: Tue, 01 May 2018 16:12:14 +0200 Message-ID: <6407794.aElEmAcKUa@xps> In-Reply-To: <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com> References: <20180501133343.125260-1-ferruh.yigit@intel.com> <14979049.G4nOY0bchV@xps> <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 14:12:17 -0000 01/05/2018 16:08, Ferruh Yigit: > On 5/1/2018 3:01 PM, Thomas Monjalon wrote: > > 01/05/2018 15:33, Ferruh Yigit: > >> Many sample applications fail because of > >> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure() > > > > We need to define the API behaviour in doxygen. > > > >> The sample applications need to be fixed/updated before returning error > >> on rte_eth_dev_configure() > >> > >> This patch keeps the error log but removes returning error. > > > > If the doc is updated in 18.05, we can have a deprecation notice > > to insert the error return in 18.08. > > +1 to add a deprecation notice for this release and do the error return on 18.08. > > Is the doc update you mentioned doxygen update? Yes, doxygen update. > Who can do doc update and deprecation notice patches for this release? Either you Ferruh, or Xueming and me together. What do you prefer? > >> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") > >> Cc: xuemingl@mellanox.com > >> > >> Signed-off-by: Ferruh Yigit