From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Kantecki, Tomasz" <tomasz.kantecki@intel.com>
Cc: dev@dpdk.org, "Cornu, Marcel D" <marcel.d.cornu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage
Date: Fri, 11 Mar 2016 17:38:41 +0100 [thread overview]
Message-ID: <6409326.IYvTj83Jur@xps13> (raw)
In-Reply-To: <E79CF84CF47B0B42B66F4F5835125F9C817C5EC6@IRSMSX101.ger.corp.intel.com>
2016-03-11 16:34, Kantecki, Tomasz:
>
> > > > > The skeleton aims to show a minimal piece of code (but bigger than
> > > > > hello world).
> > > > > For any other usage, I think the "l2fwd" name is more appropriate.
> > > > >
> > > > > > +DIRS-y += skeleton-cat
> > > > >
> > > >
> > > > We have used skeleton app as basis for this sample code. It is just to keep
> > it as simple as possible.
> > > > Wouldn't it be confusing if we use "l2fwd" name for skeleton app
> > functionality?
> > >
> > > I'm not sure.
> > > We need more opinions.
> >
> > Skeleton app does do a form of l2 forwarding, just without editing the mac
> > addresses.
> > I don't think having "skeleton" in the name of derived apps is a good thing, so
> > I would vote for an l2fwd-based name.
>
> OK I understand. We'll prepare patch v5 with changed application name.
> Is Mon morning OK for the v5 patch submission?
The deadline was yesterday.
But for a new example, it can be integrated later, even in rc2
if rc1 is closed Monday (far from probable).
next prev parent reply other threads:[~2016-03-11 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 13:26 [dpdk-dev] [PATCH] " Wojciech Andralojc
2016-02-26 15:07 ` [dpdk-dev] [PATCH v2] " Wojciech Andralojc
2016-03-07 14:34 ` Van Haaren, Harry
2016-03-07 16:54 ` [dpdk-dev] [PATCH v3] " Wojciech Andralojc
2016-03-07 17:19 ` Van Haaren, Harry
2016-03-11 13:50 ` Thomas Monjalon
2016-03-11 15:54 ` Kantecki, Tomasz
2016-03-11 16:03 ` Thomas Monjalon
2016-03-11 16:27 ` Bruce Richardson
2016-03-11 16:34 ` Kantecki, Tomasz
2016-03-11 16:38 ` Thomas Monjalon [this message]
2016-03-11 16:24 ` [dpdk-dev] [PATCH v4] " Wojciech Andralojc
2016-03-14 13:46 ` [dpdk-dev] [PATCH v5] examples/l2fwd-cat: " Wojciech Andralojc
2016-03-21 22:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6409326.IYvTj83Jur@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=marcel.d.cornu@intel.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).