From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B6B045A2E; Wed, 25 Sep 2024 23:35:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E144025D; Wed, 25 Sep 2024 23:35:11 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2075.outbound.protection.outlook.com [40.107.101.75]) by mails.dpdk.org (Postfix) with ESMTP id C337C400EF for ; Wed, 25 Sep 2024 23:35:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ppOKK7jnPTay7CqWFdckE3ZuTngfa3asQlCAUJPv9YtZBrvHuPpizzaMti8d/FdKyji8oh2wWIxwV48YW+wWkI0zt1WzP2EGhMQ8IRo85beOHSElqQiQmTcX7b3sqGC9D8yIqByJBm9pzLQ1kU5YjX/80wfQqVXc1IZ80wFArqtNfW6MLIHLCC+GKuR+HUjuzAlcGVEW6aJRisbuPaccPRQONcBB1lHjMzKiakqEb5MYTb/WP+wpxWYgsrzGU31DeTLwtk08InqzDxZkvMEDy59GZ2VN4z2CzglgEeIlz6VzpWeO5r39HBzFg9XSiiIo5m4lFdagILRjxrEAV7RP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gVmVHwlaBHai6gDiOajcidkFrFTLVtrceNa+nZkzGd0=; b=hZR7Id2i13yH4nxGugUQnvfQndUuKeenfZHY/w8Y++GUBZYot/ZcPb+tYDPFZrHwinsCOQ9btsn/5wtAoVlwm+m0IzOh912/mfc7mm88yIDaOIUzdrXM1yfNPO/t+M1AzkPxMSIWxXs5kCO/13I5NpE43DxwgQuc488QREqhEHAVMpAryO9rwfGUXgnCHj71qovZMYj0USStETCuAbonCCBwP3noVwARnCG1z6Y2BFZd5VDqcRUFbdat5OF8zIJCKnB3FDryI/rPL1m6f9k0bLkeb+oMmm4JuTtMfzbcI2XvPKa0rbySLY0NiF/gXrTfFZup1BuKjR/NefnEZf9PSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gVmVHwlaBHai6gDiOajcidkFrFTLVtrceNa+nZkzGd0=; b=UB8UBLIYW5tvlHRmTcIUoRyymHHKrkxuoNfCIY7eoKOuPco42Yh08vJMHh3b3gvYCTbeFHPx3/5JZ76Cu/67Bc08/AnJylYNUJoD2YBcb3dvhCaIZ4Dv1wUaZ/qsYfIndbFK+HnZhLoqfmT2Q5NtJS6do2Dc6SDYcJBnVkaFzYw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CYYPR12MB8854.namprd12.prod.outlook.com (2603:10b6:930:b8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.27; Wed, 25 Sep 2024 21:35:06 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Wed, 25 Sep 2024 21:35:06 +0000 Message-ID: <6429fb4d-ab9b-4509-a74d-1139b2471194@amd.com> Date: Wed, 25 Sep 2024 22:35:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support To: Damodharam Ammepalli Cc: dev@dpdk.org, ajit.khaparde@broadcom.com, huangdengdui@huawei.com, kalesh-anakkur.purayil@broadcom.com References: <20240904175151.47780-1-damodharam.ammepalli@broadcom.com> <20240904175151.47780-2-damodharam.ammepalli@broadcom.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0320.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::19) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CYYPR12MB8854:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e84c3c6-feb0-4287-c059-08dcdda9ec25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VnZUY05yd0RmT0RHcGp0aEVuV0tMS3QrbjZMQnJpRVFNaWcxdzJqa2d4d0RL?= =?utf-8?B?U1Z2ZnJ1bjRjS1V4NkhLbi9DUlZFbVV2cVEvVjlPOTkvL0hlV25Bci9lV01r?= =?utf-8?B?OTNNSmMwcVpYYzZ4Y1RzS3ZlVXo3NHZQZUpaenp4cGUwUnJXYW0wMXE3NWdB?= =?utf-8?B?MVRQWWI4S1QwRm5LRzNuajhDV1dYQ3luNXdDOEdnWWh1Wks1UU1QTkoxbVd6?= =?utf-8?B?L3hPc3dDcnhYQnJiUHlLQStFRDNWQVg1SHpZcGdRS2ZTb2FtOUNwTEZDMHR6?= =?utf-8?B?bW1nUG0xRGFmQVBUU05veVkzbU9NeWF3WVJ0MzN2NmU5QUNkQ2ZiNXN1Y1o2?= =?utf-8?B?Q2NyZHorMzFXWUtWT1NrSDJNeHY3MXlEODVKcnNtSHM0V2FieEVPUjRFOC9F?= =?utf-8?B?bERjRGR0dHppeDVyWHZSejM0cHAyUElNbnFXWTNseEs4YjNOM21oMG1RaG9j?= =?utf-8?B?Y1VLSXZRUXNvQzYzRUhpWDlBVlVKbjgwS1MvakVtWTllNTNyTm40Z1lONEpC?= =?utf-8?B?UzFHVGVjd05hOHcrcFczc0txNUlseWtjVWl2Ymhaa1BUK3lXN09NZ00yeFpX?= =?utf-8?B?WDcrb1R2c0JKdUVwMlY3SEd4UHF5dWhsSW5TYXV1Q0VEQUVnVDZVRHJPWXAz?= =?utf-8?B?OGdjaEJvazRZZUl0UmgwNk1nZmpPSzZVekZob25XeHlmZFVwOThyUDJybmkw?= =?utf-8?B?ZDNRR0VoUjNnUHdRd3dsaFhlQTBaZ1grTUF6TlNmREo2Rk8vQlhCMlFMcEV3?= =?utf-8?B?dC9VcTQxNkx6SlVsVTNpbDFSM1FTbzQyWk03SEtzMkZ6aWV5VklTTDEvSGhR?= =?utf-8?B?OE5GZHBXQm1qWGpBU0hlR3paVXFoVld4Qkw0REVRNUNtWDdFOTZOeXBST3Vx?= =?utf-8?B?azBRMkgxM3MvYXk2UVlVTFE3OFBHN2E1MjVBODlJdFJBOHc4WXgzSmt1Y0Zr?= =?utf-8?B?VWpONEN4dFRiMkVEYjdKZGQ1TXZTeThqU2txMFhxUDI3TDFWQzRPYWdkMjhr?= =?utf-8?B?S1JjYUZSbyt2N0JRS2lZSnBsZVZlbG1naHJrbDJQdmt1cXVwWDZPT2dIT3J4?= =?utf-8?B?d0J0L1h4blJLN1A5bmpPZ3RUNjVKR0o1WC9wVFE0dFpqUUQrZisrTWx2WW82?= =?utf-8?B?di9yQ0tOSnZVdVVlZ01KUzFzZkRHZDNvR1Z3d2dPV0MzL3pDNzd3dHRlL204?= =?utf-8?B?SWJDVDF4S21lKzBTYjJzYnZZeC9qdmdkLzNaWXowaXBoK1NQK3pjeU5yMkxN?= =?utf-8?B?OVBWMjc0bk9wWEY3Y2FNRFN3QkhJdUw1MERFS0pwZmM3OVRrR1FQMlNrVVQy?= =?utf-8?B?T3VMZ2ZFK2VKK1pYNFFRcldlZEtXdXlyRFNKdlltZzhYRFRGNDlGMjFOTy93?= =?utf-8?B?LzZlKzFXb0M4THU0ekRiTFgrOU44SDJpV0Nic1JDci9EMU1FMzZrMnd2M2lH?= =?utf-8?B?WXdLMHdVVVJURHFRNFh6NGRTdlBOa1JrR01mdmsyTTh5VFdKd3ZwOWVCMjRH?= =?utf-8?B?Mnp4Y2dlWUUrRExZSnhLT3BkTGZ1NTNXSGkrRHdZRkhZUUp0ODNRZmd3MmJ2?= =?utf-8?B?dE9MbkRiWk5WdDluUElyc2NTTXpQZU0wR2t1QktqKzk1em5UdlZHTUk1ZzVo?= =?utf-8?B?M1lBelU3Y3BuNmh2QUZzVyszWXNKaUxFL3pCMklOdUlPc1pMWDBVRXJuZm5I?= =?utf-8?B?SnlBOUxXYWpIN2d0Q20yVEFDVzVpSVNJSThUS1dEd2dvTEppN21xMEhvUHI0?= =?utf-8?B?dmZkcVIzY1hjN0lUUjIzRWtoSGxlWW1Mc2hhUlV1NllBcERVc0tVTEErZHhy?= =?utf-8?B?OEdZbE9GYS9FcnpBQnpvQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjFBMDFRNjVxOXpZeFp6REhyVE41SkR1VklhbEQ3TXJGbEdBS1U1M2ZPUHJP?= =?utf-8?B?YTdpcG1xZGhqeTRwZms2Nm9DMXlsQ3hKQnpTWVpnSzBEQlpMVnFmNC9LaHYr?= =?utf-8?B?bGE1L3FPaUFYYlJoVk5nQ2pvRmc5UlhqTnRCTmpubVNTU21xR1RlcTVNaXFu?= =?utf-8?B?Mkl2SHJvVWFZWldRbFM2T0N4aDF4aXBsVS82SGxhY0RNb1VobWxSMVh5RXB5?= =?utf-8?B?clhiWjRVekgxd0Q5aTNOYkNXeVBhYUhSWnJoY2VFRWhLU21nWGY0R3c3d0d4?= =?utf-8?B?WkR3dFh1YzlTUjB0OEtvbFBEVitpbnVCT0lIQXRub2svOW55cVdKRGdkYUpk?= =?utf-8?B?Ny8vZlgveGpoRkNheit2WlNVZUsrSGw3SXl1NlBIbkNNalpQd21Ma25qK2M4?= =?utf-8?B?S1RSK0UyT2tXenAvZWd6WW9ETDlRd0h3T3J3TzMyUkpFdUVBZGluS1NEWUtq?= =?utf-8?B?UWp6WHNWeGpIS1I0ZzhUcUQ5NXp6ZDd2MWFvbXZlTUFtTk9zZThYbHQxd3F2?= =?utf-8?B?MUNBVGVjMmR2MzV1a0FyYmlWNVNleklacTI3MmYvRVJ2aFFpY0kyclEvVkc1?= =?utf-8?B?VnpzTFIwcktVdUJVckxYYjBiNVdWdEhHdXJaY2swWXdDY0V5M2NUSXhsdjdy?= =?utf-8?B?SW5wUU85Um1RWDJucCtxZnpSOVZRQ2pLejhoK0xtMUwwNHFsSzBvZFQvS2gv?= =?utf-8?B?OHJ0QmFWaVYrQ0phM3J4bDJHWmJ1R0lzUlNPRFpPbElNT0dNRDNhV3JGb2wx?= =?utf-8?B?VWc5TlNGc1B2MnBOZW1tdGRWZ3JRVUNHcU1YcGRGUTBkclNMdjdlS2ZldnZB?= =?utf-8?B?N2F4UkN5ZjBlbENTSGoxUGNGRGRIeFI3enhEbXZaTXUwL1o0V2pncVBrVDZn?= =?utf-8?B?alUzRHJFRXQ5R29oMUJBK1lxeHBMS1lHdVBHWmRYTG1HVFlNQmp6ZnU3eit2?= =?utf-8?B?YTFWNkV2aU1sL0tjQVh4TzJObUNBQTl5cHpBdGhKWVExYzNrS2YvUGxIbkk3?= =?utf-8?B?VTlsQ3BYL2JrSUlXZmpJblU5OFlLMkZjYVhydUVMbTE3dmF6bGE0RVFJWk5F?= =?utf-8?B?Q3RnVTQ5VHlZNURhQXMzTVVad3VJVTIvTENPdUloM1pVR3FKek9IWjFFUk9v?= =?utf-8?B?N2txU21icisyUEVHM0d1dFdwdUJaamVsbVNpY0I3bW5NV2xyVXJTMVVlL3Vj?= =?utf-8?B?elpPdmFvc1VueXVYYlFXdXlUWS9oR3hQUEtMcW53cTgwSjhpTEo3aS9TdCt2?= =?utf-8?B?MWowTkpmTERZL01TMUJtWlM3K2xsTFJ1VlhZbjF3RThDZjZQOFY3TEZZMVo0?= =?utf-8?B?RHcvSXlFRGZoc3hxeEtSVnd5cHQvVklNb1Q5K3lBdVNNNUJUaU1SbngrSStu?= =?utf-8?B?RHY4UGhDc2hHRWJjN3pJU1Q5NHg4MHlpVUxqTHZrL3dGcUJpMFNGVldQMXB0?= =?utf-8?B?WXhsQ0xDdmw2U0Y0cStBd1VCQUFGSkJEMFZoVkZPUmR2NXNpaVh1NU9UaHg2?= =?utf-8?B?YVFYZy9EaEpKeG5WTDE1TFZVQzFkM3FzTFR6ajRZNkVzMUtLamtTUFNIK0d5?= =?utf-8?B?Z2hLS2F6N2J2NDl2TWNFMzR6b25OQnhOZCtnemlCV0VPYkkrckZaM0tEeDlT?= =?utf-8?B?TWIyMm03NVptWWtaVWVROGo0YTFiM0YvZ2djMXU2VWlKWHlWNHVndVM2SGpk?= =?utf-8?B?OFlWanRRdG8rMlc1cGxwMy9SYzlTSDRmVWswWWpNRGhrTmVJSHZiZm5Gay9E?= =?utf-8?B?Z2IxdncwVFNzcUk2NHg0TG05L0dtSGVLM1kwQzdNTWlkQXdTdGwxTi9xL0NB?= =?utf-8?B?S1JHWi9RcE9Hb09KWGF5OFBRbHRRbzZIdDBtZjloQWdBODVDMHB0RDJzWVhq?= =?utf-8?B?TElKQnRqVkdTc2I0K1cvTlhKZkoxWjlNTDFJTzNoVll0OURpR2Q3eEU4QnBj?= =?utf-8?B?VGJKczkrbGt5d0ZLRXVDVnFBOUFIdjBEZ2p5RE5sN3A0b0doQWVaTy85dC9t?= =?utf-8?B?Z2lkUER6NUtYSG5XYXFCUDZoQklwUUZRdlRCeHZuWmhEN1U4V2J3OWwvRTJ2?= =?utf-8?B?Z2FNM3NpNUE5a3hFTk80eXA5ZkdTZXB5RFpJZjBLSHV0UlJ3UzIzVlFxNnF3?= =?utf-8?Q?6F4yqXq8SfZD0QY3sH71RuQXb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e84c3c6-feb0-4287-c059-08dcdda9ec25 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2024 21:35:06.3327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VZtnrSTp7y6NKS6cophpufczwAqwTc1WlS+KkFlwO884KJZBBW3mzFar1e2ypOm6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8854 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/25/2024 4:00 PM, Damodharam Ammepalli wrote: > On Tue, Sep 24, 2024 at 3:59 PM Damodharam Ammepalli > wrote: >> >> On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: >>> >>> On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: >>>> Update the eth_dev_ops structure with new function vectors >>>> to get, get capabilities and set ethernet link speed lanes. >>>> Update the testpmd to provide required config and information >>>> display infrastructure. >>>> >>>> The supporting ethernet controller driver will register callbacks >>>> to avail link speed lanes config and get services. This lanes >>>> configuration is applicable only when the nic is forced to fixed >>>> speeds. In Autonegiation mode, the hardware automatically >>>> negotiates the number of lanes. >>>> >>>> These are the new commands. >>>> >>>> testpmd> show port 0 speed_lanes capabilities >>>> >>>> Supported speeds Valid lanes >>>> ----------------------------------- >>>> 10 Gbps 1 >>>> 25 Gbps 1 >>>> 40 Gbps 4 >>>> 50 Gbps 1 2 >>>> 100 Gbps 1 2 4 >>>> 200 Gbps 2 4 >>>> 400 Gbps 4 8 >>>> testpmd> >>>> >>>> testpmd> >>>> testpmd> port stop 0 >>>> testpmd> port config 0 speed_lanes 4 >>>> testpmd> port config 0 speed 200000 duplex full >>>> testpmd> port start 0 >>>> testpmd> >>>> testpmd> show port info 0 >>>> >>>> ********************* Infos for port 0 ********************* >>>> MAC address: 14:23:F2:C3:BA:D2 >>>> Device name: 0000:b1:00.0 >>>> Driver name: net_bnxt >>>> Firmware-version: 228.9.115.0 >>>> Connect to socket: 2 >>>> memory allocation on the socket: 2 >>>> Link status: up >>>> Link speed: 200 Gbps >>>> Active Lanes: 4 >>>> Link duplex: full-duplex >>>> Autoneg status: Off >>>> >>>> Signed-off-by: Damodharam Ammepalli >>>> --- >>>> app/test-pmd/cmdline.c | 248 ++++++++++++++++++++++++++++++++++++- >>>> app/test-pmd/config.c | 4 + >>>> lib/ethdev/ethdev_driver.h | 91 ++++++++++++++ >>>> lib/ethdev/rte_ethdev.c | 52 ++++++++ >>>> lib/ethdev/rte_ethdev.h | 95 ++++++++++++++ >>>> lib/ethdev/version.map | 5 + >>>> 6 files changed, 494 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>>> index b7759e38a8..643102032e 100644 >>>> --- a/app/test-pmd/cmdline.c >>>> +++ b/app/test-pmd/cmdline.c >>>> @@ -284,6 +284,9 @@ static void cmd_help_long_parsed(void *parsed_result, >>>> >>>> "dump_log_types\n" >>>> " Dumps the log level for all the dpdk modules\n\n" >>>> + >>>> + "show port (port_id) speed_lanes capabilities" >>>> + " Show speed lanes capabilities of a port.\n\n" >>>> ); >>>> } >>>> >>>> @@ -823,6 +826,9 @@ static void cmd_help_long_parsed(void *parsed_result, >>>> "port config (port_id) txq (queue_id) affinity (value)\n" >>>> " Map a Tx queue with an aggregated port " >>>> "of the DPDK port\n\n" >>>> + >>>> + "port config (port_id|all) speed_lanes (0|1|4|8)\n" >>>> >>> >>> This help string, and the implementation, implies there has to be fixed >>> lane values, like 1, 4, 8. Why not leave this part to the capability >>> reporting, and not limit (and worry) those values in the command, so >>> from command's perspective it can be only . >>> >> >> ok, will update the help string to >> >>>> + " Set number of lanes for all ports or port_id for a forced speed\n\n" >>>> ); >>>> } >>>> >>>> @@ -1560,6 +1566,244 @@ static cmdline_parse_inst_t cmd_config_speed_specific = { >>>> }, >>>> }; >>>> >>>> +static int >>>> +parse_speed_lanes_cfg(portid_t pid, uint32_t lanes) >>>> +{ >>>> + int ret; >>>> + >>>> + ret = rte_eth_speed_lanes_set(pid, lanes); >>>> >>> >>> As a sample application usage, I think it is better if it gets the >>> capability and verify that 'lanes' is withing the capability and later >>> set it, what do you think? >>> >>> <...> >> >> Makes sense, will try out and get back to you soon. >> > I guess a similar comment was discussed in the past, slipped my mind > to mention in my last response. > These are the reasons for this logic. > - same lane number can be supported by any speed (eg: 4 Lanes > supported in 100,200,400 etc) > so, which speed row should app check against, since the user has not > configured fixed speed yet. > If the link is already up in AN mode, this lane config doesn't have > any significance. > - one approach would be to validate lanes in > parse_and_check_speed_duplex(), but in this case, the app should > already have non-default lanes value. We also need to consider the > case, if the user wants default lanes. > - In the ethtool, the driver does the validation of the speed x lanes > combo. Tried to match similar behaviour. > > Let me know your thoughts. > Hi Damodharam, You are right, we can't verify the capability because of missing fixed link speed. This is the affect of separating speed and lane. Please scratch the ask, lets continue with the function as it is. >> >>>> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h> index >>> 548fada1c7..9444e0a836 100644 >>>> --- a/lib/ethdev/rte_ethdev.h >>>> +++ b/lib/ethdev/rte_ethdev.h >>>> @@ -357,6 +357,27 @@ struct rte_eth_link { >>>> #define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */ >>>> /**@}*/ >>>> >>>> +/** >>>> + * Constants used to indicate the possible link speed lanes of an ethdev port. >>>> + */ >>>> +#define RTE_ETH_SPEED_LANE_UNKNOWN 0 /**< speed lanes unsupported mode or default */ >>>> +#define RTE_ETH_SPEED_LANE_1 1 /**< Link speed lane 1 */ >>>> +#define RTE_ETH_SPEED_LANE_2 2 /**< Link speed lanes 2 */ >>>> +#define RTE_ETH_SPEED_LANE_4 4 /**< Link speed lanes 4 */ >>>> +#define RTE_ETH_SPEED_LANE_8 8 /**< Link speed lanes 8 */ >>>> + >>>> +/* Translate from link speed lanes to speed lanes capa */ >>>> +#define RTE_ETH_SPEED_LANES_TO_CAPA(x) RTE_BIT32(x) >>>> + >>>> +/* This macro indicates link speed lanes capa mask */ >>>> +#define RTE_ETH_SPEED_LANES_CAPA_MASK(x) RTE_BIT32(RTE_ETH_SPEED_ ## x) >>>> + >>>> >>> >>> I am not clear why we need these macros, why not use lane number as >>> unsigned integer, instead of macro (RTE_ETH_SPEED_LANE_2), it will be >>> more flexible. >>> >> >> ok, I can replace the macros with unsigned integers >> >>> Probably all we need is 'RTE_ETH_SPEED_LANES_TO_CAPA' one to use as >>> helper in drivers. >>> Again not sure about the ..CAPA_MASK one, does it actually produce a >>> mask value? >>> >>> >> once replacing the LANE_xx to unsigned integers, then I don't need x_CAPA_MASK. >> In the driver, I can call RTE_32(lane number) while populating the table. >> EG: >> >> { RTE_ETH_SPEED_NUM_100G, RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_1) | >> RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_2) | >> RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_4) }, >> will become >> >> { RTE_ETH_SPEED_NUM_100G, RTE_BIT32(1) | >> RTE_BIT32(2) | >> RTE_BIT32(4) }, >