From: David Christensen <drc@linux.vnet.ibm.com>
To: Piotr Kubaj <pkubaj@FreeBSD.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ppc64le: fix build without glibc and using Clang
Date: Tue, 18 May 2021 13:42:13 -0700 [thread overview]
Message-ID: <6435d3f6-c80b-d50e-bc11-70c8044d2b19@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210517004621.64357-1-pkubaj@FreeBSD.org>
On 5/16/21 5:46 PM, Piotr Kubaj wrote:
> __ppc_get_timebase() is only present when glibc is used.
>
> Signed-off-by: Piotr Kubaj <pkubaj@FreeBSD.org>
> ---
> lib/eal/ppc/include/rte_altivec.h | 3 +++
> lib/eal/ppc/include/rte_cycles.h | 12 ++++++++++++
> lib/eal/ppc/rte_cycles.c | 16 ++++++++++++++++
> 3 files changed, 31 insertions(+)
>
> diff --git a/lib/eal/ppc/include/rte_altivec.h b/lib/eal/ppc/include/rte_altivec.h
> index 1551a94544..3fcc819c11 100644
> --- a/lib/eal/ppc/include/rte_altivec.h
> +++ b/lib/eal/ppc/include/rte_altivec.h
> @@ -7,6 +7,9 @@
> #define _RTE_ALTIVEC_H_
>
> /* To include altivec.h, GCC version must be >= 4.8 */
> +#ifdef __clang__
> +#define vector __vector
> +#endif
> #include <altivec.h>
>
> /*
> diff --git a/lib/eal/ppc/include/rte_cycles.h b/lib/eal/ppc/include/rte_cycles.h
> index 5585f9273c..a8307ceaff 100644
> --- a/lib/eal/ppc/include/rte_cycles.h
> +++ b/lib/eal/ppc/include/rte_cycles.h
> @@ -10,7 +10,13 @@
> extern "C" {
> #endif
>
> +#ifdef linux
> +#include <features.h>
> +#endif
> +
> +#ifdef __GLIBC__
> #include <sys/platform/ppc.h>
> +#endif
>
> #include "generic/rte_cycles.h"
>
> @@ -26,7 +32,13 @@ extern "C" {
> static inline uint64_t
> rte_rdtsc(void)
> {
> +#ifdef __GLIBC__
> return __ppc_get_timebase();
> +#else
> + uint64_t __tb;
> + __asm__ volatile ("mfspr %0, 268" : "=r" (__tb));
> + return __tb;
> +#endif
> }
>
> static inline uint64_t
> diff --git a/lib/eal/ppc/rte_cycles.c b/lib/eal/ppc/rte_cycles.c
> index 3180adb0ff..48545c4d67 100644
> --- a/lib/eal/ppc/rte_cycles.c
> +++ b/lib/eal/ppc/rte_cycles.c
> @@ -2,12 +2,28 @@
> * Copyright (C) IBM Corporation 2019.
> */
>
> +#ifdef linux
> +#include <features.h>
> +#elif defined(__FreeBSD__)
> +#include <sys/types.h>
> +#include <sys/sysctl.h>
> +#endif
> +
> +#ifdef __GLIBC__
> #include <sys/platform/ppc.h>
> +#endif
>
> #include "eal_private.h"
>
> uint64_t
> get_tsc_freq_arch(void)
> {
> +#ifdef __GLIBC__
> return __ppc_get_timebase_freq();
> +#elif defined(__FreeBSD__)
> + uint64_t freq;
> + size_t length = sizeof(freq);
> + sysctlbyname("kern.timecounter.tc.timebase.frequency", &freq, &length, NULL, 0);
> + return freq;
> +#endif
> }
>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
next prev parent reply other threads:[~2021-05-18 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 0:46 Piotr Kubaj
2021-05-18 20:42 ` David Christensen [this message]
2021-05-19 7:53 ` Thomas Monjalon
2021-05-19 9:57 ` Piotr Kubaj
2021-05-19 9:59 ` Thomas Monjalon
2021-05-19 12:07 ` Piotr Kubaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6435d3f6-c80b-d50e-bc11-70c8044d2b19@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=pkubaj@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).