From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F51CA00C5; Thu, 27 Oct 2022 14:55:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF95342670; Thu, 27 Oct 2022 14:55:00 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 0707941153 for ; Thu, 27 Oct 2022 14:54:59 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3FD8F3200564; Thu, 27 Oct 2022 08:54:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 27 Oct 2022 08:54:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666875294; x= 1666961694; bh=mS0MYe8Zfsq4XszujZXES1AdvkmO4CKkfW4miqErdQc=; b=V mlyeOqZbL5ocODjJ1SREzy5GZaV4dV0qZVLVob4yJSnGlqA0WsnMVxEpmq9iCi0B uCVOFm66AR7afecNvSOOx+mlrihq/hDMH3WsVjDyp65E1LVMcVK7flMmnKzIAhSl +/r2Jl7srGcLok49+poav+qFcRv6MJPlKOB3cJeTTLmjIA2GIVdEyYJbnXSGIHJD fF8QKEp1a0raKmZcv2bXggWiRLxljkvFk4h0K5RfiaS/MioLulluyQvPXZQrL7rP 5FvNWdjwakNahFDCBGy3uC92Sso7/Hu46YMh2XhxqUzs7i5+nb+oiejy6/J3XSR8 E1Z7tAuUNPvXOFmn9vFcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666875294; x= 1666961694; bh=mS0MYe8Zfsq4XszujZXES1AdvkmO4CKkfW4miqErdQc=; b=q hIJ+tAeXy4y5vyTXliqhQgGCF+Q+sK7FNGcJ6XBsWffeVBZFUWaGO1RsLOTwfU5h 08evN6Ii5vQDF1lu6V6aHOU/fJtzAGkD38GSaguywIc5y81v2NybVFr8pZ78aoUv gHPikjaOCsUMF9i8OL7o1fowGX0w1yj6P5SgTW5Si5tELb3cU5WJMAtd0pm6ZLTk Xiob4v1EXmzEa6zf6MeNIOrWRe1nGADEc2Q8q85XviJFxCltA7W3NonyHB/gIdee ZQ7VILlIbaolrdRl8LlnXhIS9huLXuGESfulMB0aCKxFvmytWtof696mEhhDXP2B LJgXIFkteUmLqWRjNcGaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeggdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Oct 2022 08:54:53 -0400 (EDT) From: Thomas Monjalon To: Hanumanth Pothula , Andrew Rybchenko Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com, rasland@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com Subject: Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD Date: Thu, 27 Oct 2022 14:54:51 +0200 Message-ID: <6437234.G0QQBjFxQf@thomas> In-Reply-To: <2059269.bB369e8A3T@thomas> References: <20220802175151.2277437-1-hpothula@marvell.com> <1ab79c80-ed69-8a18-5742-0039e10faecf@oktetlabs.ru> <2059269.bB369e8A3T@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/10/2022 09:34, Thomas Monjalon: > 17/10/2022 10:32, Andrew Rybchenko: > > On 10/6/22 21:35, Hanumanth Pothula wrote: > > > Presently, Rx metadata is sent to PMD by default, leading > > > to a performance drop as processing for the same in rx path > > > takes extra cycles. > > >=20 > > > Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' > > > to control passing rx metadata to PMD. By default it=E2=80=99s disabl= ed. > > >=20 > > > Signed-off-by: Hanumanth Pothula > >=20 > > Acked-by: Andrew Rybchenko > >=20 > > Applied to dpdk-next-net/main, thanks. >=20 > I'm not sure this patch is really acceptable. > It is disabling Rx metadata by default just for benchmarking reason > because your driver is doing some processing even if metadata is not requ= ired. >=20 > From a user perspective, if a command requesting metadata is entered, > it won't work until we enable this new option on startup. > It looks terrible. >=20 > Please tell me I misunderstood something. While pulling, I see that the name is not compliant with others. I think it should start with "enable-", use hyphens and be sorted. I'll drop it from the pull for now, we can have it in -rc3.