From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 621154340A; Thu, 30 Nov 2023 09:40:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 028E042E5D; Thu, 30 Nov 2023 09:40:37 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 37AA442E5C for ; Thu, 30 Nov 2023 09:40:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 62CB15C023B; Thu, 30 Nov 2023 03:40:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 30 Nov 2023 03:40:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1701333635; x=1701420035; bh=at7+4ZwRCnjyauhWoHA0/YSMx8Ib4hCtG95 45SsXpt0=; b=bvgKjYUvjiqeK+AXYCHHWcuRoFG4anlLg6+PufxxOH0TUYQAIy3 BCMrBdhUylVgGMZLZp86Xjafr9NNnuSV6jwP3a0YkyHbmLXPbkr2CSu49YMphQ1R d5lf+EMWSIebqUgjxWV6NUjUDyItIYvn0KKoShcvKzvE6B+Mn605lDcFGBd7+V2e /rEqh4fAjN5P11hfc3wZdFXrFhxNcVujcTzFdR/kMqPTybuSIOBRCH8fZEsp5a4w x6+eMLdcaCTLfOsPpuL8w6ZIfsCg9qFpHILMxNDDfxQZi2mFc/H9W/b/t6ok+50B hBl7ED8otJRCnlYbroFKISCv6z8tQAZUfRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701333635; x=1701420035; bh=at7+4ZwRCnjyauhWoHA0/YSMx8Ib4hCtG95 45SsXpt0=; b=KF9wNmE4frzajCF3S7BQ41uDgl9lI75mCFRvuS0v5pAqR6zZEOg 3EGQ//llGqGAp597TJ7lZEZUz2T2MRRA/q4W/QmC2/M5VZq9nIdhxn/4dmnTM8yu ehg7BLcOpjBnW1a+mpfk+nc+C/1kX2JGjltFVanJBLvkm/llHwksSus/wgafB+6Q Op3xlEl7xpuooBXIO8CGPVpyMaQGi6wKx0kjWZc1Y16zjZh39/Jh8mSIyHOCoXux RadHhqU8PxwhvKvx31mPSlB+Ku7iEGp0N7HG46WuRWg1Xm+VsPClzveeBISNGr46 SlZsRr49ZErT/QBMIPIEd/Amn3wSu4KzN9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiiedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Nov 2023 03:40:34 -0500 (EST) From: Thomas Monjalon To: Ankur Dwivedi Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch Date: Thu, 30 Nov 2023 09:40:31 +0100 Message-ID: <6438058.VqM8IeB0Os@thomas> In-Reply-To: References: <20230303155811.2751210-1-adwivedi@marvell.com> <5670179.Sgy9Pd6rRy@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/11/2023 06:56, Ankur Dwivedi: > From: Thomas Monjalon > > 28/11/2023 15:07, Ankur Dwivedi: > >> > 07/03/2023 13:05, Ankur Dwivedi: > >> >> This patch series adds a validation in checkpatch tool to check if > >> >> tracepoint is present in any new function added in ethdev, eventdev > >> >> cryptodev and mempool library. > >> >> > >> >> v5: > >> >> - Copied the build_map_changes function from check-symbol-change.sh > >to > >> >> check-tracepoint.sh. > >> >> - Added eventdev, cryptodev and mempool in libdir in check- > >tracepoint.sh. > >> > > >> >Why did you decide to copy the function in v5, instead of having a > >> >common file usable by different scripts? > >> > > >> There was comments in v2 of the patch that common scripts may not work > >well and to keep the scripts specialized. > > > >I meant you can have a common file specialized in symbols. > The build_map_changes() (in devtools/check-symbol-change.sh) which is a common function can be moved to a new file named devtools/build-symbol-map.sh. > The build-symbol-map.sh can be included in check-symbol-change.sh and check-tracepoint.sh. > Please let me know if this is fine. Yes We can imagine moving more symbol map related funtions in this new file. What about symbol-map-util.sh as filename?