* [dpdk-dev] [PATCH] build: use static deps of libs for pkg-config libs.private
@ 2019-01-11 16:12 Luca Boccassi
2019-01-14 10:54 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Luca Boccassi @ 2019-01-11 16:12 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, Luca Boccassi, stable
Dependencies of the RTE libraries were not being added to the
Requires.private field of the pc file since the variable used for
dynamic linking was passed to the related field of pkg.generate.
Use the static one so that dependencies are included.
Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")
Cc: stable@dpdk.org
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
split from the other series, it's a stand-alone non-invasive change
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 426e0bf3a..d500507c5 100644
--- a/meson.build
+++ b/meson.build
@@ -81,7 +81,7 @@ pkg.generate(name: meson.project_name(),
filebase: 'lib' + meson.project_name().to_lower(),
version: meson.project_version(),
libraries: dpdk_libraries,
- libraries_private: dpdk_drivers + dpdk_libraries +
+ libraries_private: dpdk_drivers + dpdk_static_libraries +
['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
description: '''The Data Plane Development Kit (DPDK).
Note that CFLAGS might contain an -march flag higher than typical baseline.
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] build: use static deps of libs for pkg-config libs.private
2019-01-11 16:12 [dpdk-dev] [PATCH] build: use static deps of libs for pkg-config libs.private Luca Boccassi
@ 2019-01-14 10:54 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-01-14 10:54 UTC (permalink / raw)
To: Luca Boccassi; +Cc: stable, dev, bruce.richardson
11/01/2019 17:12, Luca Boccassi:
> Dependencies of the RTE libraries were not being added to the
> Requires.private field of the pc file since the variable used for
> dynamic linking was passed to the related field of pkg.generate.
> Use the static one so that dependencies are included.
>
> Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> split from the other series, it's a stand-alone non-invasive change
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-14 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 16:12 [dpdk-dev] [PATCH] build: use static deps of libs for pkg-config libs.private Luca Boccassi
2019-01-14 10:54 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).