From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f178.google.com (mail-wj0-f178.google.com [209.85.210.178]) by dpdk.org (Postfix) with ESMTP id A65432C71 for ; Wed, 4 Jan 2017 18:39:05 +0100 (CET) Received: by mail-wj0-f178.google.com with SMTP id ew7so2470591wjc.3 for ; Wed, 04 Jan 2017 09:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=FGv3LQs5NAqdFxhy5DR/Lw9mpicvUK8t2qpdMLjJB0I=; b=2CNzZUm4JiMj9oVZRxn+HfI0vJWo8Rvh9BHCvR7iJl6Ffj6LIpUgg6Crrcmz8JbZ5O UyXniPkaQQ9ANrFyLLN44ZiqiBLmdrrPxo0X9+xHEMdIiZ3db32bPGpiIW7WgdpZiBw0 eqooUbLe0JbZqz7YcyTImH/Da3imWa0cwok+sZGzEOfOAAQU5hjsRWunPyZ3CCfSeRUn L47mwc0KmbIfATjIvebir/4ZMYESblP/6ECH9jVDPrIiVtsp5fz+I7GPuQaeN+zuLTTt xZPKWSZcohHHUqvQDNsrKf9Q+BksJ1+krsaQprKAqICXBc43Grv26QlR+iB/FtYnYYew FLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=FGv3LQs5NAqdFxhy5DR/Lw9mpicvUK8t2qpdMLjJB0I=; b=JC8dwVriHWBDRPByjSpTi+qi39+iRQDb34ENKlptqG7bXHVn9bp1EkEd20hRg60//i I9IPs8Dgrby88wMwidVjvglfRGKLpb65yCA4zBZYtXQQajDbRmKNn4ZCAcjdQy6mvb4A 7sFNUA/PzkvMmuM3pI/UsSKXzIj/lesAYgVyEkOBpSekfBRJZzcyY/oz3sp1kplfTK4J SUtH5SUi8O7EQ8iDrod+pSJpkNW2+fgogKf69tFCcTcjeI4P7MOKIQd5HyGfG2gsSUei F1I6L/9aOjUlsu4QpcITglbxxWSyHDsMtg8ePGrq7nn2ZORgL8Nx3osxgToSWxMYDLb/ hXyw== X-Gm-Message-State: AIkVDXLNr/gzSUsmcyizNcdBsfUlXd3SbCjMjLYRBRh84guSx+PUFpskX5sZFOru7oy+SVX9 X-Received: by 10.194.162.8 with SMTP id xw8mr55492930wjb.125.1483551545297; Wed, 04 Jan 2017 09:39:05 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l187sm96305439wml.6.2017.01.04.09.39.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 09:39:04 -0800 (PST) From: Thomas Monjalon To: Ben Walker Cc: Shreyansh Jain , dev@dpdk.org Date: Wed, 04 Jan 2017 18:39:03 +0100 Message-ID: <64510177.2V8Gqa4j9X@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2631459.aun9V5NdHs@xps13> References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <2631459.aun9V5NdHs@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 17:39:05 -0000 2016-12-21 17:19, Thomas Monjalon: > 2016-11-25 14:51, Shreyansh Jain: > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > If resources were mapped prior to probe, unmap them > > > if probe fails. > > > > > > This does not handle the case where the kernel driver was > > > forcibly unbound prior to probe. > > > > > > Signed-off-by: Ben Walker > > > > Acked-by: Shreyansh Jain > > The 3 first patches of this series seems good and easy to agree, > except some minor nits. > > Please Ben or Shreyansh, could you respin only them to help make > progress before applying a PCI/bus rework from Shreyansh? > As soon as one of you shoot a partial v3, I'll apply them. > Thanks Please Ben, do you want to make a partial v3?