From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E37C1A0A0A; Fri, 22 Jan 2021 13:15:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 665C4140F4B; Fri, 22 Jan 2021 13:15:41 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 44D4D140F42; Fri, 22 Jan 2021 13:15:40 +0100 (CET) IronPort-SDR: EhGTlbQEWVrJHZCNHy2VlJzJjm/VqHJjLlwFv8m7DR/hv5b2VIpCfHZJpt7GkSf9MmjAX7OJlu whA9iLSr+Qfw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="198192114" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="198192114" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 04:15:39 -0800 IronPort-SDR: xIc4ufvqdQ+ZFptR7dwACOr1mYaGvjBKQcVm1JWU4IkgGVwhDTqzxGqkiLYQDlGC7PHr9NpkRH Iy2+aIac2hJA== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="357004443" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.25.114]) ([10.213.25.114]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 04:15:37 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson References: <20210120135556.33763-2-david.hunt@intel.com> <20210121172201.22582-1-david.hunt@intel.com> <20210121172201.22582-4-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <6459584c-1535-0cbc-6847-001a4bec60ad@intel.com> Date: Fri, 22 Jan 2021 12:15:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210121172201.22582-4-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 3/6] power: rename public structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Jan-21 5:21 PM, David Hunt wrote: > From: Bruce Richardson > > rename the public structs to have an rte_power_ prefix and > add them to version.map in experimental section. > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > Signed-off-by: David Hunt > > --- > changes in v4 > * Improve sizeof's > * add the 2 functions to the version.map file > --- > diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h > index c500c0cda..c9ab7bae8 100644 > --- a/lib/librte_power/rte_power_guest_channel.h > +++ b/lib/librte_power/rte_power_guest_channel.h > @@ -11,7 +11,10 @@ extern "C" { > #include > #include > > -/* --- Incoming messages --- */ > +#define MAX_VFS 10 > +#define VM_MAX_NAME_SZ 32 > +#define MAX_VCPU_PER_VM 8 > +#define HOURS 24 > These and other defines are in public header, and they're not under RTE_ namespace. To avoid clashes with user code, I would suggest either adding an RTE_ prefix, or maybe #undef'ing them at the end of the file. -- Thanks, Anatoly