From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5201A04C7; Tue, 15 Sep 2020 18:10:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35C471C0C6; Tue, 15 Sep 2020 18:10:45 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 820981BE8E for ; Tue, 15 Sep 2020 18:10:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 42F24F62; Tue, 15 Sep 2020 12:10:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 15 Sep 2020 12:10:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 6JHoDyeglVgc5ZWPIr2iENOsjmaLXoW4S4wkcl2aV3Q=; b=RPFT5Gs9etC7FJ/A w5hcsvJ0IIrxHu5Ulx174erhzYGvTA6hCFhFZMbTEfq4upM8P3fOLJzmk1w5DCNU 7WbiumArKtPlhKZiobblxVbT+k64srMw5VMQi05DlE4W/G7uSTm6mowhyQmDQpXT jXJ7P9d24HZ4b7I3nWVyNhyGjQ2R3I9CbyMNAjEa2sbYlpbcPE0SuF9OME5YMPqo qwoIyAUwrJCBY9cEQ6KFvgXPkx4mW3CvZRqqxHtPAbkEbYUPevEMpHvUSjr/XNfC WCc3zsnkRmgKOLPoPcIZaZ1fyWH9R3DfjexfpqpCfi5L3Vst+0D2A5IHPiYWgE7q IJ2ldg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6JHoDyeglVgc5ZWPIr2iENOsjmaLXoW4S4wkcl2aV 3Q=; b=qfqOlEFcxGtywDFFqGGnJl09eWUr4aJoLllabI4g5alAD6SeEw1JWO6xm dckMXRAFxOT79WX+LvnUeZjilgY4yR3yjrtTHdXi8E0DDBlxhrdAfqJVFCg7EBIx 3NyC1if//UnrUxwoQCFjw+s/AwxTSjTVVs3uUPFLCc1UoYjdnOvyNeP6oLY4neR7 zV5ArOmAlB0+0jBnv22ciqXDpQLWZYWP+48W/ygxTCivnDfll6o5NfmNFD/UX95p cXWeLfNSl4xAYEir96O03ytF2Z5MEYnNZuxI4BcSkuBk8j3+v1LVwVlZ1SBYOcxu 3pIICvgwBI0bqADZS+IBXxNqRmskg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddtgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DF7953280060; Tue, 15 Sep 2020 12:10:39 -0400 (EDT) From: Thomas Monjalon To: David Marchand , "Chautru, Nicolas" , "Power, Ciara" , "Richardson, Bruce" Cc: dev Date: Tue, 15 Sep 2020 18:10:38 +0200 Message-ID: <6470705.gZyV2GM0uM@thomas> In-Reply-To: <569c544c659c48dcb5a75af2581a1a8d@intel.com> References: <20200903152717.42095-1-ciara.power@intel.com> <3216590.6Dkn3NIytC@thomas> <569c544c659c48dcb5a75af2581a1a8d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2020 17:57, Richardson, Bruce: > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, September 15, 2020 4:44 PM > > To: David Marchand ; Chautru, Nicolas > > ; Power, Ciara > > Cc: Richardson, Bruce ; dev > > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > 15/09/2020 17:08, Power, Ciara: > > > Hi David, > > > > > > > > > >-----Original Message----- > > > >From: David Marchand > > > >Sent: Tuesday 15 September 2020 15:03 > > > >To: Thomas Monjalon ; Chautru, Nicolas > > > > > > > >Cc: Richardson, Bruce ; dev > > > >; Power, Ciara > > > >Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > > > >On Tue, Sep 8, 2020 at 11:05 AM Thomas Monjalon > > > >wrote: > > > >> > > > >> 08/09/2020 10:16, Bruce Richardson: > > > >> > On Tue, Sep 08, 2020 at 12:06:40AM +0200, Thomas Monjalon wrote: > > > >> > > The first 13 commits of this series are pushed to the main > > > >> > > branch, making the make-based build an old story. > > > >> > > > > > >> > > The last 18 commits (devtools, app and doc) are pending for > > > >> > > more reviews, especially because the doc rework is still in > > progress. > > > >> > > This is a big change which requires to be split but must be > > > >> > > completed soon. > > > >> > > *All*, please make the documentation update your highest > > priority. > > > >> > > I will be reluctant to merge some driver changes if the related > > > >> > > doc is not updated. > > > >> > > > > > >> > Thanks for the apply of the code patches, I think it will make > > > >> > all our subsequent patch submissions a bit cleaner. > > > >> > > > > >> > In terms of docs, I believe the Linux and FreeBSD GSG guides to > > > >> > be ready for merge, or if not 100% they are at least good enough > > > >> > IMHO to be applied now and have some minor tweaks in subsequent > > > >> > patches later. While I'm sure the Linux GSG could do with more > > > >> > major rework, that should be separate from the doc updates in this > > patch. > > > >> > > > >> Of course I am not expecting any major rework in these patches, but > > > >> I don't want to apply clean-up half done, which can drop some > > > >> relevant informations or introduce mistakes. > > > >> > > > >> I will review the Linux and FreeBSD user guides first, as you > > suggest. > > > > > > > >I could not find a patch in patchwork for > > > >app/test-bbdev/test-bbdev.py which still references RTE_SDK and > > RTE_TARGET. > > > > > > > > > > > >-- > > > >David Marchand > > > > > > > > > Changes to test-bbdev.py were made in patch 15: > > https://patchwork.dpdk.org/patch/76796/ to remove the references to > > RTE_SDK and RTE_TARGET. > > > > I did not merge this patch because it is hardcoding "build" as a > > directory. > > I'm sure we can do better. > > > > We probably can, but is it really worth holding up the patch over something as trivial as that? It is really likely to cause people issues? I give one more week to Nicolas to better fix this script. If not, I will merge that patch as is.