From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A5E731B8C9; Thu, 18 Apr 2019 10:07:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E1C42220E2; Thu, 18 Apr 2019 04:07:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Apr 2019 04:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=81nUEMZkMvX08obVgE/m6laBqh7YYsT31LGoM7BcxkI=; b=GYpl1JVyfKEJ 2uvlpzKrcAPtQIWBr4NfyJC/nRymuHxw41sVkMSUa59dyPKt4rKKowb+7hmbb2Ke skgneKqWnxjL/GWnfJcWV5xtNZSxkbX/Qx3xr8oxa1Z9SRdK480jenxN1cFXY89t dMpcIxTqO6+/hAczgVPQuRJUnNGcP9Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=81nUEMZkMvX08obVgE/m6laBqh7YYsT31LGoM7Bcx kI=; b=Kh+uyuVhqf7qNYsHQ0f2csnBcMgFN7caHJMDJKDmQqmyPAEuHlco6GJ0V QL6ILq/ZMt/e7dh1NlE5j+qF86n3YkZzKn+4WSl3EbuP7Hwdury0w2yh8MgpWD6p e1uYE7N5sKYDgH8Q+98SR65lMJa1JLxQ8G0WRPCorCBstXdgVXpZK/SDsvQ7psS5 f+1dFZLWYGotUnADrgIwjOl8LuxOE0YLMpFnclPwakyYsFg5pYNcZcjPpZ0wCtCa i7b18hU1d/VY3dKAjNJUgqEI/OLDoVhau9WxvF/QzWDrZhxGSAWmAO8ipVc8+dYv yeog4sxpgIHn2vL75g9YFMJ29TD4w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeehucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 790D910319; Thu, 18 Apr 2019 04:07:54 -0400 (EDT) From: Thomas Monjalon To: Vivek Kumar Sharma Cc: stable@dpdk.org, "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "intoviveksharma@gmail.com" , Stephen Hemminger , "ramirose@gmail.com" Date: Thu, 18 Apr 2019 10:07:52 +0200 Message-ID: <64842434.YePMVcpFdi@xps> In-Reply-To: References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <2967249.IQ5QtALfrT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 08:07:59 -0000 18/04/2019 09:38, Vivek Kumar Sharma: > >> From: Vivek Sharma > >> > >> Enable missing support for QinQ strip rx offload > >> in vlan offload set/get methods. > >> > >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") > >> Cc: stable@dpdk.org > > >Not sure it is a fix. > >The commit mentioned above allows some kind of offload config. > >You are extending the offload config with support in > >rte_eth_dev_set_vlan_offload(). > > DEV_RX_OFFLOAD_QINQ_STRIP was introduced in cc9d0456b870 ("i40e: support double vlan stripping and insertion"). But, the means to utilize this capability by enabling this rx offload for an ethdev was missing from the patch. The current patch fixes that missing functionality so that user can enable QinQ strip rx offload for capable devices. It was possible to utilize the offload by setting the flag in mbuf. You are adding a way to configure it at port level. So it is not a fix. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 53588A00E6 for ; Thu, 18 Apr 2019 10:08:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BC251B8F7; Thu, 18 Apr 2019 10:08:00 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A5E731B8C9; Thu, 18 Apr 2019 10:07:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E1C42220E2; Thu, 18 Apr 2019 04:07:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Apr 2019 04:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=81nUEMZkMvX08obVgE/m6laBqh7YYsT31LGoM7BcxkI=; b=GYpl1JVyfKEJ 2uvlpzKrcAPtQIWBr4NfyJC/nRymuHxw41sVkMSUa59dyPKt4rKKowb+7hmbb2Ke skgneKqWnxjL/GWnfJcWV5xtNZSxkbX/Qx3xr8oxa1Z9SRdK480jenxN1cFXY89t dMpcIxTqO6+/hAczgVPQuRJUnNGcP9Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=81nUEMZkMvX08obVgE/m6laBqh7YYsT31LGoM7Bcx kI=; b=Kh+uyuVhqf7qNYsHQ0f2csnBcMgFN7caHJMDJKDmQqmyPAEuHlco6GJ0V QL6ILq/ZMt/e7dh1NlE5j+qF86n3YkZzKn+4WSl3EbuP7Hwdury0w2yh8MgpWD6p e1uYE7N5sKYDgH8Q+98SR65lMJa1JLxQ8G0WRPCorCBstXdgVXpZK/SDsvQ7psS5 f+1dFZLWYGotUnADrgIwjOl8LuxOE0YLMpFnclPwakyYsFg5pYNcZcjPpZ0wCtCa i7b18hU1d/VY3dKAjNJUgqEI/OLDoVhau9WxvF/QzWDrZhxGSAWmAO8ipVc8+dYv yeog4sxpgIHn2vL75g9YFMJ29TD4w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeehucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 790D910319; Thu, 18 Apr 2019 04:07:54 -0400 (EDT) From: Thomas Monjalon To: Vivek Kumar Sharma Cc: stable@dpdk.org, "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "intoviveksharma@gmail.com" , Stephen Hemminger , "ramirose@gmail.com" Date: Thu, 18 Apr 2019 10:07:52 +0200 Message-ID: <64842434.YePMVcpFdi@xps> In-Reply-To: References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <2967249.IQ5QtALfrT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418080752.Gx73TE9_RDcjqHtZazoQ23YtCnNtLbBE8YFzCMbHkB4@z> 18/04/2019 09:38, Vivek Kumar Sharma: > >> From: Vivek Sharma > >> > >> Enable missing support for QinQ strip rx offload > >> in vlan offload set/get methods. > >> > >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") > >> Cc: stable@dpdk.org > > >Not sure it is a fix. > >The commit mentioned above allows some kind of offload config. > >You are extending the offload config with support in > >rte_eth_dev_set_vlan_offload(). > > DEV_RX_OFFLOAD_QINQ_STRIP was introduced in cc9d0456b870 ("i40e: support double vlan stripping and insertion"). But, the means to utilize this capability by enabling this rx offload for an ethdev was missing from the patch. The current patch fixes that missing functionality so that user can enable QinQ strip rx offload for capable devices. It was possible to utilize the offload by setting the flag in mbuf. You are adding a way to configure it at port level. So it is not a fix.