From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EB2EA276C for ; Thu, 28 Sep 2017 01:09:44 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 16:09:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,446,1500966000"; d="scan'208";a="904551901" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.10.197]) ([10.252.10.197]) by FMSMGA003.fm.intel.com with ESMTP; 27 Sep 2017 16:09:41 -0700 To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-4-shreyansh.jain@nxp.com> <916531df-edb4-d0fe-cb86-32cedb6fc46a@intel.com> <690be1c8-67d1-31e0-b1dc-4b270b1f8519@nxp.com> <3bf46b37-6bcb-b6c5-62ea-5632f81f518a@intel.com> From: Ferruh Yigit Message-ID: <6489a791-e586-9f15-dd71-4aff3294493b@intel.com> Date: Thu, 28 Sep 2017 00:09:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 23:09:45 -0000 On 9/26/2017 1:43 PM, Shreyansh Jain wrote: > On Tuesday 19 September 2017 07:27 PM, Shreyansh Jain wrote: >> On Tuesday 19 September 2017 07:10 PM, Ferruh Yigit wrote: >>> On 9/19/2017 2:18 PM, Shreyansh Jain wrote: >>>> On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: >>>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>>>> From: Hemant Agrawal >>>>>> >>>>>> Linked list, bit operations and compatibility macros. >>>>>> >>>>>> Signed-off-by: Geoff Thorpe >>>>>> Signed-off-by: Hemant Agrawal >>>>> > > [...] > >>>>>> + */ >>>>> >>> >>> <...> >>> >>>>>> + >>>>>> +#ifndef __DPAA_LIST_H >>>>>> +#define __DPAA_LIST_H >>>>>> + >>>>>> +/****************/ >>>>>> +/* Linked-lists */ >>>>>> +/****************/ >>>>> >>>>> Do we need to maintain a linked list implementation, why no just use >>>>> sys/queue.h ones as done many places in DPDK? >>>>> >>>>>> + >>>>>> +struct list_head { >>>>>> +    struct list_head *prev; >>>>>> +    struct list_head *next; >>>>>> +}; >>>>>> + >>>>> >>>>> <...> >>>>> >>>> >>>> The underlying DPAA infrastructure code is shared between kernel and >>>> userspace. That is why, changing the internal headers (for example, >>>> using RTE_* queues) is something I want to avoid until absolutely >>>> necessary. The outer layers (drivers/*/dpaa/) are something I am >>>> trying to keep as close to possible to DPDK. >>> >>> I understand you want to escape from maintaining a copy of common files >>> for DPDK, this has been done by many drivers, as not changing "base" >>> files, this makes sense. >>> >>> But for this case, file is "dpaa_list.h" and as far as I can see all it >>> has is linked list implementation, this looked easy to exclude, but if >>> not you can ignore the comment. >> >> Got your point. I will respin and see how much is the impact. >> Thanks for inputs. > > I tried to work around the dpaa_list.h use in DPAA code - but, the > changes are subtle but large in number - though, restricted only to base > framework. > I would prefer to skip this for a while as the driver is stable now. I > would probably do this change in a incremental manner to keep it traceable. > > Ferruh, Is that OK with you? That is OK, if it is not easy to escape from it.