From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45E4AA0C45; Thu, 16 Sep 2021 16:06:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33DE34069E; Thu, 16 Sep 2021 16:06:17 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 82BA840151 for ; Thu, 16 Sep 2021 16:06:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="308113762" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="308113762" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 07:06:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="530180019" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 16 Sep 2021 07:06:13 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 07:06:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 07:06:13 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 07:06:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BS3uwk0ILQIg1VIpNunFMutL0Plm88WPDC3Yel5HnIQFnUrJWZ7IVqgTwO2ofwhZ/OOlQEY+xwiW95IK2SSvRYr0SQWpcCnnd7OmwcFjWriz5YIuBkbkmku2wfRrZdjdGFLhmzp5/JrGwSM/FtpUF+7d8whLMhbbBZtTV29FnG5ajnZjFNcH47MEpPNfWlHsSvUITyBMtSbklpqxACh16wFNRF+YthdhyEakjZBU8coSwiOqomVOcKP3eYx/Zs7oN65krQX54ChfdxiejFg6WK0g5ZDodvr1VhJXJbjjw12rZr6p34I4+XWyzytJChTtkJVp4FWfFBPLoOMM6Alr6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sk2ZO3ZZHSHwbeZi+gCkYInGdPi9eJ1fIWOipXfpdzk=; b=Ija1q24oAtLxZxCjXx3glXJBpO1KhsvPq+7SFLdfVhbTTy1byBLn1XB1D70YRcKCleMPQt8oOcCCFSJIdQilNEBoI+jc3fhlIJuOisfGO0R6ApqX1sLw8AMfu2sEJ+/0/z9SMF1ojOcT9sJc37n9HjNqnf6fjH7sb23Y5n/fSiNn28KjoiJomibkbUNKBZ6bY60m8ls9vnTkzqF/4kfH878wUQ0k2k/A5POGyFDCKNfcag7airyVdldgn3gKvqYhbaeVXy1jYpPLRc7GVve7p63rKbLqIWU/0HRTOLvOXkEcCOrbNEQCbbAX1Z+QSFbeV5A0FsXF/9x3T+rbeSPQ5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sk2ZO3ZZHSHwbeZi+gCkYInGdPi9eJ1fIWOipXfpdzk=; b=Bk44LpCiWA/6E/OEDjmMhWUGg6VfoB6Mvb0GCaBaKBSDc2+koyU/ysmgNNkEcXWRFlkmG0GV9qDwwrEdSgRumzHsVPO5QaR9emOa7QXFktkTDdVk6RyjIZ9BZYs1rWRdeNbV/NlRinV+fNuX30eYE8a0JzAompk0ltOdDb8SbE0= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5141.namprd11.prod.outlook.com (2603:10b6:510:3c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Thu, 16 Sep 2021 14:06:09 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 14:06:09 +0000 To: Ajit Khaparde , Thomas Monjalon , David Marchand CC: Kishore Padmanabha , Mike Baucom , Venkat Duvvuru , , Qi Zhang , Raslan Darawsheh , "Maxime Coquelin" , "jerinj@marvell.com" , Chenbo Xia References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <20210911153041.28510-1-venkatkumar.duvvuru@broadcom.com> <20210911153041.28510-14-venkatkumar.duvvuru@broadcom.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <64910ebe-c922-fadf-f152-c4a2fcbcc51b@intel.com> Date: Thu, 16 Sep 2021 15:06:02 +0100 In-Reply-To: <20210911153041.28510-14-venkatkumar.duvvuru@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8PR06CA0054.eurprd06.prod.outlook.com (2603:10a6:10:120::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0054.eurprd06.prod.outlook.com (2603:10a6:10:120::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Thu, 16 Sep 2021 14:06:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3068530-8a31-401e-5555-08d9791b2226 X-MS-TrafficTypeDiagnostic: PH0PR11MB5141: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4wtKdf0lacQCfHtUqDDZM3WL92Ru9BVxQrDkGGsvop90LzBsMwYYALL5vHEqstxnrGzBGjkY3tgIJA7rHmd/xQKg1XYK5afwakWhqnS8gUKqnc1BKPU0N6i/lvr7So5WZD5vnuNb699gJonI0sqAM3eayZof1nrQCWqpEjbAmHldJaFsSDEi2ljiytSG32yjqkwOn3Xw/SgVL0Qm5k3rwn4RwQtLTVFPM7wPtm06gnjqPkkiTckiE4Kp2LULhcxyLudI9wq3yw6CrbPbYlJ1ZSFdiKO+35S59EWEmFW0xJAbXfwIpSNBjadIjO32MlzoFV7HEiF4v4dp2NiJpUjk+pLpCKS/fcIlpDJlnnYACrEt9LEETEUIpKa8zPzyG6xzxuetiipNCIRHig09+qkD3A+B3Emam/s36d0u1qXHr9kbVdQfasB2HOM+WTSQohA+aMPG1JKj5tWghNDN530JlzdXCNAli5+nT1HWDofGbOdDy3S2InAfOh2zBin5qpsbqMflDnjMOqabU0QaLW+uWovmHvRJQZG26l1W8OtEdsPfbyj2jbGzECDfB0VxaszLio8uI8st7Z90p/zYY8UZAClFOS4caiQWAJmxKXUqpVB4aN6YLNh6b6EZoaKdlr56BFUJyZiPG0IL83hmG6tRy5vggE8dVYghaeY95+JpR4SVJuxwtfpONGCfXjoqYpEs1N+0PbcuyYI25Y7d2e64hbOdZKqB6AaO7mNxLC3O8H4oNH10VSaVIpDo3FfiA1Jel+srxVfVisy4jcRBOtakKcopm12t3pEJ8nsNLC8EPtw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(966005)(2616005)(53546011)(26005)(107886003)(186003)(6666004)(956004)(86362001)(83380400001)(31696002)(5660300002)(66476007)(66556008)(8676002)(66946007)(8936002)(36756003)(2906002)(6486002)(54906003)(110136005)(44832011)(478600001)(316002)(16576012)(4326008)(7416002)(38100700002)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzRTb0s2clJHdEpKYktXWjJiWUdWUTlRd2podWo0OXR5UXZBWTdkY2E0VThM?= =?utf-8?B?cTBTaWsvSUxHUHlnYzJKZWNDdDc3end4SC9UWlptSE9PczRZdENtMkhqT0F3?= =?utf-8?B?R0pvUnU4cTFqdVpMWGdFTGtrclB5UVV2aDc3bkFaK2oxNW8rSXhLVVNTNTdX?= =?utf-8?B?RlMzVGNJODdPTTdWTXg1RVFOOGtaNGxRb2xkSUJRVzdyWnYyRDA3VmFCc0I0?= =?utf-8?B?dkZzVUpNZlBZQ25jN0dELzQ2dlF5TEIxc2J2SjF2TW9ERnNuRmFLcnpENlVU?= =?utf-8?B?VityU3BpeS9UbThHZkx2YnZGcllndmxEa2t0a1dQcC9JZ3lXbkE5UUNma0o3?= =?utf-8?B?cWhoSlBxWGtDM0JDdXpiTm50RmFJUEhHRUpzRVo2eDBxemh1d21nd3VIYnlS?= =?utf-8?B?cVhEdzV4WmpqV3JZRkZxcGVZOW1IcVorbGZjZ1I3eW9DUDdSMUZGRWlrMlpr?= =?utf-8?B?Q0Q3V2pzYUVHQlVCWHRVOUMrTndqQU1jQ3pacFM1UHU3Y0l3NElWYlpMdlA4?= =?utf-8?B?VGZ6a1hSOVdiUW4ybEVQbWpyN2dBSWJpSGRic002SFNZeVViOXdZVW4vaXJa?= =?utf-8?B?SUE2eXN2S1hyQ2ZrRzZBY2ZUaTQxRzBTYXF1ZmlGK0VzbThLY1h5N1NCYW9p?= =?utf-8?B?SWVhdkFuc2xiMXpveFRacTdqa3ZwblV0MFY5WHNVVXBObDR0cldJWWoyQytE?= =?utf-8?B?dWk1R2NxTjRWUDBiaEhEVktXRGx4VEd4amp2YkpEVDJCcGkrWVNSYzNVYzRZ?= =?utf-8?B?TjBza1lTK0FDc1FqS1E5Z0Fkd3pORmVucmZlWEE2NjQzWElkM2tpOHBSZ3N2?= =?utf-8?B?WVRZcllMNE5GSFhxREVrV29TbklndnNOT0EzTW5iTWtrQWplQjNMOTBVMWd3?= =?utf-8?B?dU1tT2R5R2NEL1FDYzFyaldabXBtd3RjVWVFTTVkMEFuOFIxcWJ5T1hqeXNU?= =?utf-8?B?bHNkUFdaUVNTeSsvY0Q3dExpTUxnUkk5cjJCUHJ2b1VOSlJUTjd5VllFK2c2?= =?utf-8?B?YWRXZkx1VnByMmRoRXFPa0tDOHJkeFVRK3pMNDFzZFRtUFh2RGM5WXBCcXZi?= =?utf-8?B?c1BwSXBuQWxDV3ZJM1I4azZBWW1NcHhnZUJVQndlTmJZbEcxb0FjWUFXQXVU?= =?utf-8?B?RkhTVzRuM3cxc016d29xNWhZeXFLSlVGdUpTczg4ZWdHZ0hSU0NTMjErdWxp?= =?utf-8?B?T0hLRTFDVGdKK1EvdVA1ZnE0SjU4WGpNUXBkR0NjamtHellYSTRFNnZ5V0VS?= =?utf-8?B?M0dheEtvOVIvVUJvQXZWWmQ3VDFYQXErRmYvV0VoMk95WDZQRExiYjRIUFpy?= =?utf-8?B?U0J5ZVNpM1hYeG42a0V1QlBWYytVZnJGLzBncXA5UDNVclBZSEs0eWpydGpP?= =?utf-8?B?aDRTWjYxMGVWNzZRc0xVRTFUdk45WDJqMExselRDR2J1aVIxSWxWekNTOHBs?= =?utf-8?B?MlhVQ3RTeVBTbWxCeU5Ed1RsMXhlck5oMkE2ZHFxc2NKZWRWMlFERXBzbzdz?= =?utf-8?B?V29ybElnd0NYK3pvK1ZOZGYrd2RsTG1mTFkyaVhYWGh6R096S3ppV01BQUY0?= =?utf-8?B?NUJ6Rlp2aUFBMWt6ODF6RFpjd1diS2lNMTM1NUdnVVo1YWF2d0Mva3pMT3FU?= =?utf-8?B?NXp6ZDVyUW1HMGgvbnU4TkxQKzU2NXNrVWozMU1mQTY4QmVWT2dvSHlLN2Y5?= =?utf-8?B?S3pJTzBnY2pMcE5OTFpqUFJVRG9ReGNzNUI0VWlpYk81N3ZuVEQ3bXdPaWJm?= =?utf-8?Q?SMp75mf1xDv6Rd8qEaV660YgmVfo4aGq4xQizD3?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3068530-8a31-401e-5555-08d9791b2226 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 14:06:09.5642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h26CD8FFZSUUQrRvcv922RBM9BAI3JVdS8g6/bjoTJ55fA5S2OexTqnqG27U3LQ0B3cN51xZaHT7/VfVMdQdsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5141 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 13/13] net/bnxt: add enhancements to TF ULP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > From: Kishore Padmanabha > > 1. Added support to specify l4 port masks in the template. Also enabled > source mac in the wild card key for ingress flows. > > 2. Added support to enable offload for ipv6 traffic within the vxlan > tunnel connection. > > 3. The flow counters is reduced from 7168 to 6912 for Whitney. > The stats operation is updated to reflect counts for packets > at egress from CFA instead of ingress to CFA > > 4. The miss path for the l2 context table is updated with correct > parif and default action handler to handle the miss path for > egress flows. > > 5. This support enables allocation of encapsulation, modification and > action records dynamically based on a given flow actions. > > 6. Reduce the l2context resource requests during open_session. Move the > SMAC from the L2Context to the EM/WM > > 7. Remap the parif in the bd action in order to eliminate incorrect > replication of broadcast packets. The layer 4 source port mask > was incorrectly updated in the outer layer 4 source port mask > instead of inner layer 4. Add the l3 proto to egress rules, switch > to using computed fields for l4 ports, add internal smac to f1/f2 > flows, add l3 proto to ingress ipv6 flows > > Signed-off-by: Kishore Padmanabha > Signed-off-by: Mike Baucom > Signed-off-by: Venkat Duvvuru > Reviewed-by: Randy Schacher > --- > drivers/net/bnxt/tf_core/tf_tbl_sram.c | 7 - > .../generic_templates/ulp_template_db_class.c | 8102 ++++++++++++----- > .../generic_templates/ulp_template_db_enum.h | 675 +- > .../generic_templates/ulp_template_db_field.h | 195 +- > .../generic_templates/ulp_template_db_tbl.c | 2136 ++++- > .../ulp_template_db_thor_act.c | 996 +- > .../ulp_template_db_thor_class.c | 7495 ++++++++------- > .../ulp_template_db_wh_plus_class.c | 14 +- > drivers/net/bnxt/tf_ulp/ulp_gen_tbl.c | 4 +- > drivers/net/bnxt/tf_ulp/ulp_mapper.c | 135 +- > drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 175 +- > drivers/net/bnxt/tf_ulp/ulp_template_struct.h | 10 + > drivers/net/bnxt/tf_ulp/ulp_utils.c | 3 +- > 13 files changed, 13538 insertions(+), 6409 deletions(-) Hi Ajit, I can see release notes ('release_21_11.rst') updated in the commit in net-brcm tree [1], but that change doesn't exist in the original patchset. I think it is crucial to be in sync on this, that content of the patches shouldn't be changed in our sub-trees. cc'ed other subtree maintainers too, to be sure we are all in same page. Time to time we are doing simple changes/fixes in the repos, to help to the developer, but changes shouldn't go beyond it, and I believe even those changes should be communicated in the mail list for the record. If the content of the patches needs to be changed, I think that should be done by sending a new version of the set. I am aware it is additional overhead, but still doing otherwise can cause more trouble in long term. Thanks, ferruh [1] https://git.dpdk.org/next/dpdk-next-net-brcm/commit/?id=840e8bd01b6493940ac6130e1280713ec708d000