DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>,
	thomas.monjalon@6wind.com, bruce.richardson@intel.com
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com
Subject: Re: [dpdk-dev] [PATCH v3 02/32] qede/base: formatting changes
Date: Mon, 17 Oct 2016 17:28:29 +0100	[thread overview]
Message-ID: <64b17ffa-4405-98d4-29fc-180d45e74048@intel.com> (raw)
In-Reply-To: <1476562089-21823-3-git-send-email-rasesh.mody@qlogic.com>

Hi Rasesh,

On 10/15/2016 9:07 PM, Rasesh Mody wrote:
> Fixes white spaces and tabs.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---

When testing patch by patch compilation, applying this patch gives
following build error, the build error disappears after patch 12/32.

It should successfully compile after each patch, can you please fix this?


Build error:

.../drivers/net/qede/base/ecore_sp_commands.c: In function
‘ecore_sp_pf_update_tunn_cfg’:
.../drivers/net/qede/base/ecore_sp_commands.c:473:2: error: this ‘if’
clause does not guard... [-Werror=misleading-indentation]
  if (p_tunn->update_geneve_udp_port)
  ^~
.../drivers/net/qede/base/ecore_sp_commands.c:477:3: note: ...this
statement, but the latter is misleadingly indented as if it is guarded
by the ‘if’
   ecore_set_hw_tunn_mode(p_hwfn, p_hwfn->p_main_ptt,
   ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[10]: *** [base/ecore_sp_commands.o] Error 1
make[10]: *** Waiting for unfinished jobs....
.../drivers/net/qede/base/ecore_spq.c: In function ‘ecore_spq_add_entry’:
.../drivers/net/qede/base/ecore_spq.c:628:3: error: this ‘if’ clause
does not guard... [-Werror=misleading-indentation]
   if (p_ent->comp_cb.cookie == &p_ent->comp_done)
   ^~
.../drivers/net/qede/base/ecore_spq.c:631:4: note: ...this statement,
but the latter is misleadingly indented as if it is guarded by the ‘if’
    *p_en2 = *p_ent;
    ^
cc1: all warnings being treated as errors


Thanks,
ferruh

  reply	other threads:[~2016-10-17 16:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 20:07 [dpdk-dev] [PATCH v3 00/32] qede: update qede pmd to 1.2.0.1 and enable by default Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 01/32] qede/base: add new init files and rearrange the code Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 02/32] qede/base: formatting changes Rasesh Mody
2016-10-17 16:28   ` Ferruh Yigit [this message]
2016-10-17 17:25     ` Mody, Rasesh
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 03/32] qede: use FW CONFIG defines as needed Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 04/32] qede/base: add HSI changes and register defines Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 05/32] qede/base: fix the attention formating string Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 06/32] qede/base: additional formatting/comment changes Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 07/32] qede: fix 32 bit compilation Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 08/32] qede: change the API signature of ecore_mcp_cmd_and_union() Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 09/32] qede: serialize access to MFW mbox Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 10/32] qede: add APIs to support NIC selftests and query sensor info Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 11/32] qede/base: update base driver Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 12/32] qede/base: rename structure and defines Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 13/32] qede/base: comment enhancements Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 14/32] qede/base: add MFW crash dump support Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 15/32] qede: enable support for unequal number of RX/TX queues Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 16/32] qede: fix port (re)configuration issue Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 17/32] qede/base: allow MTU change via vport-update Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 18/32] qede: add missing 100G link speed capability Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 19/32] qede: remove unused/dead code Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 20/32] qede: fixes for VLAN filters Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 21/32] qede: add enable/disable VLAN filtering Rasesh Mody
2016-10-15 20:07 ` [dpdk-dev] [PATCH v3 22/32] qede: fix RSS related issues Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 23/32] qede: add scatter gather support Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 24/32] qede/base: change rx tx queue start APIs Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 25/32] qede/base: add support to initiate PF FLR Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 26/32] qede: skip slowpath polling for 100G VF device Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 27/32] qede: fix driver version string Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 28/32] qede: fix status_blk index for VF queues Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 29/32] qede: add support for queue statistics Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 30/32] qede: remove zlib dependency and enable PMD by default Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 31/32] doc: update qede pmd documentation Rasesh Mody
2016-10-15 20:08 ` [dpdk-dev] [PATCH v3 32/32] qede: update driver version Rasesh Mody
2016-10-17 17:05 ` [dpdk-dev] [PATCH v3 00/32] qede: update qede pmd to 1.2.0.1 and enable by default Ferruh Yigit
2016-10-17 17:52   ` Mody, Rasesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64b17ffa-4405-98d4-29fc-180d45e74048@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Dept-EngDPDKDev@qlogic.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=rasesh.mody@qlogic.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).