From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 92B075589
 for <dev@dpdk.org>; Mon, 17 Oct 2016 18:28:32 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 17 Oct 2016 09:28:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="180672974"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.83])
 ([10.237.220.83])
 by fmsmga004.fm.intel.com with ESMTP; 17 Oct 2016 09:28:30 -0700
To: Rasesh Mody <rasesh.mody@qlogic.com>, thomas.monjalon@6wind.com,
 bruce.richardson@intel.com
References: <1476562089-21823-1-git-send-email-rasesh.mody@qlogic.com>
 <1476562089-21823-3-git-send-email-rasesh.mody@qlogic.com>
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <64b17ffa-4405-98d4-29fc-180d45e74048@intel.com>
Date: Mon, 17 Oct 2016 17:28:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1476562089-21823-3-git-send-email-rasesh.mody@qlogic.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 02/32] qede/base: formatting changes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Oct 2016 16:28:33 -0000

Hi Rasesh,

On 10/15/2016 9:07 PM, Rasesh Mody wrote:
> Fixes white spaces and tabs.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---

When testing patch by patch compilation, applying this patch gives
following build error, the build error disappears after patch 12/32.

It should successfully compile after each patch, can you please fix this?


Build error:

.../drivers/net/qede/base/ecore_sp_commands.c: In function
‘ecore_sp_pf_update_tunn_cfg’:
.../drivers/net/qede/base/ecore_sp_commands.c:473:2: error: this ‘if’
clause does not guard... [-Werror=misleading-indentation]
  if (p_tunn->update_geneve_udp_port)
  ^~
.../drivers/net/qede/base/ecore_sp_commands.c:477:3: note: ...this
statement, but the latter is misleadingly indented as if it is guarded
by the ‘if’
   ecore_set_hw_tunn_mode(p_hwfn, p_hwfn->p_main_ptt,
   ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[10]: *** [base/ecore_sp_commands.o] Error 1
make[10]: *** Waiting for unfinished jobs....
.../drivers/net/qede/base/ecore_spq.c: In function ‘ecore_spq_add_entry’:
.../drivers/net/qede/base/ecore_spq.c:628:3: error: this ‘if’ clause
does not guard... [-Werror=misleading-indentation]
   if (p_ent->comp_cb.cookie == &p_ent->comp_done)
   ^~
.../drivers/net/qede/base/ecore_spq.c:631:4: note: ...this statement,
but the latter is misleadingly indented as if it is guarded by the ‘if’
    *p_en2 = *p_ent;
    ^
cc1: all warnings being treated as errors


Thanks,
ferruh