From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 243ABA04AF; Mon, 28 Sep 2020 11:04:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17A1A1D53B; Mon, 28 Sep 2020 11:04:52 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1A8881C29A; Mon, 28 Sep 2020 11:04:48 +0200 (CEST) IronPort-SDR: zYXF6vZP5vRux4XPLDvaiTFCDRRXe1DQUJWxahgn+oSzj0Q+tMTQuCk6GdxnvaWQEKi37WTUWe OVKv9VGUwJxA== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="159344356" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="159344356" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 02:04:45 -0700 IronPort-SDR: Fj6N6fWFi1MCEKNPE4+nRZ6c+WGlbqXBOIZgd/SZdupdLcAeDVoddhJy4QGoU+rsGwlO665m2n MVsgtAOhJlUg== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="456746131" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.117]) ([10.213.193.117]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 02:04:43 -0700 To: "Min Hu (Connor)" , "techboard@dpdk.org" Cc: stephen@networkplumber.org, bruce.richardson@intel.com, "jerinj@marvell.com" , dev@dpdk.org References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <1601176596-29900-1-git-send-email-humin29@huawei.com> <1601176596-29900-3-git-send-email-humin29@huawei.com> From: Ferruh Yigit Message-ID: <64be8517-6c26-6185-fb2e-981105225d90@intel.com> Date: Mon, 28 Sep 2020 10:04:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1601176596-29900-3-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V5 2/2] ethdev: change data type in TC rxq and TC txq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, base and nb_queue in the tc_rxq and tc_txq information > of queue and TC mapping on both TX and RX paths are uint8_t. > However, these data will be truncated when queue number under a TC > is greater than 256. So it is necessary for base and nb_queue to > change from uint8_t to uint16_t. > > Fixes: 01eb53eefeb40e8 ("ethdev: rename folder to library name") > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Dongdong Liu > --- > V4 -> V5: > add release notes updated. > > --- > doc/guides/rel_notes/release_20_11.rst | 5 +++++ > lib/librte_ethdev/rte_ethdev.h | 8 ++++---- > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index 1ef6f0e..ad14fd7 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -183,6 +183,11 @@ API Changes > function will be changed from ``uint8_t`` to ``uint16_t``, which supports for > using 256 or more than 256 queues and displaying all statistics of rx/tx queue. > > +* ethdev: Modified field type of base and nb_queue in struct > + ``rte_eth_dcb_tc_queue_mapping`` from ``uint8_t`` to ``uint16_t``. > + As the data of uint8_t will be truncated when queue number under > + a TC is greater than 256. > + > > ABI Changes > ----------- > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index ff3a616..2270460 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1522,13 +1522,13 @@ struct rte_eth_xstat_name { > struct rte_eth_dcb_tc_queue_mapping { > /** rx queues assigned to tc per Pool */ > struct { > - uint8_t base; > - uint8_t nb_queue; > + uint16_t base; > + uint16_t nb_queue; > } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > /** rx queues assigned to tc per Pool */ > struct { > - uint8_t base; > - uint8_t nb_queue; > + uint16_t base; > + uint16_t nb_queue; > } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > }; > > cc'ed tech-board, The patch breaks the ethdev ABI without a deprecation notice from previous release(s). It is increasing the storage size of the fields to support more than 255 queues. Since the ethdev library already heavily breaks the ABI this release, I am for getting this patch, instead of waiting for one more year for the update. Can you please review the patch, is there any objection to proceed with it?