DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [RFC] devtools: improve DPDK review process
@ 2021-04-01  9:05 Anatoly Burakov
  2021-04-01  9:50 ` Gaëtan Rivet
  2021-04-02 13:43 ` Jerin Jacob
  0 siblings, 2 replies; 5+ messages in thread
From: Anatoly Burakov @ 2021-04-01  9:05 UTC (permalink / raw)
  To: dev

A common problem on the DPDK mailing list is lack of reviewers for
patches. This script is intended to help with that problem, by picking
a random commit author from our git history, and adding a Reviewed-by:
tag. This can be added to e.g. commit-msg git hook, like so:

    # add reviewer to commit message
    $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1

Now all DPDK code will definitely be well reviewed!

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
---
 devtools/get-reviewer.sh | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100755 devtools/get-reviewer.sh

diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
new file mode 100755
index 0000000000..f4b07c9862
--- /dev/null
+++ b/devtools/get-reviewer.sh
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+# find a reviewer for the code
+git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
  2021-04-01  9:05 [dpdk-dev] [RFC] devtools: improve DPDK review process Anatoly Burakov
@ 2021-04-01  9:50 ` Gaëtan Rivet
  2021-04-01 12:05   ` Burakov, Anatoly
  2021-04-02 13:43 ` Jerin Jacob
  1 sibling, 1 reply; 5+ messages in thread
From: Gaëtan Rivet @ 2021-04-01  9:50 UTC (permalink / raw)
  To: Burakov, Anatoly, dev

On Thu, Apr 1, 2021, at 11:05, Anatoly Burakov wrote:
> A common problem on the DPDK mailing list is lack of reviewers for
> patches. This script is intended to help with that problem, by picking
> a random commit author from our git history, and adding a Reviewed-by:
> tag. This can be added to e.g. commit-msg git hook, like so:
> 
>     # add reviewer to commit message
>     $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
> 
> Now all DPDK code will definitely be well reviewed!
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
> ---
>  devtools/get-reviewer.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100755 devtools/get-reviewer.sh
> 
> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
> new file mode 100755
> index 0000000000..f4b07c9862
> --- /dev/null
> +++ b/devtools/get-reviewer.sh
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +
> +# find a reviewer for the code
> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
> -- 
> 2.25.1
> 
>

I think this is great.
However if you accelerate only one end of the pipe, you won't gain much.

Humans are still required to write patches, this is inefficient.
Here is a suggestion:

diff --git a/devtools/infinite-monkey.sh b/devtools/infinite-monkey.sh
new file mode 100755
index 0000000000..7d637266d3
--- /dev/null
+++ b/devtools/infinite-monkey.sh
@@ -0,0 +1,13 @@
+#!/usr/bin/env sh
+
+command -v csmith > /dev/null || {
+    echo 'Require csmith: https://github.com/csmith-project/csmith'
+    exit 1
+}
+
+until ninja -C build; do csmith > $(find . -name '*.c' |shuf -n 1); done
+
+git add -F .
+git commit -sm "$(dirname file): $(($(date +%s%N)/1000000))" \
+           -sm '' -sm "$(./devtools/get-reviewer.sh)"
+git send-email -1 --thread --to dev@dpdk.org

With proper perf testing at the other end, DPDK should be able to finally become web-scale.

-- 
Gaetan Rivet

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
  2021-04-01  9:50 ` Gaëtan Rivet
@ 2021-04-01 12:05   ` Burakov, Anatoly
  0 siblings, 0 replies; 5+ messages in thread
From: Burakov, Anatoly @ 2021-04-01 12:05 UTC (permalink / raw)
  To: Gaëtan Rivet, dev

On 01-Apr-21 10:50 AM, Gaëtan Rivet wrote:
> On Thu, Apr 1, 2021, at 11:05, Anatoly Burakov wrote:
>> A common problem on the DPDK mailing list is lack of reviewers for
>> patches. This script is intended to help with that problem, by picking
>> a random commit author from our git history, and adding a Reviewed-by:
>> tag. This can be added to e.g. commit-msg git hook, like so:
>>
>>      # add reviewer to commit message
>>      $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>>
>> Now all DPDK code will definitely be well reviewed!
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
>> ---
>>   devtools/get-reviewer.sh | 4 ++++
>>   1 file changed, 4 insertions(+)
>>   create mode 100755 devtools/get-reviewer.sh
>>
>> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
>> new file mode 100755
>> index 0000000000..f4b07c9862
>> --- /dev/null
>> +++ b/devtools/get-reviewer.sh
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +
>> +# find a reviewer for the code
>> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
>> -- 
>> 2.25.1
>>
>>
> 
> I think this is great.
> However if you accelerate only one end of the pipe, you won't gain much.
> 
> Humans are still required to write patches, this is inefficient.
> Here is a suggestion:
> 
> diff --git a/devtools/infinite-monkey.sh b/devtools/infinite-monkey.sh
> new file mode 100755
> index 0000000000..7d637266d3
> --- /dev/null
> +++ b/devtools/infinite-monkey.sh
> @@ -0,0 +1,13 @@
> +#!/usr/bin/env sh
> +
> +command -v csmith > /dev/null || {
> +    echo 'Require csmith: https://github.com/csmith-project/csmith'
> +    exit 1
> +}
> +
> +until ninja -C build; do csmith > $(find . -name '*.c' |shuf -n 1); done
> +
> +git add -F .
> +git commit -sm "$(dirname file): $(($(date +%s%N)/1000000))" \
> +           -sm '' -sm "$(./devtools/get-reviewer.sh)"
> +git send-email -1 --thread --to dev@dpdk.org
> 
> With proper perf testing at the other end, DPDK should be able to finally become web-scale.
> 

Yep, should be doable to achieve line rate for patches to DPDK!

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
  2021-04-01  9:05 [dpdk-dev] [RFC] devtools: improve DPDK review process Anatoly Burakov
  2021-04-01  9:50 ` Gaëtan Rivet
@ 2021-04-02 13:43 ` Jerin Jacob
  2021-04-02 16:23   ` Burakov, Anatoly
  1 sibling, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2021-04-02 13:43 UTC (permalink / raw)
  To: Anatoly Burakov, Thomas Monjalon, David Marchand, Richardson, Bruce
  Cc: dpdk-dev

On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> A common problem on the DPDK mailing list is lack of reviewers for
> patches. This script is intended to help with that problem, by picking
> a random commit author from our git history, and adding a Reviewed-by:
> tag. This can be added to e.g. commit-msg git hook, like so:
>
>     # add reviewer to commit message
>     $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>
> Now all DPDK code will definitely be well reviewed!
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>

Looks like shuf aliased  to "git shortlog --numbered --summary | head -n 1"

> ---
>  devtools/get-reviewer.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100755 devtools/get-reviewer.sh
>
> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
> new file mode 100755
> index 0000000000..f4b07c9862
> --- /dev/null
> +++ b/devtools/get-reviewer.sh
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +
> +# find a reviewer for the code
> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1

Leaving the fun part aside,

Looks like we can really improve the situation by
doing git annotate(to get the original author) of couple lines below
and above current patch
that changes lines.

Thoughts?


> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
  2021-04-02 13:43 ` Jerin Jacob
@ 2021-04-02 16:23   ` Burakov, Anatoly
  0 siblings, 0 replies; 5+ messages in thread
From: Burakov, Anatoly @ 2021-04-02 16:23 UTC (permalink / raw)
  To: Jerin Jacob, Thomas Monjalon, David Marchand, Richardson, Bruce; +Cc: dpdk-dev

On 02-Apr-21 2:43 PM, Jerin Jacob wrote:
> On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> A common problem on the DPDK mailing list is lack of reviewers for
>> patches. This script is intended to help with that problem, by picking
>> a random commit author from our git history, and adding a Reviewed-by:
>> tag. This can be added to e.g. commit-msg git hook, like so:
>>
>>      # add reviewer to commit message
>>      $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>>
>> Now all DPDK code will definitely be well reviewed!
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
> 
> Looks like shuf aliased  to "git shortlog --numbered --summary | head -n 1"
> 
>> ---
>>   devtools/get-reviewer.sh | 4 ++++
>>   1 file changed, 4 insertions(+)
>>   create mode 100755 devtools/get-reviewer.sh
>>
>> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
>> new file mode 100755
>> index 0000000000..f4b07c9862
>> --- /dev/null
>> +++ b/devtools/get-reviewer.sh
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +
>> +# find a reviewer for the code
>> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
> 
> Leaving the fun part aside,
> 
> Looks like we can really improve the situation by
> doing git annotate(to get the original author) of couple lines below
> and above current patch
> that changes lines.
> 
> Thoughts?
> 
> 
>> --
>> 2.25.1
>>

Original author or the person unlucky enough to have been the latest one 
to modify the lines in question? :)

It could be useful, but IMO it'll also result in a lot of noise. People 
already seem to be very generous with CC's so i don't think *letting 
people know* is the issue; finding time to review is.

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-02 16:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  9:05 [dpdk-dev] [RFC] devtools: improve DPDK review process Anatoly Burakov
2021-04-01  9:50 ` Gaëtan Rivet
2021-04-01 12:05   ` Burakov, Anatoly
2021-04-02 13:43 ` Jerin Jacob
2021-04-02 16:23   ` Burakov, Anatoly

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git