From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE7B2A0548; Thu, 1 Apr 2021 11:54:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1BF3140EA8; Thu, 1 Apr 2021 11:51:23 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D867F140F47 for ; Thu, 1 Apr 2021 11:51:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 809865C00B3; Thu, 1 Apr 2021 05:51:19 -0400 (EDT) Received: from imap22 ([10.202.2.72]) by compute1.internal (MEProxy); Thu, 01 Apr 2021 05:51:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type:content-transfer-encoding; s=fm1; bh=UXKr8 cWsaQgYhpwZAHvblwQroeTXEGvO5iDcvH+fStQ=; b=VAYsyGJxXTHF8Fe8pSrl8 baoCioV0J5yB6Z9KXy0rjJfWmpqJKKjvajVZFkpZpjGAm84HUyZWcCOzC9+RjXub GZjej3oR4hldEnf7SN0ugioioBabHTcbdK+sMvzOlDRx4r+RbvQwjYlNz4YqBvo8 K6WKQU+iML9FvhdoFzOaIlrCIVD+gZ28l7j6pQ0ADNZHQD8oHtZXKxiCEoK+HCaU 7CX6xdU2i4KOUqDQ7/KoIOdWrMpLBaaJj7ovwfQNFS+dSpNHPliuqbDEyRiyUpjg f6qJsQcT3ZsxIVr6DQ3GfG/wQ/FkOo6x6K6VMSVlUUw5qWg51vxsNeRMTKxrhxrQ g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UXKr8cWsaQgYhpwZAHvblwQroeTXEGvO5iDcvH+fS tQ=; b=rYvVOtRaCJYWFZv+1crkdKgXOis95xsjsd3xX5xym+Oe25smISTIfACCL um2czgb9v0uJwkCqoLUHDATe8UJo8SrzXngpEmkdgnbfLBNbn8dY8FFzoeW9wPdS EGvsjI3AAO0PHZ9QA+F1D94F28di95eHMyKCSHyk/QUnYMge47IO6r29mru6WcAp KYFcUqwDN+vbBo6C30k4qozLrdE31ZxahG/bnulWgNnsdo99eEqrB4CMQMJj48Ws s3+Z6e4OjyF4q/XrDPDdx3a7NtHyZr2KbeimbSidRpSHz4WbpPNX/Mdjpe9KOTNv veiVAntwO/TGYW0CLsK4o9LHAorKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeigedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpefirgot thgrnhgptfhivhgvthcuoehgrhhivhgvsehuvdehiedrnhgvtheqnecuggftrfgrthhtvg hrnhepieevlefghfduteeiteeuheeuheekfeetueejvdevhfevffdtgffgueevgefffeel necuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehgrhhivhgvsehuvdehiedrnhgvth X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CF17562C0064; Thu, 1 Apr 2021 05:51:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: <64c13341-24db-4fb4-8e10-94cf509badba@www.fastmail.com> In-Reply-To: <20210401090516.209155-1-anatoly.burakov@intel.com> References: <20210401090516.209155-1-anatoly.burakov@intel.com> Date: Thu, 01 Apr 2021 11:50:35 +0200 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Burakov, Anatoly" , dev@dpdk.org Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 1, 2021, at 11:05, Anatoly Burakov wrote: > A common problem on the DPDK mailing list is lack of reviewers for > patches. This script is intended to help with that problem, by picking= > a random commit author from our git history, and adding a Reviewed-by:= > tag. This can be added to e.g. commit-msg git hook, like so: >=20 > # add reviewer to commit message > $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1 >=20 > Now all DPDK code will definitely be well reviewed! >=20 > Signed-off-by: Anatoly Burakov > R=D0=B5vi=D0=B5w=D0=B5d-by: Th=D0=BEmas M=D0=BEnj=D0=B0l=D0=BEn > --- > devtools/get-reviewer.sh | 4 ++++ > 1 file changed, 4 insertions(+) > create mode 100755 devtools/get-reviewer.sh >=20 > diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh > new file mode 100755 > index 0000000000..f4b07c9862 > --- /dev/null > +++ b/devtools/get-reviewer.sh > @@ -0,0 +1,4 @@ > +#!/bin/sh > + > +# find a reviewer for the code > +git log --format=3D"Reviewed-by: %an <%ae>" | sort -u | shuf -n 1 > --=20 > 2.25.1 >=20 > I think this is great. However if you accelerate only one end of the pipe, you won't gain much.= Humans are still required to write patches, this is inefficient. Here is a suggestion: diff --git a/devtools/infinite-monkey.sh b/devtools/infinite-monkey.sh new file mode 100755 index 0000000000..7d637266d3 --- /dev/null +++ b/devtools/infinite-monkey.sh @@ -0,0 +1,13 @@ +#!/usr/bin/env sh + +command -v csmith > /dev/null || { + echo 'Require csmith: https://github.com/csmith-project/csmith' + exit 1 +} + +until ninja -C build; do csmith > $(find . -name '*.c' |shuf -n 1); don= e + +git add -F . +git commit -sm "$(dirname file): $(($(date +%s%N)/1000000))" \ + -sm '' -sm "$(./devtools/get-reviewer.sh)" +git send-email -1 --thread --to dev@dpdk.org With proper perf testing at the other end, DPDK should be able to finall= y become web-scale. --=20 Gaetan Rivet