From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: <dev@dpdk.org>, <nhorman@tuxdriver.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL
Date: Tue, 14 Feb 2017 10:48:39 +0530 [thread overview]
Message-ID: <64d01f74-ec13-cd75-210c-322f9ddcd20b@nxp.com> (raw)
In-Reply-To: <CALe+Z02ZPafsoB2+8epX5rsip8a53EO+S8_gj83s_RZPpaTPMw@mail.gmail.com>
On Tuesday 14 February 2017 03:26 AM, Jan Blunck wrote:
> On Mon, Feb 13, 2017 at 1:00 PM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
>> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
>>>
>>> EAL PCI layer is planned to be restructured in 17.05 to unlink it from
>>> generic structures like eth_driver, rte_cryptodev_driver, and also move
>>> it into a PCI Bus.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>> ---
>>> doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
>>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index fbe2fcb..b12d435 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -13,10 +13,14 @@ Deprecation Notices
>>> has exposed, like the way we have done with uio-pci-generic. This
>>> change
>>> targets release 17.05.
>>>
>>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves
>>> as
>>> - a placeholder for PMDs to register themselves. Changes for ``rte_bus``
>>> will
>>> - provide a way to handle device initialization currently being done in
>>> - ``eth_driver``.
>>
>>
>> Just to highlight, above statement was added by me in 16.11.
>> As of now I plan to work on removing rte_pci_driver from eth_driver,
>> rather than removing eth_driver all together (which, probably, was
>> better idea).
>> If someone still wishes to work on its complete removal, we can keep
>> the above. (and probably remove the below).
>>
>
> There is no benefit in keeping eth_driver and removing rte_pci_driver
> from it. Technically it isn't even needed today.
I agree with you.
I stopped working on it because I realized that removing it means making
pci_probe call eth_dev_init handlers directly. Or, restructure the whole
of pci probe stack - which, because of pending PCI bus implementation,
was slightly tentative.
Changes are already expected in EAL PCI code for bus movement, probably
this task can be combined with that.
>
>>
>>> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
>>> + unlink EAL dependency on PCI and to move PCI devices to a PCI specific
>>> + bus.
>>> +
>>> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in
>>> 17.05.
>>> + This is to unlink the ethernet driver from PCI dependencies.
>>> + Similarly, ``rte_pci_driver`` in planned to be removed from
>>> + ``rte_cryptodev_driver`` in 17.05.
>>>
>>> * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
>>> extended with new function pointer ``tx_pkt_prepare`` allowing
>>> verification
>>>
>>
>
prev parent reply other threads:[~2017-02-14 5:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 11:55 Shreyansh Jain
2017-02-13 12:00 ` Shreyansh Jain
2017-02-13 14:44 ` Thomas Monjalon
2017-02-13 16:20 ` [dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model Thomas Monjalon
2017-02-13 21:53 ` Jan Blunck
2017-02-14 0:09 ` Hemant Agrawal
2017-02-14 0:33 ` Mcnamara, John
2017-02-14 18:57 ` Thomas Monjalon
2017-02-13 21:56 ` [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL Jan Blunck
2017-02-14 5:18 ` Shreyansh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d01f74-ec13-cd75-210c-322f9ddcd20b@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=nhorman@tuxdriver.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).