From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Matan Azrad" <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop
Date: Wed, 24 Jan 2018 17:28:27 +0000 [thread overview]
Message-ID: <64d96e5a-b312-cd63-8ab1-e564e202e8b9@intel.com> (raw)
In-Reply-To: <20180124103138.5npqmzijmlqkf3ue@bidouze.vm.6wind.com>
On 1/24/2018 10:31 AM, Gaëtan Rivet wrote:
> On Wed, Jan 24, 2018 at 10:19:17AM +0000, Matan Azrad wrote:
>> In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst
>> function for packet receiving.
>>
>> This function iterates over the present sub-devices until it
>> receives a traffic from one of them or they are all cannot receive
>> packets.
>>
>> The corrupted code didn't advance the sub-device pointer when the
>> sub-device was not present and caused to infinite loop.
>>
>> Advance the sub-device pointer also in plugged-out sub-device case.
>>
>> Fixes: 8052bbd9d548 ("net/failsafe: improve Rx sub-devices iteration")
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-01-24 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 10:19 Matan Azrad
2018-01-24 10:31 ` Gaëtan Rivet
2018-01-24 17:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d96e5a-b312-cd63-8ab1-e564e202e8b9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).