From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id C4EE31B173
 for <dev@dpdk.org>; Wed, 24 Jan 2018 18:28:30 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Jan 2018 09:28:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,408,1511856000"; d="scan'208";a="29170212"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by orsmga002.jf.intel.com with ESMTP; 24 Jan 2018 09:28:28 -0800
To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= <gaetan.rivet@6wind.com>,
 Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
References: <1516789157-9234-1-git-send-email-matan@mellanox.com>
 <20180124103138.5npqmzijmlqkf3ue@bidouze.vm.6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <64d96e5a-b312-cd63-8ab1-e564e202e8b9@intel.com>
Date: Wed, 24 Jan 2018 17:28:27 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180124103138.5npqmzijmlqkf3ue@bidouze.vm.6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2018 17:28:31 -0000

On 1/24/2018 10:31 AM, Gaëtan Rivet wrote:
> On Wed, Jan 24, 2018 at 10:19:17AM +0000, Matan Azrad wrote:
>> In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst
>> function for packet receiving.
>>
>> This function iterates over the present sub-devices until it
>> receives a traffic from one of them or they are all cannot receive
>> packets.
>>
>> The corrupted code didn't advance the sub-device pointer when the
>> sub-device was not present and caused to infinite loop.
>>
>> Advance the sub-device pointer also in plugged-out sub-device case.
>>
>> Fixes: 8052bbd9d548 ("net/failsafe: improve Rx sub-devices iteration")
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied to dpdk-next-net/master, thanks.