From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Wisam Monther <wisamm@nvidia.com>,
Lance Richardson <lance.richardson@broadcom.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors
Date: Wed, 24 Feb 2021 10:12:12 +0000 [thread overview]
Message-ID: <64df8a5a-9599-927b-6408-d2dfd6e29221@intel.com> (raw)
In-Reply-To: <2946497.zBJjzZiKe1@thomas>
On 2/23/2021 8:25 PM, Thomas Monjalon wrote:
> 23/02/2021 19:39, Ajit Khaparde:
>> On Tue, Feb 23, 2021 at 10:36 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 1/31/2021 11:53 AM, Wisam Monther wrote:
>>>> Hi,
>>>>
>>>>> -----Original Message-----
>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lance Richardson
>>>>> Sent: Saturday, January 30, 2021 12:36 AM
>>>>> To: Wenzhuo Lu <wenzhuo.lu@intel.com>; Xiaoyun Li
>>>>> <xiaoyun.li@intel.com>; Bernard Iremonger
>>>>> <bernard.iremonger@intel.com>
>>>>> Cc: dev@dpdk.org; Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>;
>>>>> Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
>>>>> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum
>>>>> errors
>>>>>
>>>>> Count and display outer IP checksum errors in the checksum forwarder.
>>>>>
>>>>> Example forwarder stats output:
>>>>> RX-packets: 158 RX-dropped: 0 RX-total: 158
>>>>> Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6
>>>>> Bad-outer-ipcsum: 40
>>>>> TX-packets: 0 TX-dropped: 0 TX-total: 0
>>>>>
>>>>> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
>>>>> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
>>>>> Reviewed-by: Kalesh Anakkur Purayil <kalesh-
>>>>> anakkur.purayil@broadcom.com>
>>>>
>>>> Acked-by: Wisam Jaddo <wisamm@nvidia.com>
>>>>
>>>
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Applied to dpdk-next-net/main, thanks.
>>>
>>>
>>>
>>> 'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
>>> "/** External IP header checksum error. */"
>>>
>>> I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do
>>> you think to create another macro alias to existing one, and mark the old one as
>>> deprecated?
>> +1
>
> +1
>
Lance, can you spare some time to make the above mentioned patch?
next prev parent reply other threads:[~2021-02-24 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 22:35 Lance Richardson
2021-01-31 11:53 ` Wisam Monther
2021-02-23 18:35 ` Ferruh Yigit
2021-02-23 18:39 ` Ajit Khaparde
2021-02-23 20:25 ` Thomas Monjalon
2021-02-24 10:12 ` Ferruh Yigit [this message]
2021-02-24 15:16 ` Lance Richardson
2021-02-24 15:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64df8a5a-9599-927b-6408-d2dfd6e29221@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=lance.richardson@broadcom.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=wisamm@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).