From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C4776A034F;
	Wed, 24 Feb 2021 11:14:05 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 52D27406B4;
	Wed, 24 Feb 2021 11:14:05 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by mails.dpdk.org (Postfix) with ESMTP id ED09A4069B
 for <dev@dpdk.org>; Wed, 24 Feb 2021 11:14:03 +0100 (CET)
IronPort-SDR: lSUhx5gBjhwDcpgjPYiDOZINlL8rQbbejxxf8WJStThIDy1DWdK9MeDXjSZ5w6pWGkjkAl7z1R
 F3pK8Z1MCPlw==
X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="181691668"
X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="181691668"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Feb 2021 02:14:02 -0800
IronPort-SDR: lbAsJXR0CFBwxHobCp2QRYZGtRd6U9CQzoJwND/+m4hae3KgdVT6To+Hr/SxkaP4A8naX/DzGl
 n7IIT+H5LZMQ==
X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="442023635"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.253.18])
 ([10.213.253.18])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Feb 2021 02:12:24 -0800
To: Thomas Monjalon <thomas@monjalon.net>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Wisam Monther <wisamm@nvidia.com>,
 Lance Richardson <lance.richardson@broadcom.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
References: <20210129223554.103012-1-lance.richardson@broadcom.com>
 <d75589fe-b8c4-4e02-ece2-c3ae95dff9ef@intel.com>
 <CACZ4nhvhHR_1A2_2Rzxi_o6mtvP=rgUfBSGPi1CHXO5t1bi=aA@mail.gmail.com>
 <2946497.zBJjzZiKe1@thomas>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <64df8a5a-9599-927b-6408-d2dfd6e29221@intel.com>
Date: Wed, 24 Feb 2021 10:12:12 +0000
MIME-Version: 1.0
In-Reply-To: <2946497.zBJjzZiKe1@thomas>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum
 errors
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/23/2021 8:25 PM, Thomas Monjalon wrote:
> 23/02/2021 19:39, Ajit Khaparde:
>> On Tue, Feb 23, 2021 at 10:36 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 1/31/2021 11:53 AM, Wisam Monther wrote:
>>>> Hi,
>>>>
>>>>> -----Original Message-----
>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lance Richardson
>>>>> Sent: Saturday, January 30, 2021 12:36 AM
>>>>> To: Wenzhuo Lu <wenzhuo.lu@intel.com>; Xiaoyun Li
>>>>> <xiaoyun.li@intel.com>; Bernard Iremonger
>>>>> <bernard.iremonger@intel.com>
>>>>> Cc: dev@dpdk.org; Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>;
>>>>> Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
>>>>> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum
>>>>> errors
>>>>>
>>>>> Count and display outer IP checksum errors in the checksum forwarder.
>>>>>
>>>>> Example forwarder stats output:
>>>>>     RX-packets: 158            RX-dropped: 0             RX-total: 158
>>>>>     Bad-ipcsum: 48             Bad-l4csum: 48            Bad-outer-l4csum: 6
>>>>>     Bad-outer-ipcsum: 40
>>>>>     TX-packets: 0              TX-dropped: 0             TX-total: 0
>>>>>
>>>>> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
>>>>> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
>>>>> Reviewed-by: Kalesh Anakkur Purayil <kalesh-
>>>>> anakkur.purayil@broadcom.com>
>>>>
>>>> Acked-by: Wisam Jaddo <wisamm@nvidia.com>
>>>>
>>>
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Applied to dpdk-next-net/main, thanks.
>>>
>>>
>>>
>>> 'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as:
>>> "/** External IP header checksum error. */"
>>>
>>> I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do
>>> you think to create another macro alias to existing one, and mark the old one as
>>> deprecated?
>> +1
> 
> +1
> 

Lance, can you spare some time to make the above mentioned patch?