DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
@ 2021-01-27 16:05 Haiyue Wang
  2021-01-28  8:21 ` Yang, Qiming
  0 siblings, 1 reply; 3+ messages in thread
From: Haiyue Wang @ 2021-01-27 16:05 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Haiyue Wang

The PF will set the VLAN mode globally, DCF just needs to get the VLAN
mode.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ice/base/ice_vlan_mode.c b/drivers/net/ice/base/ice_vlan_mode.c
index 2e4c3f62c4..460c4f902b 100644
--- a/drivers/net/ice/base/ice_vlan_mode.c
+++ b/drivers/net/ice/base/ice_vlan_mode.c
@@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw *hw)
  */
 enum ice_status ice_set_vlan_mode(struct ice_hw *hw)
 {
+	/* DCF only has the ability to query the VLAN mode. Setting the VLAN
+	 * mode is done by the PF.
+	 */
+	if (hw->dcf_enabled)
+		return ICE_SUCCESS;
+
 	if (!ice_is_dvm_supported(hw))
 		return ICE_SUCCESS;
 
-- 
2.30.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
  2021-01-27 16:05 [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode Haiyue Wang
@ 2021-01-28  8:21 ` Yang, Qiming
  2021-01-28 13:29   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Yang, Qiming @ 2021-01-28  8:21 UTC (permalink / raw)
  To: Wang, Haiyue, dev; +Cc: Zhang, Qi Z

Acked-by: Qiming Yang <qiming.yang@intel.com>

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, January 28, 2021 00:05
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
> 
> The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ice/base/ice_vlan_mode.c
> b/drivers/net/ice/base/ice_vlan_mode.c
> index 2e4c3f62c4..460c4f902b 100644
> --- a/drivers/net/ice/base/ice_vlan_mode.c
> +++ b/drivers/net/ice/base/ice_vlan_mode.c
> @@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw
> *hw)
>   */
>  enum ice_status ice_set_vlan_mode(struct ice_hw *hw)  {
> +	/* DCF only has the ability to query the VLAN mode. Setting the VLAN
> +	 * mode is done by the PF.
> +	 */
> +	if (hw->dcf_enabled)
> +		return ICE_SUCCESS;
> +
>  	if (!ice_is_dvm_supported(hw))
>  		return ICE_SUCCESS;
> 
> --
> 2.30.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
  2021-01-28  8:21 ` Yang, Qiming
@ 2021-01-28 13:29   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-01-28 13:29 UTC (permalink / raw)
  To: Yang, Qiming, Wang, Haiyue, dev



> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, January 28, 2021 4:22 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
> 
> Acked-by: Qiming Yang <qiming.yang@intel.com>
> 
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Thursday, January 28, 2021 00:05
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> > Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
> >
> > The PF will set the VLAN mode globally, DCF just needs to get the VLAN
> mode.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-28 13:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 16:05 [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode Haiyue Wang
2021-01-28  8:21 ` Yang, Qiming
2021-01-28 13:29   ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git