From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode
Date: Tue, 6 Sep 2016 15:22:06 +0100 [thread overview]
Message-ID: <64efd560-66f1-0879-1f71-ee7c13d62e98@intel.com> (raw)
In-Reply-To: <072eecca-8108-a45b-91b7-7245dfbe760b@intel.com>
On 9/6/2016 3:14 PM, Ferruh Yigit wrote:
> On 9/6/2016 12:25 PM, Vladyslav Buslov wrote:
>> Allow binding KNI thread to specific core in single threaded mode
>> by setting core_id and force_bind config parameters.
>
> Thanks, patch does exactly what we talked, and as I tested it works fine.
>
> 1) There are a few comments, can you please find them inline.
>
> 2) Would you mind adding some document related this new feature?
> Document path is: doc/guides/prog_guide/kernel_nic_interface.rst
>
>>
>> Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
>> ---
...
*/
>> - if (multiple_kthread_on && dev_info.force_bind &&
>> + if (dev_info.force_bind &&
>> !cpu_online(dev_info.core_id)) {
minor thing, these two lines can join into single line ..
next prev parent reply other threads:[~2016-09-06 14:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 11:25 [dpdk-dev] [PATCH] " Vladyslav Buslov
2016-09-06 11:25 ` [dpdk-dev] [PATCH] kni: " Vladyslav Buslov
2016-09-06 14:14 ` Ferruh Yigit
2016-09-06 14:22 ` Ferruh Yigit [this message]
2016-09-06 14:30 ` Ferruh Yigit
2016-09-06 14:38 ` Vladyslav Buslov
2016-09-10 13:50 ` [dpdk-dev] [PATCH v2 1/2] " Vladyslav Buslov
2016-09-10 13:50 ` [dpdk-dev] [PATCH v2 2/2] " Vladyslav Buslov
2016-09-12 17:08 ` Ferruh Yigit
2016-09-13 10:57 ` Vladyslav Buslov
2016-09-20 18:16 ` [dpdk-dev] [PATCH] " Vladyslav Buslov
2016-09-20 18:36 ` Stephen Hemminger
2016-09-21 16:49 ` Ferruh Yigit
2016-09-21 17:15 ` Vladyslav Buslov
2016-09-21 18:23 ` Ferruh Yigit
2016-09-21 23:44 ` Stephen Hemminger
2016-09-22 9:29 ` Vladyslav Buslov
2016-09-22 15:47 ` Ferruh Yigit
2016-09-21 14:38 ` Ferruh Yigit
2016-09-24 13:13 ` Vladyslav Buslov
2016-09-26 13:58 ` Ferruh Yigit
2016-10-13 20:24 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-08-25 14:46 [dpdk-dev] [PATCH] kni: add module parameter 'bind_to_core' Ferruh Yigit
2016-09-02 15:13 ` [dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode Vladyslav Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64efd560-66f1-0879-1f71-ee7c13d62e98@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=vladyslav.buslov@harmonicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).