From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4B545A0C4D;
	Wed, 13 Oct 2021 09:06:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6600140150;
	Wed, 13 Oct 2021 09:06:11 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id B820740142
 for <dev@dpdk.org>; Wed, 13 Oct 2021 09:06:09 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 194C37F519;
 Wed, 13 Oct 2021 10:06:09 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 194C37F519
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634108769;
 bh=jumL5ZgsBq5s0OrtIthHK98GpMPalR+MEcOcV4i3Urw=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=jPLKYZnA77n/PJvzGlZzZsY9dtVqGSh5Q8cV3P02XK4qS+WZfvjcdvX5GhniV4AWx
 /enmi+UZGp9BtJ7bvwClBl5TcITqj0Iz58wa9uTbqjYAhkAFSRgLiT3urH0Hmr2aRg
 FQHw7M9LcBAu225sq7OWpv67JTYvZ4qLs944wpVE=
To: Stephen Hemminger <stephen@networkplumber.org>,
 David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, mdr@ashroe.eu, thomas@monjalon.net,
 Olivier Matz <olivier.matz@6wind.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
References: <20211012193957.21972-1-david.marchand@redhat.com>
 <20211012131456.1cae3b35@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <6503ad46-fca3-f3c8-6023-2eab27f8e7b8@oktetlabs.ru>
Date: Wed, 13 Oct 2021 10:06:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211012131456.1cae3b35@hermes.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields
 and flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/12/21 11:14 PM, Stephen Hemminger wrote:
> On Tue, 12 Oct 2021 21:39:57 +0200
> David Marchand <david.marchand@redhat.com> wrote:
> 
>> As stated in the API, dynamic field and flags should be created with no
>> additional flag (simply in the API for future changes).
>>
>> Fix the dynamic flag register helper which was not enforcing it and add
>> unit tests.
>>
>> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>