From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E51F6A0543; Tue, 25 Oct 2022 09:52:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D930642836; Tue, 25 Oct 2022 09:52:56 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C045C4282F for ; Tue, 25 Oct 2022 09:52:55 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 49D865E; Tue, 25 Oct 2022 10:52:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 49D865E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666684375; bh=Egi8NyztQtCUkcNxIZ6anzzRgdl3zKHB8Nk5PiO47fI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A41/uZbPUyYexXOpAC/MMPkjSUin9HYSj7TkodyQgaq1UjDJ/sfOoi8Wx+fu7IVxI icq4TYEc3H4Xs0wEknHNQAruYYE9lT06GmT1RhG++S5bBMIwp7Mj4KMFm31dw5wdsT jl9UfNOSEsI/hNUgNzeGtre9096J3snQW+5/RMVw= Message-ID: <6510fccc-d6c5-6021-b2ae-13e3e2bd4997@oktetlabs.ru> Date: Tue, 25 Oct 2022 10:52:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v9 02/14] net/idpf: add support for device initialization Content-Language: en-US To: "Zhang, Qi Z" , "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" Cc: "dev@dpdk.org" , "Li, Xiaoyun" , "Wang, Xiao W" References: <20221020062951.645121-2-junfeng.guo@intel.com> <20221021051821.2164939-1-junfeng.guo@intel.com> <20221021051821.2164939-3-junfeng.guo@intel.com> <6f28c2b2-cd80-e245-20f2-0498c3bfc1b8@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/21/22 15:41, Zhang, Qi Z wrote: > Hi Andrew: > >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Friday, October 21, 2022 3:48 PM >> To: Guo, Junfeng ; Zhang, Qi Z >> ; Wu, Jingjing ; Xing, Beilei >> >> Cc: dev@dpdk.org; Li, Xiaoyun ; Wang, Xiao W >> >> Subject: Re: [PATCH v9 02/14] net/idpf: add support for device initialization >> >> On 10/21/22 10:39, Andrew Rybchenko wrote: >>> On 10/21/22 08:18, Junfeng Guo wrote: >>>> Support device init and add the following dev ops skeleton: >>>>   - dev_configure >>>>   - dev_start >> >> One more question: are you sure that you can start without >> queues setup? > > I agree the patch set is not well-ordered. Keeping each increment be measurable is a good practice. We should keep this in mind. > But not sure if this is a blocking issue for patch merging as we saw the risk to have this in RC2 if we must to rework for this. > Btw, the first version of idpf PMD is quite simple. It's very similar to iavf PMD but has a few features, I see. IMHO there are too many very similar Intel drivers which just blow up code base. Just my opinion. Nothing else. > so I hope the out-of-order issue may not downgrade the readability :) > Please kindly give your suggestion. > > Thanks > Qi > >