From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23D8DA052A; Mon, 25 Jan 2021 15:50:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DDA6140EE9; Mon, 25 Jan 2021 15:50:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id C66A1140EBE for ; Mon, 25 Jan 2021 15:50:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611586237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KqXhf4Uk2EnJf8Mc78FBucqk5TuvrQOI3kS3r8CbPyQ=; b=Ut76Dzp5t8Vy0WEWObKRXUsUb3haRPM+x03KAn56scFNWzb2EXiUVfTHnv44T6fpXCnPQn k3DKPSfFXo6oJCYIvDckmWzW/0nlFZe2yCW04EGYBJ4fuGxnLB6dZ64OF/L5AgMuQZM9Bc 96Rmyw0SrchAE2cSdHGER8AfyC3F2Bc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-HUyV46OEMDypOLbdPZPn9w-1; Mon, 25 Jan 2021 09:50:33 -0500 X-MC-Unique: HUyV46OEMDypOLbdPZPn9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3ACFE80362F; Mon, 25 Jan 2021 14:50:32 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC97018A77; Mon, 25 Jan 2021 14:50:25 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "amorenoz@redhat.com" , "david.marchand@redhat.com" References: <20210119212507.1043636-1-maxime.coquelin@redhat.com> <20210119212507.1043636-37-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <6512061f-7993-31d1-e0f4-f671eb22eb61@redhat.com> Date: Mon, 25 Jan 2021 15:50:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 36/44] net/virtio: move Vhost-user reqs to Vhost-user backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/21/21 9:56 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, January 20, 2021 5:25 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.matz@6wind.com; >> amorenoz@redhat.com; david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2 36/44] net/virtio: move Vhost-user reqs to Vhost-user > > Better use full name 'requests' if the title's not too long? Fixed, that's not too long with requests. > Same thing could be done for 'net/virtio: make Vhost-user req sender consistent' Ditto > With this fixed: > > Reviewed-by: Chenbo Xia > Thanks, Maxime >> backend >> >> Now that we have a proper isolation of the backends, >> we can move Vhost-user requests declaration to the >> Vhost-user backend file. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_user/vhost.h | 25 --------------------- >> drivers/net/virtio/virtio_user/vhost_user.c | 25 +++++++++++++++++++++ >> 2 files changed, 25 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_user/vhost.h >> b/drivers/net/virtio/virtio_user/vhost.h >> index 6294b8afee..2aa6b2cb70 100644 >> --- a/drivers/net/virtio/virtio_user/vhost.h >> +++ b/drivers/net/virtio/virtio_user/vhost.h >> @@ -63,31 +63,6 @@ struct vhost_vring_addr { >> #define VHOST_USER_PROTOCOL_F_STATUS 16 >> #endif >> >> -enum vhost_user_request { >> - VHOST_USER_NONE = 0, >> - VHOST_USER_GET_FEATURES = 1, >> - VHOST_USER_SET_FEATURES = 2, >> - VHOST_USER_SET_OWNER = 3, >> - VHOST_USER_RESET_OWNER = 4, >> - VHOST_USER_SET_MEM_TABLE = 5, >> - VHOST_USER_SET_LOG_BASE = 6, >> - VHOST_USER_SET_LOG_FD = 7, >> - VHOST_USER_SET_VRING_NUM = 8, >> - VHOST_USER_SET_VRING_ADDR = 9, >> - VHOST_USER_SET_VRING_BASE = 10, >> - VHOST_USER_GET_VRING_BASE = 11, >> - VHOST_USER_SET_VRING_KICK = 12, >> - VHOST_USER_SET_VRING_CALL = 13, >> - VHOST_USER_SET_VRING_ERR = 14, >> - VHOST_USER_GET_PROTOCOL_FEATURES = 15, >> - VHOST_USER_SET_PROTOCOL_FEATURES = 16, >> - VHOST_USER_GET_QUEUE_NUM = 17, >> - VHOST_USER_SET_VRING_ENABLE = 18, >> - VHOST_USER_SET_STATUS = 39, >> - VHOST_USER_GET_STATUS = 40, >> - VHOST_USER_MAX >> -}; >> - >> #ifndef VHOST_BACKEND_F_IOTLB_MSG_V2 >> #define VHOST_BACKEND_F_IOTLB_MSG_V2 1 >> #endif >> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c >> b/drivers/net/virtio/virtio_user/vhost_user.c >> index d46e25b64b..fb6fcc82c9 100644 >> --- a/drivers/net/virtio/virtio_user/vhost_user.c >> +++ b/drivers/net/virtio/virtio_user/vhost_user.c >> @@ -27,6 +27,31 @@ struct vhost_memory { >> struct vhost_memory_region regions[VHOST_MEMORY_MAX_NREGIONS]; >> }; >> >> +enum vhost_user_request { >> + VHOST_USER_NONE = 0, >> + VHOST_USER_GET_FEATURES = 1, >> + VHOST_USER_SET_FEATURES = 2, >> + VHOST_USER_SET_OWNER = 3, >> + VHOST_USER_RESET_OWNER = 4, >> + VHOST_USER_SET_MEM_TABLE = 5, >> + VHOST_USER_SET_LOG_BASE = 6, >> + VHOST_USER_SET_LOG_FD = 7, >> + VHOST_USER_SET_VRING_NUM = 8, >> + VHOST_USER_SET_VRING_ADDR = 9, >> + VHOST_USER_SET_VRING_BASE = 10, >> + VHOST_USER_GET_VRING_BASE = 11, >> + VHOST_USER_SET_VRING_KICK = 12, >> + VHOST_USER_SET_VRING_CALL = 13, >> + VHOST_USER_SET_VRING_ERR = 14, >> + VHOST_USER_GET_PROTOCOL_FEATURES = 15, >> + VHOST_USER_SET_PROTOCOL_FEATURES = 16, >> + VHOST_USER_GET_QUEUE_NUM = 17, >> + VHOST_USER_SET_VRING_ENABLE = 18, >> + VHOST_USER_SET_STATUS = 39, >> + VHOST_USER_GET_STATUS = 40, >> + VHOST_USER_MAX >> +}; >> + >> struct vhost_user_msg { >> enum vhost_user_request request; >> >> -- >> 2.29.2 >