From: Thomas Monjalon <firstname.lastname@example.org> To: Arek Kusztal <email@example.com>, Akhil Goyal <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Anoob Joseph <email@example.com>, "Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>, Ankur Dwivedi <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "De Lara Guarch, Pablo" <email@example.com>, Nagadheeraj Rottela <firstname.lastname@example.org> Subject: Re: [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application Date: Wed, 15 Jul 2020 22:06:51 +0200 Message-ID: <6538553.9OgRhud1Dp@thomas> (raw) In-Reply-To: <VI1PR04MB3168C0FAF7834A1DDE709B76E67E0@VI1PR04MB3168.eurprd04.prod.outlook.com> 15/07/2020 21:25, Akhil Goyal: > Hi Thomas, > > > > 15/07/2020 20:26, Akhil Goyal: > > > Hi Arek, > > > > > > > > Due to increasing interest in multi process support for crypto PMDs > > > > new test app can be added so in overview we can say that: > > > > > > > > The Multi-process Crypto application is a simple application that > > > > allows to run crypto related operations in a multiple process environment. It > > > > builds on the EAL primary/secondary process infrastructure. > > > > > > > > v3: > > > > - split into multiple patches > > > > - refactored parts of code > > > > > > Looking at the comments on this patchset, I believe the app may not > > > be ready by RC2 which falls at end of this week for crypto tree. > > > I have not started review of the application yet. > > > I see it getting deferred for the next release if it is not added in RC3. > > > > In general applications are approved by the technical board. > > This app was not discussed at all. > > And I think it will be rejected, > > because I don't see the value of adding a test application just for > > multi-process usage. > > > Is this a recent change that a new application need to be discussed in techboard > first? I see that test-sad was added without discussion in the techboard. We started having such discussion this year (maybe a bit earlier), because there are too many applications, and some examples were removed. > I see this application as a useful tool to test the readiness of a driver to be used > in a multi process environment. If app is not a correct place to host it, should it be > added in examples/multi_process/. I also suggested that in v2 but it makes more > sense in app as it is a unit test application which does not have any relevance as > standalone application as crypto may not be used standalone without ethernet > for multi process scenario. > My first preference was to modify l2fwd-crypto to be used as a multi process proof > Application but it also make sense to have a unit test application to verify standalone > crypto PMDs. > Open for comments from other crypto PMD owners. I agree it looks like unit tests. Can it be added to app/test/test_cryptodev* ?
next prev parent reply other threads:[~2020-07-15 20:06 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-15 15:50 Arek Kusztal 2020-07-15 15:50 ` [dpdk-dev] [PATCH v3 1/5] app: add muli " Arek Kusztal 2020-07-15 15:50 ` [dpdk-dev] [PATCH v3 2/5] app/mp_crypto: add device configuration functions Arek Kusztal 2020-07-15 15:50 ` [dpdk-dev] [PATCH v3 3/5] app/mp_crypto: add function to allocatie mempools Arek Kusztal 2020-07-15 15:50 ` [dpdk-dev] [PATCH v3 4/5] app/mp_crypto: add enqueue-dequeue functions Arek Kusztal 2020-07-15 15:50 ` [dpdk-dev] [PATCH v3 5/5] doc: add documentation for multi process crypto app Arek Kusztal 2020-07-15 18:22 ` Akhil Goyal 2020-07-22 14:20 ` Kusztal, ArkadiuszX 2020-07-23 8:45 ` Akhil Goyal 2020-07-15 18:26 ` [dpdk-dev] [PATCH v3 0/5] app: add multi process crypto application Akhil Goyal 2020-07-15 19:11 ` Thomas Monjalon 2020-07-15 19:25 ` Akhil Goyal 2020-07-15 20:06 ` Thomas Monjalon [this message] 2020-07-15 20:15 ` Akhil Goyal 2020-07-15 20:20 ` Thomas Monjalon 2020-08-31 11:50 ` Kusztal, ArkadiuszX 2020-10-08 13:16 ` Kusztal, ArkadiuszX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6538553.9OgRhud1Dp@thomas \ --email@example.com \ --cc=Amaranath.Somalapuram@amd.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ firstname.lastname@example.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git