From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 5EBEA181 for ; Mon, 16 Mar 2015 17:30:15 +0100 (CET) Received: by webcq43 with SMTP id cq43so42322044web.2 for ; Mon, 16 Mar 2015 09:30:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Q7j7kRlKtrzLYpb8x2njzQheDDhG9iJyKe5nP9j7g+A=; b=A5mV2C9hpEMVFxivAvEONM2daXgfEYIwgbVE38Fj6FQrzHO8IJoIGCsutehFFB7A6n 1EzuAEEyDTOwH6Uz5UbJA0YM0mMkYNhkSroBtQEjgzXOmI4fw87dP3tHjO7ct0zdmBml qHinHEWHqrnAoKMHh62mupDUY3Na7VKHrtmjMBFTWj62uelQwU7O0GDJ7zRq4JaGn1Jn 5cz3hpelUheT982w9H5ku3fAOVSTJ0Bpkwbqq9QTn8FZQKS6DyrT3fxHp9AGJapqYyE/ kpE38z1r1yx+5PiRJ7ygNwWVzgqpgsQy2VQ0Z3szspa4JkhG/ePVhf8+9yZmh4WS6jFL Ls3g== X-Gm-Message-State: ALoCoQnKpKZiD5jmcgWyUeNLolNXn/xjkS3rVgqItlbG3NVCwQoKIPuDLrtoL2cm2C+OhKigip7w X-Received: by 10.194.120.132 with SMTP id lc4mr126823643wjb.92.1426523413878; Mon, 16 Mar 2015 09:30:13 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l4sm16057201wiw.6.2015.03.16.09.30.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2015 09:30:13 -0700 (PDT) From: Thomas Monjalon To: Raz Amir Date: Mon, 16 Mar 2015 17:29:39 +0100 Message-ID: <6544717.r8ii0elbbK@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <0a0a01d05cbf$7f563750$7e02a5f0$@gmail.com> References: <1424932400-66862-1-git-send-email-razamir22@gmail.com> <20150311102621.GA12704@bricha3-MOBL3> <0a0a01d05cbf$7f563750$7e02a5f0$@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] pci: save list of detached devices, and re-probe during driver unload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 16:30:15 -0000 Hi, 2015-03-12 14:24, Raz Amir: > Thank you. > Can you tell when will the patch be pushed to the source code? This is changing the behaviour. I think we should keep it for 2.1 and check if some docs must be updated in the meantime. Then we should look at general behaviour for binding/unbinding devices in DPDK. I feel it would be better to have a common behaviour with BSD, Linux UIO, Linux VFIO, etc. > -----Original Message----- > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: 11 March 2015 12:26 > To: Raz Amir > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] pci: save list of detached devices, and > re-probe during driver unload > > On Thu, Mar 05, 2015 at 06:24:23PM +0200, Raz Amir wrote: > > Added code that saves the pointers to the detached devices, during > > driver loading, and during driver unloading, go over the list, and > > re-attach them by calling device_probe_and_attach on each device. > > > > Signed-off-by: Raz Amir > Acked-by: Bruce Richardson > > > --- > > lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 34 > > ++++++++++++++++++++++++++++----- > > 1 file changed, 29 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > index 5ae8560..7a4ed5d 100644 > > --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); > > > > #define MAX_BARS (PCIR_MAX_BAR_0 + 1) > > > > +#define MAX_DETACHED_DEVICES 128 > > +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; static > > +int num_detached = 0; > > > > struct nic_uio_softc { > > device_t dev_t; > > @@ -288,17 +291,38 @@ nic_uio_load(void) > > function = strtol(token, NULL, 10); > > > > dev = pci_find_bsf(bus, device, function); > > - if (dev != NULL) > > - for (i = 0; i < NUM_DEVICES; i++) > > - if (pci_get_vendor(dev) == devices[i].vend > && > > - pci_get_device(dev) == > devices[i].dev) > > - device_detach(dev); > > + if (dev == NULL) > > + continue; > > + > > + for (i = 0; i < NUM_DEVICES; i++) > > + if (pci_get_vendor(dev) == devices[i].vend && > > + pci_get_device(dev) == > devices[i].dev) { > > + if (num_detached < > MAX_DETACHED_DEVICES) { > > + > printf("nic_uio_load: detaching and storing dev=%p\n", dev); > > + > detached_devices[num_detached++] = dev; > > + } > > + else > > + > printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. dev=%p won't be > reattached\n", > > + > MAX_DETACHED_DEVICES, dev); > > + device_detach(dev); > > + } > > } > > } > > > > static void > > nic_uio_unload(void) > > { > > + int i; > > + printf("nic_uio_unload: entered ... \n"); > > + > > + for (i = 0; i < num_detached; i++) { > > + printf("nic_uio_unload: calling to device_probe_and_attach > for dev=%p...\n", > > + detached_devices[i]); > > + device_probe_and_attach(detached_devices[i]); > > + printf("nic_uio_unload: done.\n"); > > + } > > + > > + printf("nic_uio_unload: leaving ... \n"); > > } > > > > static int > > -- > > 2.1.2 > > >