From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 03D25374E
 for <dev@dpdk.org>; Wed, 13 Sep 2017 18:51:48 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A68EC20DE5;
 Wed, 13 Sep 2017 12:51:47 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 13 Sep 2017 12:51:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Jf6P4htUpRJSYTG
 OISyLW5IDK1mdDb8BYFHDI3IF8hE=; b=am2Fwvj7HeA/Jq2VpqBBgFQU5mqBS0s
 jfiqh8yo5UX6bInLLxcKzSL1dtV1vwlI4QSkMEzLnfJrzq1Ib0FCICL4M18vrkB7
 4I/bj+FMidC33rleK9u68nAU+/JeXUAIaZUwRNbxjONohsXCAvNDjT0ONtA/Mp+O
 0ixR9u4BeXgc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=Jf6P4htUpRJSYTGOISyLW5IDK1mdDb8BYFHDI3IF8hE=; b=UoTd1OS5
 ljG3GbSn5h+kGrkuF6q6ErP1hAfS6aHBTry3kpJCW2sEWKtCKaMaFX/ypxqOleuQ
 uprXovfCCozoNBN2J7zzw6mW09Q82515UFDqBfVgFrUhQTTvhMro5PIRUQQ+MEBe
 IYdfPeTmWFwmwZbLm8NZDSG1kM4NGqu6JpWFL8k0Nnwmcgx38NGxI5+QnqFdTxtG
 YFCFkaxLe5DCy+lyic9+s3OjJ8XCOFXXpdT9XO2Wsi4uZa0lU8JzrSJEv1go3Vq2
 JAKFyNrQ6TNHZItZA8AmeAre0uxbrXvVfEcBQTxZQ4dm7gXbLwvPL2p0nyIk9c1+
 YYVrNJr6Yq2jVA==
X-ME-Sender: <xms:I2K5WSyJaxSg17222BBvzx5m6yhguX9Uwz8iF5tpYVfMqkb9SVNuqg>
X-Sasl-enc: +eL+X+A2lpqDy0set2XsOx6UUW6lIJcl5MA+w6Ypwy96 1505321507
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 524837FB4E;
 Wed, 13 Sep 2017 12:51:47 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: alan somers <asomers@gmail.com>
Cc: dev@dpdk.org
Date: Wed, 13 Sep 2017 18:51:45 +0200
Message-ID: <6545559.MRfgP3mMdQ@xps>
In-Reply-To: <CAOtMX2go--gPKb45NtJ+ww9uvM54t97NOh6OrdBb0ypQV_G71w@mail.gmail.com>
References: <20170727201212.9252-1-asomers@gmail.com> <1950575.vEqoHlsAsr@xps>
 <CAOtMX2go--gPKb45NtJ+ww9uvM54t97NOh6OrdBb0ypQV_G71w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Sep 2017 16:51:48 -0000

13/09/2017 17:55, alan somers:
> On Wed, Sep 13, 2017 at 9:39 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 13/09/2017 16:35, alan somers:
> >> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> >> > 27/07/2017 22:12, asomers@gmail.com:
> >> >> From: Alan Somers <asomers@gmail.com>
> >> >>
> >> >> "/bin/bash" is a Linuxism.  "/usr/bin/env bash" is portable.
> >> >
> >> > Why is it an issue?
> >> >
> >> > Can you run dpdk-setup.sh on a non-Linux system?
> >>
> >> Nope, because even dpdk-setup.sh assumes that bash is located at
> >> /bin/bash.  But "/usr/bin/env bash" works everywhere.
> >
> > No, I mean: can you run dpdk-setup.sh on a non-Linux system after your change?
> >
> > This script configures a Linux system, so I want to understand
> > what situation you are trying to fix.
> 
> I'm using Ceph, which imports DPDK whole (and several other 3rd party
> projects too).  I'm not sure which parts of these 3rd party projects
> Ceph is actually using, but it's easier to fix the bash path
> everywhere than to determine which places need it to be fixed.  And
> AFAIK it doesn't cause any problems on any modern Unix derivative.

If I understand well, you don't know which case it is fixing,
but you prefer the shebang being this way.

I am a bit reluctant to fix something if we don't know what is the bug.
Maybe it does not hurt, but there can be some drawbacks:
	- the chosen bash binary depends on the environment PATH
	- it makes impossible to add some options in the shebang