From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5FF492BCE for ; Fri, 30 Sep 2016 16:48:51 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 30 Sep 2016 07:48:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; d="scan'208";a="15011697" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga005.jf.intel.com with ESMTP; 30 Sep 2016 07:48:49 -0700 To: David Marchand , Yuanhan Liu References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com> <3786074.FTf50R74LC@xps13> <20160923091448.GB23158@yliu-dev.sh.intel.com> Cc: Thomas Monjalon , "dev@dpdk.org" , "Tan, Jianfeng" From: Sergio Gonzalez Monroy Message-ID: <65601617-b4a2-4971-6482-af4810dbb34a@intel.com> Date: Fri, 30 Sep 2016 15:48:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: remove single file segments related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 14:48:51 -0000 On 30/09/2016 15:32, David Marchand wrote: > On Fri, Sep 23, 2016 at 12:08 PM, Tan, Jianfeng wrote: >>> -----Original Message----- >>> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] >>> Sent: Friday, September 23, 2016 5:15 PM >>> To: Thomas Monjalon >>> Cc: dev@dpdk.org; David Marchand; Tan, Jianfeng >>> Subject: Re: [PATCH] eal: remove single file segments related code >>> >>> On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: >>>> 2016-09-23 15:10, Yuanhan Liu: >>>>> Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") >>>>> removed ivshmem support, but seems David forgot to remove the another >>>>> piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is >>> introduced >>>>> when ivshmem was firstly added. >>>> It is not a mistake. We thought it is used by container use case. >>> I think no. It would help the container case a bit, but not too much I >>> would think, especially when the memory goes fragement. >>> >>> Jianfeng, IIRC, you don't use that option for container case, right? >>> >>> --yliu >> No, I don't use this option for container case. As yuanhan said, it cannot provide much help for virtio_user memory region number limitation. > Ok, as said, since this feature had been introduced with ivshmem > 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"), > if Sergio has nothing against this removal, I am all for removing > unused code. I certainly do not have anything against this removal :) Acked-by: Sergio Gonzalez Monroy