From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 478B0A0524; Fri, 7 May 2021 18:47:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E477410FA; Fri, 7 May 2021 18:47:26 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id BE613410FA; Fri, 7 May 2021 18:47:23 +0200 (CEST) IronPort-SDR: ARFK2M/49t3ynrBaK6rcdu9TKqDnO4ogvgq71gpftzLHdGseEjIncbTu0CBW4YDNv6J/I6K6Mc /OKS4BAEKPxg== X-IronPort-AV: E=McAfee;i="6200,9189,9977"; a="195655601" X-IronPort-AV: E=Sophos;i="5.82,281,1613462400"; d="scan'208";a="195655601" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2021 09:47:22 -0700 IronPort-SDR: iNNsd9c8srE5ca5LFtESDqFAOmtx2LAE5nofwtdllE6dyhuZehGUUauY2OybW9bGn1UmRX2yVG MybbCO61Qq6A== X-IronPort-AV: E=Sophos;i="5.82,281,1613462400"; d="scan'208";a="431442500" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.210.230]) ([10.213.210.230]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2021 09:47:21 -0700 To: Michal Krawczyk , dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, stable@dpdk.org, Shay Agroskin References: <20210505073348.6394-1-mk@semihalf.com> <20210506142526.28245-1-mk@semihalf.com> <20210506142526.28245-14-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <656ad419-d748-5422-e008-759b1a724b3a@intel.com> Date: Fri, 7 May 2021 17:47:19 +0100 MIME-Version: 1.0 In-Reply-To: <20210506142526.28245-14-mk@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 13/22] net/ena: terminate devargs allowed keys with NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/6/2021 3:25 PM, Michal Krawczyk wrote: > As the documentation of rte_kvargs_parse() states, the valid_keys > argument must be NULL terminated. Lack of this feature may cause > segmentation fault if the passed devarg will be different then the > supported value. > > Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") > Cc: stable@dpdk.org > > Signed-off-by: Michal Krawczyk > Reviewed-by: Igor Chauskin > Reviewed-by: Shay Agroskin > --- > drivers/net/ena/ena_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index cb8ad5c3d0..6092288239 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter, > { > static const char * const allowed_args[] = { > ENA_DEVARG_LARGE_LLQ_HDR, > + NULL, > }; > struct rte_kvargs *kvlist; > int rc; > Acked-by: Ferruh Yigit make sen