From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BDAEA04DB; Thu, 15 Oct 2020 02:56:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 467D01DB60; Thu, 15 Oct 2020 02:56:06 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 03E2D1DB49 for ; Thu, 15 Oct 2020 02:56:00 +0200 (CEST) IronPort-SDR: EzKxRihZdF8zehQJsI4aJaAYyUNRAHb3aZazEiRkhF/WE/3yjtQs0cCO5Mo6LK9fw+ukfYQasa kpvqEv6ZM76Q== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="153164842" X-IronPort-AV: E=Sophos;i="5.77,376,1596524400"; d="scan'208";a="153164842" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 17:56:00 -0700 IronPort-SDR: QUe9s/qYmb4/kv0cla46VuVzWUAS7hxCRFJHyHHojMJlsKF2XC3809Q9pLNL4g8pcduH0nP/px UxnOMlAc40ng== X-IronPort-AV: E=Sophos;i="5.77,376,1596524400"; d="scan'208";a="464088201" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.212.224]) ([10.213.212.224]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 17:55:59 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201014055517.1214386-1-jiawenwu@trustnetic.com> <20201014055517.1214386-28-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <658ca2ee-01a2-9038-3b5a-88bf75bc33e9@intel.com> Date: Thu, 15 Oct 2020 01:55:58 +0100 MIME-Version: 1.0 In-Reply-To: <20201014055517.1214386-28-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 27/56] net/txgbe: fill receive functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 6:54 AM, Jiawen Wu wrote: > Fill receive functions and define receive descriptor. > > Signed-off-by: Jiawen Wu <...> > @@ -42,6 +54,17 @@ static const u64 TXGBE_TX_OFFLOAD_MASK = (PKT_TX_IP_CKSUM | > #define TXGBE_TX_OFFLOAD_NOTSUP_MASK \ > (PKT_TX_OFFLOAD_MASK ^ TXGBE_TX_OFFLOAD_MASK) > > +#define RTE_PMD_USE_PREFETCH > + > +#ifdef RTE_PMD_USE_PREFETCH > +/* > + * Prefetch a cache line into all cache levels. > + */ > +#define rte_txgbe_prefetch(p) rte_prefetch0(p) > +#else > +#define rte_txgbe_prefetch(p) do {} while (0) > +#endif If 'RTE_PMD_USE_PREFETCH' will be always defined, can it be removed? <...> > @@ -145,6 +239,12 @@ struct txgbe_tx_desc { > #define RX_RING_SZ ((TXGBE_RING_DESC_MAX + RTE_PMD_TXGBE_RX_MAX_BURST) * \ > sizeof(struct txgbe_rx_desc)) > > +#ifdef RTE_PMD_PACKET_PREFETCH > +#define rte_packet_prefetch(p) rte_prefetch1(p) > +#else > +#define rte_packet_prefetch(p) do {} while (0) > +#endif Since there is no config file we had in the Makebuild times, can you please document all the compile time flags that the driver is using, in the driver documentation, as they are introduced. And showing how can they be enabled via meson (meson -Dc_args="-DRTE_PMD_PACKET_PREFETCH" ... )