From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C5D742DF7; Fri, 7 Jul 2023 13:29:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65E9443042; Fri, 7 Jul 2023 13:29:55 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) by mails.dpdk.org (Postfix) with ESMTP id 0CBAE40685; Fri, 7 Jul 2023 13:29:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDe6BrR92xL1XScjGrr62pARFQCPEumJxnd6x26TkFuDYRUfU+R5XUp9bm6CJ9plpouYzTL+rCIF80eEvtDNaQK5cSYc8mn24tmqNYplKt1KsI3Va3Cl3RCKYGZ0ILcTua+fA+5LXIGrZArTgox+ex35kFxDQZTYY7Wzi6gMd/QuevcSd0MGrsPxElY5is+C0MYrtX1/C/tMrs7sfSUlcnLLlb/gjCNjkwegCSDpIzkH0r3baHBzkNMvB1VzoZcanhk26xHl4kOsH7yvRPEKv1duoozxLsNiojvGB+xiiwj0WfN1K8N2JJHUpqw+6H3omiLqobUOINj4jUVgTbnaPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=unDBUJF632Sx/03wvf8EQD53w7dzJAyapCZBkvSKiCM=; b=OQ53VMV+VPrS14rk5609nDdIxXHVNd6PITrgT5rhW+0l7HUJeWxhnSRRg7M+yLp+8040vWW8z+JfP1GhXfC50lUPnXP2hTGQmy3kfHcyj15Gvxf25CU+l/HpWsB3CsIDa6+RwqsSo0lGCAq8z5rG1HNmB6VFU90X/TzVXbtWClwoICcS33MNBcN3x33kVm83f458mk9nTFfZiTtDI1ZOeFf8LI81zIWV9j5D/ikxawLsf5LOADtxCh5Dg0ygxQ/sPfGnx2f4W0F6G/dgLobAFjLvseNRCwZXTfEspjLixSh3yo9N5faKtYbfMF0U68NJNunJ+fwTD8LTds2y8Mn9QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unDBUJF632Sx/03wvf8EQD53w7dzJAyapCZBkvSKiCM=; b=hmr8FutKJbnl8kIDg04jIgZnwHMmfFD0vDrYBaXXAj9tiuj2cJgVU6iCPhoNZaSGTB27AvIfMOYgM0TvxVshXgDkSNE9c2oXGtNszsV7B5hRHRQzwhKFNC1ai17KJKAgovu6Scg8LAgE5KuwmeDGV8HoXsww4RPSognirJj0C/A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL0PR12MB4900.namprd12.prod.outlook.com (2603:10b6:208:1c1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.24; Fri, 7 Jul 2023 11:29:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.019; Fri, 7 Jul 2023 11:29:50 +0000 Message-ID: <658d05d6-f973-439d-e62a-68a0855eca8a@amd.com> Date: Fri, 7 Jul 2023 12:29:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net/hns3: fix non-zero weight for disabled TC Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org References: <20230707104053.6571-1-liudongdong3@huawei.com> From: Ferruh Yigit In-Reply-To: <20230707104053.6571-1-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL0PR12MB4900:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ed2b4bb-d9af-42b4-dee4-08db7edd79e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hmhVM9UxgidvKaW5hLmfaBPGtjMSZ0m5I+7nDSvt33y0S+65WR8VwS1sfBay+dXKHlmP9AcwFrhqOKfVEiooojdtImgWbKQvZogYaBfzm2/KpFl9Wde7Du1fSF0ufyZ4RjVs16eGQIMJ47efWFvcatVx9YySw8L98orBPO08F1B0MKUsO8nYTbgcX41CMpuPeyE95ilw9u1w4M2ms0Hro1542xqcucWCRkxEyVsBtRKwNuaZf/jZJ6k20BKchROE0Axysyu3uceioJvLcp4vAyYjY/Chi8rTqKazuzLDU8aWKQM6eE7T4hDizNCH88MuGbuwefDLnsJIE5miCirWOrJ9Gibniahrit9K/8lTo0cbVZer+XbhjJVzM9RKPrGUtdTb8lewozGaqofoFOAOKvQ2NmXoI/ZYVv1cYJIHyl0PxNN9svGm9BoxOd85giw4JQhIllq8GYCl404vQ/Lh/CZI7k0RMP/5vge685TMdMt0ACVeuwJJopPnyGdMUj7gSGgG4LbPAAa/caFt23x7rdFnPDyOikX1Qt8tf7ymc5N2hLUZAlX/n5zuJTVOHdO5QqR8V0dRwDfq+qTjs1a/aVlUJ3glMyqHkIEr79Gb3aiqRkAlAmCBuhl4dJluHKdlKVb7Q8lBUAxkKv63le0rOauWWweWAjyLR7bnGo3A0+s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199021)(83380400001)(6506007)(186003)(53546011)(26005)(31686004)(6486002)(6666004)(478600001)(2616005)(6512007)(316002)(8676002)(66476007)(5660300002)(44832011)(4326008)(38100700002)(66946007)(41300700001)(8936002)(66556008)(2906002)(86362001)(4744005)(36756003)(31696002)(16393002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S09tNEw2WmFhN1FHamtpSjk2NFBNWHRjQjVDNWtORmlkWlpLNENWQnFEUDhX?= =?utf-8?B?MHNFMWZ3MzFJT29TTjYyZlZGdE5acXpWT1Q4aWlxejNndUNMQm9UeEl0UURw?= =?utf-8?B?OVFXRSt4UHRRNmFlNGU4RER6N0orL3JDUjZyZWlwSzdZL0RQMnF6bkR2Y3d3?= =?utf-8?B?Qy9HYjNUTjFTTWVoYXJpZ0JGN2ZQeTBvYngxdXZsTFhjS0JXVkd1aWtaNXlQ?= =?utf-8?B?cTJkR1ZEK1hCeEFiMmxMOTJDa2VhbVBsN2FVZld4cWEvVXc3UUpSWHBUSHZY?= =?utf-8?B?cllPckZYL1RJQUF1SG5teVp5TFRoeHFJYmZERW9QaTRrMDJ4WlZLM1ZEcVFr?= =?utf-8?B?VUNES2NSSmZUNUxSNEo4cXpTODBTQkJLVDV1SituRFB0eEZBQ1Vrd1BrenJl?= =?utf-8?B?NUdKa2oxUUlFUnFCN2d6YjlZOHA5bGVPTzRWSW5nMnlmUHlXRWVDcDAvdmFt?= =?utf-8?B?c05nRGF2TTdrUTNLQi9YZFcrK2J4bVUxYmVRbFFaTU16OTAveXh5ek4va3Ex?= =?utf-8?B?MFM1Zy9XeDU0dW5wVFRHTUE4eVBwbENCdnhTMWZVMWFtdVRZbHdnT3lRSTNo?= =?utf-8?B?a2t2Z2o0Q1h5aDByVU1FckNZQWNoWXpZc3JzYzZkbnpCUVlFa1A1Vmp0Skl3?= =?utf-8?B?R3VoUGg3aDR1TDVmVzhiZnd6YWFKZ3RHMTJCWnl5RjhuM1gyam1rdGgwYSt5?= =?utf-8?B?eElsanNGOVNtdW85eldXU0hYcHNmZmNLNHpjZDZneGw2ZVdhSEs1dW5sRjJ3?= =?utf-8?B?RlVWeHVoYTNDd2w4MWtBRUZKWFJKZmRtWXdqT0w4VFJ6eG52YVQ1eldaZmNC?= =?utf-8?B?b3U0VHI0MmxYY09ueWdORWZiVWgzRXJ2T1ZuVFNOaFZFK0FQbXl4TXk3Y3p4?= =?utf-8?B?S3ZNY3BSNlB6aDlBOUY3S1BnTEFTcTZWSnFmaXlOTlhVRDZlOGdVdGxmU3Uw?= =?utf-8?B?dG5tU0h3WmJYYm82dldzVDQxRmZ2eStGSm92K045TmtNVXpjWFNYeTZVb0NC?= =?utf-8?B?dmVvUGs0SjJ2bENUMkVOSzZ6blNSNktOaXNHcGM0dVFJOCtLNCtMSHJpS2J4?= =?utf-8?B?L2NXbFp3b2xEUFUwdE5rUllKS3ZjRVAxc0kwOVcrWDhIeVVRTXVKcXplSWZv?= =?utf-8?B?OHpXa2pPRWpBSklwdmVHSDhoR0pzNkJqNUhjM3lLd0VsUzJ3Qkd1ekdxSlpI?= =?utf-8?B?S2prUTJuZFJkaDFWemVrMHNncFhWSGlFejB6UHFmWS92UFhWUjRQcWx3ZzZO?= =?utf-8?B?MEJRcHRyd1h5Q3NoVGpscFJVcGNqSjA2V2ZMSFdrQmVHOUNnUjZGQ25XZnFF?= =?utf-8?B?NElpbWJhS2h2eTYrQ3h6bGNITHpZTTFKRjNtNDE5Mzg4TzU0UGpadXVDRUNo?= =?utf-8?B?U3dVN1AzRGJkc3pLTVVSK2xWdmI3TEpxZWlHODJNMFJmaUh4SFdrU0tudDRS?= =?utf-8?B?OE1PZnEyUktySG9ZRVNENk13bFlvZHQ3YTZKdFQxbk5yVGE3Yk56RUZYNzhW?= =?utf-8?B?VzYzTXB5dTluVzlzYkViTXZ3bDBWb3AxekljKzQ4MHlYVDJjRzhGdXRaK0Nn?= =?utf-8?B?L1AwalJEUVV5SmpSSEJ6OGdqcUxqbVo5NDhWY0xFSW40aEpBd3BhTnpEaFl0?= =?utf-8?B?cHgycUp5STIwNXBjTU51VC85U3JQL0l5Mmc5QXpHWTViVXR2eHAxb1JmblZh?= =?utf-8?B?d3JmOGJCbmNDN2xReEk4RHF6ME54UFZqWS9oZUV6WU9iOTVQZFBicXh0Z0tT?= =?utf-8?B?M0J3SmZ2OGR1VHVlbU0xWFFiQVJqQUh5TEppeDB0cEhQeTVwS1o1VlhPTnRT?= =?utf-8?B?WGd2Sml5R1RKQzZjZ3JEN1R0MStDNk1OTlN1UnJLVjNla0NSYzY4M1ZQK0ww?= =?utf-8?B?blV5b3hDTGdyc09jUW11K3ZVWWhaZ3Y1NXZtczZFckwrbHgxZllKcFZmZG9G?= =?utf-8?B?elJzVDdJR1RoUEl0SWVhYzg3ZEtYUjQvSUFKTVEzUmJmZHV0Q2psaVB3RnVE?= =?utf-8?B?dEhza3pWdlNHR1QxenUyU2Nka3pBVC9JdStHK0laS1lFQnQ0QmZQQi80WXVu?= =?utf-8?B?S1BHYUVVRFdIL3BOdGtUZE1QaXlhRmFNcVVWYzhzM21CODlhaHpRTXB0cXVV?= =?utf-8?Q?/sZqzJ5+qg3tpGv3CKEm2ot3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ed2b4bb-d9af-42b4-dee4-08db7edd79e6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 11:29:50.3309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SCH8SctMEf7JNQZvxB4yzokanKY9CIDdupnXJjyaBZw4DbMnChD2Ib2RT21/lVZD X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4900 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/2023 11:40 AM, Dongdong Liu wrote: > From: Huisong Li > > hns3 PF driver enables one TC, allocates to 100% weight for this > TC and 0% for other disabled TC by default. But driver modifies > the weight to 1% for disabled TC and then set to hardware to make > all TC work in DWRR mode. As a result, the total percent of all TC > is more than 100%. Actually, this operation is also redundant, > because these disabled TC will never be used. So this patch sets > the weight of all TC based on user's configuration. > > Fixes: 62e3ccc2b94c ("net/hns3: support flow control") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu > Applied to dpdk-next-net/main, thanks.