From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 461E8137D
 for <dev@dpdk.org>; Fri, 28 Nov 2014 16:56:08 +0100 (CET)
Received: by mail-wi0-f182.google.com with SMTP id h11so11639355wiw.3
 for <dev@dpdk.org>; Fri, 28 Nov 2014 07:56:08 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=86JIRaigd4GQdzd7RXZ2QgfjyHYddm+n2dB4pCJt+cI=;
 b=iJm9YBVy2VEkpE9/NpDUeDoJWpMAgomrxQENR8yd6TCLU7oGVPKbrnxOxCn6cHh2h/
 VvaVQn6nDKzlcpgB3PIKldy5kD8/qdn3bkZpWdEXVolm86H8CMCVjono2oNupH1riomp
 OQTLSrynhGzJpR/KOm+NCLAK20Z72avNys5GeLuU6bRQQmt6rPqZa+eN6NiMbUbfLxRz
 xPX1t5l/LKqqqG23OH+Tq6r5nP5Ad1oofvkwtAMp92lyuXiAtPp2l2YmOLEADxlVrZAE
 C+FhKYWvNfK1ZXp6fTlfuiwJkE095peAIKSZQiyV6tE+WADY4+dr9admZkTc73FQm6ZV
 p+2g==
X-Gm-Message-State: ALoCoQkOVY9h8dp1272XN/sLLLPufmTGITJFOISlXhtyphTct34pAg8b/Oftt7xlnM+BuNqjKajm
X-Received: by 10.180.8.34 with SMTP id o2mr60443601wia.23.1417190168104;
 Fri, 28 Nov 2014 07:56:08 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id kn5sm15503242wjb.48.2014.11.28.07.56.06
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 28 Nov 2014 07:56:07 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Date: Fri, 28 Nov 2014 16:55:44 +0100
Message-ID: <6592533.mQvpkUAhuR@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com>
References: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2014 15:56:08 -0000

2014-10-23 16:36, Sergio Gonzalez Monroy:
> Building combined shared libraries results in applications being linked
> against separeted/individual and combined libs altogether.
> 
> Link only against combined lib when the config option is enabled.
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
[...]
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -217,6 +217,12 @@ endif
>  
>  endif # plugins
>  
> +ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
> +LDLIBS = --whole-archive

You are resetting LDLIBS here.
It's not easy to read and probably not desired.
I think it would be better to explicitly disable separated libs
in this case.

> +LDLIBS += --start-group
> +LDLIBS += -l$(RTE_LIBNAME)
> +endif

Thanks
-- 
Thomas