From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E54B07E23 for ; Fri, 2 Oct 2015 18:27:49 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 02 Oct 2015 09:27:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,624,1437462000"; d="scan'208";a="572898845" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2015 09:27:19 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 2 Oct 2015 09:27:14 -0700 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.45]) by fmsmsx116.amr.corp.intel.com ([169.254.2.123]) with mapi id 14.03.0248.002; Fri, 2 Oct 2015 09:27:14 -0700 From: "Arevalo, Mario Alfredo C" To: "Richardson, Bruce" , Panu Matilainen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind files Thread-Index: AQHQ+93H3at4b0ZvlUCYdWqsb9S1Zp5YfbAAgAABbID//+dwmg== Date: Fri, 2 Oct 2015 16:27:12 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F0DBD3F@fmsmsx107.amr.corp.intel.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-7-git-send-email-mario.alfredo.c.arevalo@intel.com> <560E6144.7020607@redhat.com>, <59AF69C657FD0841A61C55336867B5B03594B730@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B03594B730@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.3.86.137] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 16:27:50 -0000 Hi, Panu and Bruce, sounds good your suggestion :) , then I'm going=0A= to change the patch for installing dpdk_nic_bind.py and cpu_layout.py in = /usr/bin=0A= =0A= Thanks.=0A= Mario.=0A= ________________________________________=0A= From: Richardson, Bruce=0A= Sent: Friday, October 02, 2015 3:54 AM=0A= To: Panu Matilainen; Arevalo, Mario Alfredo C; dev@dpdk.org=0A= Subject: RE: [dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind= files=0A= =0A= > -----Original Message-----=0A= > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen=0A= > Sent: Friday, October 2, 2015 11:50 AM=0A= > To: Arevalo, Mario Alfredo C; dev@dpdk.org=0A= > Subject: Re: [dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic=0A= > bind files=0A= >=0A= > On 10/01/2015 03:11 AM, Mario Carrillo wrote:=0A= > > Add hierarchy-file support to the DPDK nic bind files, when invoking=0A= > > "make install-sbin" nic bind files will be installed by default in:=0A= > > $(DESTDIR)/$(SBIN_DIR) where SBIN_DIR=3D/usr/sbin/dpdk_nic_bind by=0A= > > default, you can override SBIN_DIR var.=0A= > > This hierarchy is based on:=0A= > > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html=0A= > > and dpdk spec file.=0A= > >=0A= > > Signed-off-by: Mario Carrillo =0A= > > ---=0A= > > mk/rte.sdkinstall.mk | 14 ++++++++++++++=0A= > > mk/rte.sdkroot.mk | 4 ++--=0A= > > 2 files changed, 16 insertions(+), 2 deletions(-)=0A= > >=0A= > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index=0A= > > 5a2fd40..4eecf31 100644=0A= > > --- a/mk/rte.sdkinstall.mk=0A= > > +++ b/mk/rte.sdkinstall.mk=0A= > > @@ -46,11 +46,13 @@ else=0A= > > INCLUDE_DIR ?=3D /usr/include/dpdk=0A= > > BIN_DIR ?=3D /usr/bin=0A= > > DOC_DIR ?=3D /usr/share/doc/dpdk=0A= > > +SBIN_DIR ?=3D /usr/sbin/dpdk_nic_bind=0A= > > HSLINKS :=3D $(wildcard $(RTE_OUTPUT)/include/*)=0A= > > BINARY_FILES :=3D $(patsubst %.map,,$(wildcard $(RTE_OUTPUT)/app/*))= =0A= > > LIBS :=3D $(wildcard $(RTE_OUTPUT)/lib/*)=0A= > > MODULES :=3D $(wildcard $(RTE_OUTPUT)/kmod/*)=0A= > > DOCS :=3D $(wildcard $(BUILD_DIR)/doc/*)=0A= > > +NIC_BIND_FILES :=3D $(wildcard $(BUILD_DIR)/tools/*nic_bind.py)=0A= > > include $(BUILD_DIR)/build/.config=0A= > > RTE_ARCH :=3D $(CONFIG_RTE_ARCH:"%"=3D%)=0A= > > RTE_EXEC_ENV :=3D $(CONFIG_RTE_EXEC_ENV:"%"=3D%) @@ -161,6 +163,18 @@= =0A= > > install-doc:=0A= > > echo installing: $$DOC; \=0A= > > done=0A= > > #=0A= > > +# install nic bind files in /usr/sbin/dpdk_nic_bind # by default=0A= > > +SBIN_DIR can be overridden.=0A= > > +#=0A= >=0A= > This creates an out-of-path directory /usr/sbin/dpdk_nic_bind/ in which= =0A= > the dpdk_nic_bind.py is installed. Besides not being a very accessible=0A= > location, the FHS explicitly forbids creation of subdirectories below=0A= > /usr/[s]bin.=0A= >=0A= > SBIN_DIR should be /usr/sbin unless overridden, but OTOH I think this=0A= > could go into /usr/bin just as well, the split is fairly ambiguous anyway= =0A= > (I mean, testpmd is not something a regular user is going to run=0A= > either)=0A= >=0A= > In addition, if dpdk_nic_bind.py is installed then perhaps the=0A= > cpu_layout.py utility should be installed too?=0A= >=0A= > - Panu -=0A= =0A= I think there are better utilities available for determining the core layou= t=0A= that cpu_layout.py. "lstopo", for one, is much more powerful. Do we want/ne= ed=0A= to keep our own script around for that?=0A= =0A= /Bruce=0A=