From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B6D4058D4 for ; Fri, 27 Nov 2015 22:05:51 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 27 Nov 2015 13:05:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,353,1444719600"; d="scan'208";a="3356985" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 27 Nov 2015 13:05:50 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 27 Nov 2015 13:05:50 -0800 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.71]) by fmsmsx117.amr.corp.intel.com ([169.254.3.91]) with mapi id 14.03.0248.002; Fri, 27 Nov 2015 13:05:49 -0800 From: "Arevalo, Mario Alfredo C" To: "Yigit, Ferruh" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod) Thread-Index: AQHRKS833P09fDAcPkCJFlN1BfARCp6wWtPM Date: Fri, 27 Nov 2015 21:05:49 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F7839A3@fmsmsx107.amr.corp.intel.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1442608390-12537-8-git-send-email-mario.alfredo.c.arevalo@intel.com> <5600FB8B.6070909@redhat.com> <7380042.Av6xXtCM9v@xps13>,<20151127160103.GA32227@sivlogin002.ir.intel.com> In-Reply-To: <20151127160103.GA32227@sivlogin002.ir.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.46] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 21:05:52 -0000 Hi ferruh,=0A= =0A= thank you for your comments in this serie of patches :) , I have been=0A= working on different new patches version in order to improve them according= =0A= to feedback from different developers, at this moment I have sent the versi= on 6=0A= I would like to know your point of view and the point of view from more dev= elopers about it :)=0A= this is the link where you can see the 6 version:=0A= =0A= http://dpdk.org/ml/archives/dev/2015-November/027988.html=0A= =0A= Thank you.=0A= Mario.=0A= ________________________________________=0A= From: dev [dev-bounces@dpdk.org] on behalf of Ferruh Yigit [ferruh.yigit@in= tel.com]=0A= Sent: Friday, November 27, 2015 8:01 AM=0A= To: Thomas Monjalon=0A= Cc: dev@dpdk.org=0A= Subject: Re: [dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (li= nux mod)=0A= =0A= On Fri, Nov 27, 2015 at 04:40:51PM +0100, Thomas Monjalon wrote:=0A= > 2015-09-22 09:56, Panu Matilainen:=0A= > > On 09/18/2015 11:33 PM, Mario Carrillo wrote:=0A= > > > +MOD_DIR :=3D $(DESTDIR)/lib/modules=0A= > > > +KERNEL_DIR :=3D $(shell uname -r)/extra=0A= > >=0A= > > Please don't assume one is always building for the running kernel.=0A= > > Defaulting around uname -r is perfectly reasonable, but there needs to= =0A= > > be a way to override it from the cli. For example rte.vars.mk has this:= =0A= > >=0A= > > # can be overriden by make command line or exported environment variabl= e=0A= > > RTE_KERNELDIR ?=3D /lib/modules/$(shell uname -r)/build=0A= >=0A= > For info, the ?=3D operator is a way to give a default value after having= =0A= > included other makefiles which may set a different value.=0A= > Both ?=3D and :=3D (or simply =3D) are overriden by the command line.=0A= > Only "override VAR =3D" will not be overriden by the command line.=0A= >=0A= =0A= As far as I know only "?=3D" assignment overridden by command line.=0A= =0A= Basic experiment:=0A= =0A= # cat Makefile=0A= A ?=3D a=0A= B :=3D b=0A= C =3D c=0A= =0A= all:=0A= @echo $(A) $(B) $(C)=0A= =0A= -----=0A= =0A= # make=0A= a b c=0A= =0A= # A=3Dx B=3Dx C=3Dx make=0A= x b c=0A= =0A= =0A= ferruh=0A=