From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 63F7569C8 for ; Mon, 30 Nov 2015 17:26:41 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 30 Nov 2015 08:26:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,364,1444719600"; d="scan'208";a="831019828" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2015 08:26:08 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 30 Nov 2015 08:26:07 -0800 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.71]) by fmsmsx111.amr.corp.intel.com ([169.254.12.239]) with mapi id 14.03.0248.002; Mon, 30 Nov 2015 08:26:07 -0800 From: "Arevalo, Mario Alfredo C" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 06/10] mk: Add rule for installing sdk files Thread-Index: AQHRG9pJVj842qdInkeIxUBgWviWjp61ZHiA//97LRY= Date: Mon, 30 Nov 2015 16:26:07 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F783DFA@fmsmsx107.amr.corp.intel.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-7-git-send-email-mario.alfredo.c.arevalo@intel.com>, <4614982.E3BTLgVdAm@xps13> In-Reply-To: <4614982.E3BTLgVdAm@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.46] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Venegas Munoz, Jos C" Subject: Re: [dpdk-dev] [PATCH v6 06/10] mk: Add rule for installing sdk files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 16:26:41 -0000 Thank you for your feedback Thomas, I'm going to take note for a version 6 = patches :)=0A= =0A= Mario.=0A= ________________________________________=0A= From: Thomas Monjalon [thomas.monjalon@6wind.com]=0A= Sent: Monday, November 30, 2015 8:20 AM=0A= To: Arevalo, Mario Alfredo C=0A= Cc: dev@dpdk.org; Venegas Munoz, Jos C=0A= Subject: Re: [dpdk-dev] [PATCH v6 06/10] mk: Add rule for installing sdk fi= les=0A= =0A= Hi,=0A= =0A= 2015-11-10 11:07, Mario Carrillo:=0A= > Add hierarchy-file support to the DPDK makefiles, scripts,=0A= > examples, tools, config files and headers,=0A= > when invoking "make install-sdk" makefiles, scripts,=0A= > examples, tools, config files will be installed in:=0A= =0A= The tools are part of the runtime, not the sdk.=0A= =0A= > $(DESTDIR)/$(SDK_DIR)=0A= > and headers will be installed in:=0A= > $(DESTDIR)/$(INCLUDE_DIR)=0A= > where SDK_DIR=3D$(RTE_PREFIX)/share/dpdk,=0A= > INCLUDE_DIR=3D$(RTE_PREFIX)/include/dpdk=0A= > RTE_PREFIX=3D/usr/local by default, you can override RTE_PREFIX, SDK_DIR= =0A= > and INCLUDE_DIR vars.=0A= > This hierarchy is based on:=0A= > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html=0A= =0A= It would be better to follow the GNU standard to name the variables:=0A= https://www.gnu.org/prep/standards/html_node/Directory-Variables.html=0A= https://www.gnu.org/prep/standards/html_node/DESTDIR.html=0A= =0A= prefix ?=3D /usr/local=0A= exec_prefix ?=3D $(prefix)=0A= bindir ?=3D $(exec_prefix)/bin=0A= sbindir ?=3D $(exec_prefix)/sbin=0A= libdir ?=3D $(exec_prefix)/lib=0A= includedir ?=3D $(prefix)/include/dpdk=0A= datarootdir ?=3D $(prefix)/share=0A= docdir ?=3D $(datarootdir)/doc/dpdk=0A= datadir ?=3D $(datarootdir)/dpdk=0A= =0A= I would add:=0A= =0A= kerneldir ?=3D $(exec_prefix)/kmod=0A= sdkdir ?=3D $(datadir)=0A= =0A=