From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 0115B1B657 for ; Wed, 18 Oct 2017 07:11:57 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id d28so3081132pfe.2 for ; Tue, 17 Oct 2017 22:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1v+xTD7TgrKVR1UVgXO42sYfdN4L3uQRgchbf1ieUd0=; b=xSbIlY4FJEJ1i7z1GswQBO6XqxRiFaX6o8ivumEXGtbB38pMJR6UQUHXe9hOhBQm0H efak1vNzKVrT0ZBjPUwkRip51rQqzh2pioei0QKY2+E0ej1C2j28cdn/r6kplhGb57/s oajKgUe+VJ/aQyUggPJkyibR0lFfVDtIp0zqO+ZRYk8nmvil5YHS5aXyu7ocUvSGRtXB EABeNoJRyefPuvTV/IKo5gJaOfCD3UnmUVqvaw0YPiH4m3ks5OPnzpRsEOO+7CLpwCfH 1X5DeDR4baVifn8VlecnB6ufliXVPO3I8/X6k9G7UHEYF1jscSDJCFLwVLJEvBNpRt6f Qy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1v+xTD7TgrKVR1UVgXO42sYfdN4L3uQRgchbf1ieUd0=; b=thFt7r0qAPQfhFBSBUQrkvoWuiTRI0k4z9Cs91vnONfQZVanCFeEF516lvM738Oynv lyXHId6PT4wIIjpzMA2BCLsTLGW+CqwBnbr2X69RaA2qECcVI6ZxZNvyodNXIgIQIBUk b8Qfa/W6cPD9iwY5jD+LMBuqEiFrDsUU/uk4JRRSaCP1cRmyG8fPMi9TPTnmB2KvFXgb vJaR3rh/d+0VMF/1LENwxQQX2aSgg4nSa0mXqNpfsO5pivRi3HdNlkOKh8Yr1uGT4nnk 516jtBwjhsrGMfApGcZCDjduzgCTCokNgbMN25xuH6I8OKNpk1NNnk/d4SOM+o4BdK0v Jt6A== X-Gm-Message-State: AMCzsaU7MXKnVqNuyxPOLKbYa12cqOTBDCNd4Yu7xzaibuGC4khFNZNa py9t+I9KfHDSfcxOwe9RPvasQPHp X-Google-Smtp-Source: AOwi7QCtlQzkbTSsXKPKiN8YznBXf0w0sVjUNSiS99y+ZCAAao7b9LTYf2OPed/73WjBqMxDL/waUQ== X-Received: by 10.98.56.204 with SMTP id f195mr13718861pfa.188.1508303517079; Tue, 17 Oct 2017 22:11:57 -0700 (PDT) Received: from [10.61.2.175] ([122.99.82.10]) by smtp.googlemail.com with ESMTPSA id t81sm21032518pfg.187.2017.10.17.22.11.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 22:11:56 -0700 (PDT) To: Thomas Monjalon , "Burakov, Anatoly" Cc: dev@dpdk.org References: <20170426080908.24026-1-aik@ozlabs.ru> <1734105.V98Xar4r66@xps> From: Alexey Kardashevskiy Message-ID: <65996a36-e64e-248c-d22b-cd9db1ba5e3f@ozlabs.ru> Date: Wed, 18 Oct 2017 16:11:53 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1734105.V98Xar4r66@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 05:11:58 -0000 On 18/10/17 03:13, Thomas Monjalon wrote: > 28/04/2017 13:19, Burakov, Anatoly: >> From: Alexey Kardashevskiy >>> VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for >>> just created DMA window. It happens to start from zero because the default >>> window is removed (leaving no windows) and new window starts from zero. >>> However this is not guaranteed and a new window may start from another >>> address, this adds a check and an error message. >>> >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> Changes: >>> v2: >>> * this just prints warning and fails instead of incorrectly changing IOVA >>> addresses >>> --- >> >> Hi Alexey, >> >> There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :) >> >> I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though. > > Please, can we progress on this patch? > Is it still a relevant patch? Nope, http://dpdk.org/browse/dpdk/commit/?id=ed1e7e576be219e1e has the warning, this is enough really. > If yes, someone to make a v3, please? > -- Alexey